Replaced GSWElementIDString by GSWElementID, minor optimizations and

code cleaning


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/gsweb/trunk@20455 72102866-910b-0410-8b05-ffd578937521

ChangeLog

@@ -1,3 +1,76 @@
+2004-12-15  Manuel Guesdon <mguesdon@orange-concept.com>
+	* README:
+		o added a not on GSWElementIDString/GSWElementID 
+		change
+	* INSTALL:
+		o Changed from 1.1.0 to 1.2.0
+	* Version
+		o Changed from 1.1.0 to 1.2.0
+	* GSWeb.framework/GSWElementID.[hm]
+		o added (replacement for GSWElementIDString)
+	* GSWeb.framework/GSWElementIDString.[hm]
+		o removed (replaced by GSWElementID)
+	* GSWeb.framework/GNUmakefile:
+		o replaced GSWElementIDString by GSWElementID	
+	* GSWeb.framework/GSWContext.[hm]:
+		o changed -elementID type
+		o changed _elementID type 
+		o replaced GSWElementIDString by GSWElementID
+		o replaced _elementID by [_elementID elementIDString] when necessary
+		o added -isParentSenderIDSearchOver
+		o added -isSenderIDSearchOver
+	* GSWeb.framework/GSWeb.h:
+		o replaced GSWElementIDString by GSWElementID
+		o replaced [elementID isSearchOverForSenderID:senderID] by [context isSenderIDSearchOver]
+	* GSWeb.framework/GSWWOCompatibility.h
+		o replaced GSWElementIDString by GSWElementID
+	* GSWeb.framework/GSWComponent.m:
+		o replaced GSWElementIDString by NSString
+		o replaced ..isSearchIsOver... by isParentSenderIDSearchOver call
+	* GSWeb.framework/GSWComponentContent.m:
+		o replaced [(GSWElementIDString*)[aContext elementID]elementsNb]; by [aContext elementIDElementsCount];
+		o use GSWDeclareDebugElementIDsCount,...
+	* GSWeb.framework/GSWComponentReference.m:
+		o replaced [(GSWElementIDString*)[aContext elementID]elementsNb]; by [aContext elementIDElementsCount];
+		o use GSWDeclareDebugElementIDsCount,...
+	* GSWeb.framework/GSWForm.m:
+		o replaced [(GSWElementIDString*)[aContext elementID]elementsNb]; by [aContext elementIDElementsCount];
+		o replaced GSWElementIDString by NSString
+		o use GSWDeclareDebugElementIDsCount,...
+	* GSWeb.framework/GSWHyperlink.m
+		o replaced [(GSWElementIDString*)[aContext elementID]elementsNb]; by [aContext elementIDElementsCount];
+		o use GSWDeclareDebugElementIDsCount,...
+	* GSWeb.framework/GSWRepetition.m
+		o replaced [(GSWElementIDString*)[aContext elementID]elementsNb]; by [aContext elementIDElementsCount];
+		o replaced GSWElementIDString by NSString
+		o use GSWDeclareDebugElementIDsCount,...
+	* GSWeb.framework/GSWSubmitButton.m:
+		o replaced ..isSearchIsOver... by isParentSenderIDSearchOver call
+	* GSWeb.framework/GSWHTMLDynamicElement.m
+		o replaced [elementID isSearchOverForSenderID:senderID] by [context isSenderIDSearchOver]
+		o use IMP for elementID appendZero.../deleteLast...
+	* GSWeb.framework/GSWHTMLStaticElement
+		o replaced [elementID isSearchOverForSenderID:senderID] by [context isSenderIDSearchOver]
+	* GSWeb.framework/GSWGenericElement.m:
+		o replaced  [elementID description] by elementID
+	* GSWeb.framework/GSWElement.h:
+		o declared GSWDeclareDebugElementID to replace NSString* debugElementID=[TheContext elementID]
+		o declared GSWDeclareDebugElementIDsCount to replace int elementsNb=[context elementIDElementsCount];
+		o declared GSWAssertDebugElementIDsCount to replace Assert on elementsIDCount
+		o replaced some NDEBBUG by GSWDEBUG_ELEMENTSIDS		
+	* GSWeb.framework/GSWElement.m:
+		o reformatted some code
+		o replaced some NDEBBUG by GSWDEBUG_ELEMENTSIDS
+	* GSWExtensionsGSW.framework/GSWCacheElement.m:
+		o replaced [(GSWElementIDString*)[aContext elementID]elementsNb]; by [aContext elementIDElementsCount];
+		o use GSWDeclareDebugElementIDsCount,...
+	* GSWExtensions.framework/GSWCollapsibleComponentContent.m
+		o use copy of elementID to avoid string recreation for non mutable string
+	* GSWeb.framework/Makefile.preamble.in
+		o added ifeq GSWDEBUG_ELEMENTSIDS
+	* config.mak.in
+		o added GSWDEBUG_ELEMENTSIDS (default no)
+
 2004-12-14  Manuel Guesdon <mguesdon@orange-concept.com>
 	* GSWeb.framework/GSWAction.m: 
 		o added NSAssert in pageWithName:

GSWExtensions.framework/GSWCollapsibleComponentContent.m

@@ -62,7 +62,7 @@ RCS_ID("$Id$")
 -(void)appendToResponse:(GSWResponse*)aResponse
               inContext:(GSWContext*)aContext 
 {
-  _tmpAnchorName=[NSString stringWithString:[[self context] elementID]];
+  _tmpAnchorName=AUTORELEASE([[aContext elementID]copy]);
   [super appendToResponse:aResponse
          inContext:aContext];
   _tmpAnchorName=nil;

GSWExtensionsGSW.framework/GSWCacheElement.m

@@ -215,9 +215,7 @@ Bindings
 {
   GSWComponent* component=nil;
   BOOL isDisabled=NO;
-#ifndef NDEBBUG
+  GSWDeclareDebugElementIDsCount(aContext);
-  int elementsNb=[(GSWElementIDString*)[aContext elementID]elementsNb];
-#endif
 
   LOGObjectFnStart();
 
@@ -256,7 +254,7 @@ Bindings
       contextAndElementID=[aContext contextAndElementID];
       NSDebugMLLog(@"GSWCacheElement",@"contextAndElementID=%@",contextAndElementID);
 
-      elementID=[[[aContext elementID] copy]autorelease]; // because elementID is mutable (and varying)
+      elementID=AUTORELEASE([[aContext elementID] copy]); // because elementID is mutable (and varying)
       NSDebugMLLog(@"GSWCacheElement",@"elementID=%@",elementID);
 
       sessionID=[[aContext session] sessionID];
@@ -385,9 +383,7 @@ Bindings
 
       NSLog(@"GSWCacheElement Stop Date=%@",[NSDate date]);
 
-#ifndef NDEBBUG
+      GSWAssertDebugElementIDsCount(aContext);
-      NSAssert(elementsNb==[(GSWElementIDString*)[aContext elementID]elementsNb],@"GSWCacheElement appendToResponse: bad elementID");
-#endif
     }
   NS_HANDLER
     {

INSTALL

@@ -6,7 +6,7 @@ This file documents the installation of GNUstepWeb, `gsweb'.  Copyright
 modify it freely as long as you preserve this copyright notice and
 permission notice.
 
-   This is version 1.1.0 of GNUstepWeb.
+   This is version 1.2.0 of GNUstepWeb.
 
    This package contains GNUstepWeb library. You need to install
 GNUstep core, extensions and db libraries, GSWAdaptor and Apache

README

@@ -33,6 +33,16 @@ GNUstepWeb maintainer: Manuel Guesdon <mguesdon@gnustepweb.org>
 GNUstep discussion list: <discussion@gnustep.org>
 GNUstepWeb hackers list: http://lists.turbocat.net/mailman/listinfo.cgi/gswhackers
 
+Special Note
+=================
+*       On 2004/12/15, we've change GSWElementIDString to GSWElementID 
+                which no more inherit from NSString nor support 
+                NSString protocol.
+                Anyway, this object should be used only internally; 
+                for the developper, elemntID should be view as a NSString as 
+                returned by GSWContext -elementID.
+
+
 Special Thanks
 =================
 *	GNUstep team for their great work

Version

@@ -5,7 +5,7 @@ GNUSTEP_GCC=2.8.0
 
 # The version number of this release.
 MAJOR_VERSION=1
-MINOR_VERSION=1
+MINOR_VERSION=2
 SUBMINOR_VERSION=0
 GSWEB_VERSION=${MAJOR_VERSION}.${MINOR_VERSION}.${SUBMINOR_VERSION}
 VERSION=${GSWEB_VERSION}

config.mak.in

@@ -34,6 +34,9 @@ GSWDEBUG_LOCK=no
 #Deep logs
 GSWDEBUG_DEEP=no
 
+#Debug elmentIDs logs and asserts
+GSWDEBUG_ELEMENTSIDS=no
+
 # Default (generated by configure)
 ifeq ($(gswnames),)
 gswnames=@GSWNAMES@