Commit graph

53 commits

Author SHA1 Message Date
rfm
9ef3e2f24d Bugfix ... intenral functions should not have public visibility to linker 2025-01-26 19:01:55 +00:00
rfm
6667842dd5 Update FSF address as requested by Gregory 2024-11-07 13:37:59 +00:00
Doug Simons
fdffcbdd27
Update NSXMLElement.m to satisfy older compilers 2024-05-14 15:56:43 -06:00
Doug Simons
50f447f5b8
Fix execute_xpath() to return an NSError when expression can't be evaluated; Remove previous attributes when setting attributes; Add related tests 2024-05-14 15:25:07 -06:00
Gregory John Casamento
753c907938 Fix address for FSF and License name in all headers in base 2019-12-09 18:36:00 -05:00
David Chisnall
9b7e3a8fff Make the NSXMLNode ivar a union.
Having the same ivar exposed as different types in different compilation
units is probably a bad idea in general and will break with the new ObjC
ABI, where we have link-time checks for this.  It would also confuse
reflection and any languages that use reflection for bridging in
exciting ways.
2018-03-20 17:44:16 +00:00
fredkiefer
2901390d0f * Source/NSXMLElement.m(-addAttribute:): Correct linear list code
for name spaces. This fixes the last remaining Coverity issue.
2018-02-09 00:07:53 +01:00
Richard Frith-MacDonald
a725edd38b OSX copmpatibility tweak.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@39239 72102866-910b-0410-8b05-ffd578937521
2015-12-22 18:35:37 +00:00
Richard Frith-MacDonald
095a8cb13d osx compatibility fixup
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@39122 72102866-910b-0410-8b05-ffd578937521
2015-11-02 18:10:38 +00:00
Fred Kiefer
9629278d59 * Source/NSXMLDocument.m:
* Source/NSXMLDTD.m:
* Source/NSXMLNode.m:
* Source/NSXMLDTDNode.m:
* Source/NSXMLElement.m: Remove compiler warnings for clang
reported by David Chisnall.
* Tests/base/NSAutoreleasePool/basic.m: Get to compile again
without -C99.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@35043 72102866-910b-0410-8b05-ffd578937521
2012-04-06 22:27:55 +00:00
Fred Kiefer
3086ac94e6 * Source/NSXMLElement.m,
* Source/NSXMLNode.m: Fix compiler error and warning for older
version of libxml2.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@35024 72102866-910b-0410-8b05-ffd578937521
2012-04-03 06:25:07 +00:00
Richard Frith-MacDonald
1e5ac0ec6c fix typo
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@35005 72102866-910b-0410-8b05-ffd578937521
2012-03-27 13:24:04 +00:00
Fred Kiefer
517ef2d55f * Source/NSXMLElement.m,
* Source/NSXMLNode.m: Better support for namespaces. Corrected
-_nodeFollowingInNaturalDirection:, -setStringValue: and
-XMLStringWithOptions:


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34999 72102866-910b-0410-8b05-ffd578937521
2012-03-26 23:11:52 +00:00
Fred Kiefer
d2eaeafb2a * Source/NSXMLElement.m,
* Source/NSXMLNode.m: Fix memory leak for attribute private
documents found by valgrind.
* Tests/base/NSXMLNode/namespace.m: Use drain instead of
release.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34976 72102866-910b-0410-8b05-ffd578937521
2012-03-22 17:33:09 +00:00
Fred Kiefer
7e995ff2a8 * Source/NSXMLDocument.m (-URI, -setURI:): Specific implementation.
* Source/NSXMLPrivate.h: Remove URI ivar.
* Source/NSXMLElement.m,
* Source/NSXMLNode.m: Full support for namespaces.
* Tests/base/NSXMLNode/namespace.m: Test code borrowed from
Google data project.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34972 72102866-910b-0410-8b05-ffd578937521
2012-03-22 09:34:54 +00:00
Fred Kiefer
fa5df31b06 * Source/NSXMLDocument.m: Correct memory management.
* Source/NSXMLElement.m,
* Source/NSXMLNode.m: Add partial support for namespaces.
Try to bracket more libxml2 functions with version checks.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34967 72102866-910b-0410-8b05-ffd578937521
2012-03-21 09:01:48 +00:00
Richard Frith-MacDonald
8f42e7c2f8 Alterations for build consistency
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34966 72102866-910b-0410-8b05-ffd578937521
2012-03-21 08:00:33 +00:00
Richard Frith-MacDonald
043b774291 get the xml code to build on RedHat/CentOS
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34928 72102866-910b-0410-8b05-ffd578937521
2012-03-14 10:09:15 +00:00
Fred Kiefer
18c64eae4f * Source/NSXMLNode.m (-detach): Don't handle the namespace case.
* Source/NSXMLElement.m (-removeNamespaceForPrefix:): Implement.
* Tests/base/NSXMLNode/basic.m: Move tests from here ...
* Tests/base/NSXMLElement/basic.m: ... to here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34927 72102866-910b-0410-8b05-ffd578937521
2012-03-12 22:33:27 +00:00
Fred Kiefer
86330f01a7 * Source/NSXMLElement.m: Correct used namespace field.
* Source/NSXMLNode.m: Implement special handling for namespace
nodes.
* Tests/base/NSXMLNode/basic.m: Correct method name for
namespace node.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34926 72102866-910b-0410-8b05-ffd578937521
2012-03-12 19:50:51 +00:00
Richard Frith-MacDonald
f3da6a5455 restructure a bit to make it easier to add namespace support.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34924 72102866-910b-0410-8b05-ffd578937521
2012-03-12 13:27:32 +00:00
Fred Kiefer
9f1c97406d * Tests/base/NSXMLElement/attributes.m: Test for changed
exception.
* Tests/base/NSXMLNode/basic.m: More tests.
* Source/NSXMLNode.m: Rewrite object value handling.
* Source/NSXMLElement.m (-objectValue): Return @"" when the
value is nil.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34881 72102866-910b-0410-8b05-ffd578937521
2012-03-05 22:48:18 +00:00
Fred Kiefer
32678e3f42 * Source/NSXMLElement.m (-addAttribute:): Raise correct exception.
* Tests/base/NSXMLNode/children.m: Add test cases for attributes.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34879 72102866-910b-0410-8b05-ffd578937521
2012-03-05 09:41:40 +00:00
Fred Kiefer
4e4bf5a00c * Source/NSXMLPrivate.h: Move private method declarations for
NSXMLNode to here.
* Source/NSXMLDocument.m
* Source/NSXMLDTD.m
* Source/NSXMLDTDNode.m
* Source/NSXMLElement.m
* Source/NSXMLNode.m: Clean up and add comments about missing
code.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34877 72102866-910b-0410-8b05-ffd578937521
2012-03-04 21:40:39 +00:00
Richard Frith-MacDonald
7e75feda70 cleanups and comments.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34849 72102866-910b-0410-8b05-ffd578937521
2012-03-01 06:11:30 +00:00
Fred Kiefer
aa4ce6d720 Replace last change by a better one.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34829 72102866-910b-0410-8b05-ffd578937521
2012-02-27 18:35:38 +00:00
Fred Kiefer
ecc9ca5a69 * Source/NSXMLNode.m (+elementWithName:stringValue:): Correct
recursive call.
Patch by Ivan Vučica <ivucica@gmail.com>
* Source/NSXMLElement.m: Add FIXME comments for name space
methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34820 72102866-910b-0410-8b05-ffd578937521
2012-02-26 19:58:25 +00:00
Fred Kiefer
45ce1cac8d * Source/NSXMLElement.m: Implement namespace methods.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34808 72102866-910b-0410-8b05-ffd578937521
2012-02-23 00:01:27 +00:00
Fred Kiefer
dfb7d984d6 * Source/NSXMLNode.m (-_nodeFollowingInNaturalDirection:): Correct
this method.
* Source/NSXMLDocument.m,
* Source/NSXMLElement.m: Clean up children methods.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34807 72102866-910b-0410-8b05-ffd578937521
2012-02-22 22:52:31 +00:00
Fred Kiefer
30c7457ba0 * Source/NSXMLNode.m: Further clean up.
* Source/NSXMLDTDNode.m (-initWithXMLString:): Move comment
about missing code to here.
* Source/NSXMLElement.m (-initWithName:stringValue:): Move
subnode creation to here.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34806 72102866-910b-0410-8b05-ffd578937521
2012-02-22 10:55:12 +00:00
Gregory John Casamento
f02339adda * Source/NSXMLDocument.m
* Source/NSXMLDTD.m
	* Source/NSXMLDTDNode.m
	* Source/NSXMLElement.m
	* Source/NSXMLNode.m
	* Source/NSXMLPrivate.h: Reimplementation of all DOM classes based on
	libxml2.  Implementation of all methods using libxml2 functions.
	* Tests/base/NSXMLDocument/basic.m
	* Tests/base/NSXMLElement/attributes.m
	* Tests/base/NSXMLElement/children.m
	* Tests/base/NSXMLNode/basic.m
	* Tests/base/NSXMLNode/children.m
	* Tests/base/NSXMLNode/kinds.m: Changes to test for new functionality.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34789 72102866-910b-0410-8b05-ffd578937521
2012-02-20 03:40:15 +00:00
Richard Frith-MacDonald
e466ab2a40 fix typo
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34526 72102866-910b-0410-8b05-ffd578937521
2012-01-14 14:36:31 +00:00
Richard Frith-MacDonald
1c23e5145d Make sure code passes testsuite
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34456 72102866-910b-0410-8b05-ffd578937521
2012-01-07 13:08:03 +00:00
Gregory John Casamento
343dbf37f7 * Source/NSXMLElement.m: Removing assertion that
parent must not be nil per Cocoa documentation for
	-(id)parent method in NSXMLNode.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34450 72102866-910b-0410-8b05-ffd578937521
2012-01-06 23:00:03 +00:00
Richard Frith-MacDonald
42f0192c2c Rewrite hierarchy handling to match OSX
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34441 72102866-910b-0410-8b05-ffd578937521
2012-01-06 12:22:30 +00:00
Gregory John Casamento
e0b543f4ac * Source/NSXMLElement.m: in setChildren: set the childCount.
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34432 72102866-910b-0410-8b05-ffd578937521
2012-01-06 03:21:10 +00:00
Gregory John Casamento
98ed1c6763 * Source/NSXMLElement.m: Correct warning in copyWithZone: added
return.  Correct issue with childCount being out of sync.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34431 72102866-910b-0410-8b05-ffd578937521
2012-01-06 03:11:14 +00:00
Gregory John Casamento
5f1460c232 * Source/NSXMLElement.m: Correct warning in copyWithZone: added
return.  Correct issue with childCount being out of sync.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34430 72102866-910b-0410-8b05-ffd578937521
2012-01-06 03:09:14 +00:00
Gregory John Casamento
a3d5150a84 * ChangeLog
* Source/NSXMLDocument.m
	* Source/NSXMLElement.m
	* Source/NSXMLNode.m: Implement copyWithZone:, correct issues
	with previous revert.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34428 72102866-910b-0410-8b05-ffd578937521
2012-01-06 02:43:26 +00:00
Richard Frith-MacDonald
997222976b Little tweak to ease debugging ... get compiler to know the class of the
_internal pointer and generate information so gdb can access the internal
cass without needing a cast.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34425 72102866-910b-0410-8b05-ffd578937521
2012-01-05 20:40:12 +00:00
Richard Frith-MacDonald
1a85fb0780 Minor intiialisation tweaks to match OSX
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34423 72102866-910b-0410-8b05-ffd578937521
2012-01-05 18:55:17 +00:00
Richard Frith-MacDonald
bcd94d6a14 replace a few lost lines
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34415 72102866-910b-0410-8b05-ffd578937521
2012-01-05 15:44:45 +00:00
Richard Frith-MacDonald
ded72b8e75 Fix NSXML ABI breakage
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34412 72102866-910b-0410-8b05-ffd578937521
2012-01-04 12:41:45 +00:00
Richard Frith-MacDonald
7b7faac752 Revert ABI breakage
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34410 72102866-910b-0410-8b05-ffd578937521
2012-01-04 09:20:32 +00:00
Gregory John Casamento
6cbe121535 * Headers/Foundation/NSXMLDocument.h
* Headers/Foundation/NSXMLElement.h
	* Headers/Foundation/NSXMLNode.h: Move declarations.
	* Source/NSXMLDocument.m: Correct parsing issues.
	* Source/NSXMLElement.m: Remove local declaration of _children
	* Source/NSXMLNode.m: Remove internal.  Move all declarations here
	directly.
	
2012-01-03 14:22-EST Gregory John Casamento <greg.casamento@gmail.com>



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34408 72102866-910b-0410-8b05-ffd578937521
2012-01-03 21:42:33 +00:00
Gregory John Casamento
c7088ba09c * Headers/Foundation/NSXMLElement.h
* Headers/Foundation/NSXMLNode.h
	* Source/NSXMLElement.m
	* Source/NSXMLNode.m: Move _URI to NSXMLNode.
	change dealloc accordingly.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34406 72102866-910b-0410-8b05-ffd578937521
2012-01-03 18:10:45 +00:00
Gregory John Casamento
7dc6ad72bd * Source/NSXMLDocument.m: Change stack implementation to
use lastObject/removeLastObject to implement the stack instead
	of inserting and deleting at index 0.
	* Source/NSXMLElement.m: Implemented XMLStringWithOptions:
	* Source/NSXMLNode.m: Implemented XMLStringWithOptions:,
	skeletal implementation of setStringValue:resolvingEntities:



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34403 72102866-910b-0410-8b05-ffd578937521
2012-01-03 17:15:29 +00:00
Gregory John Casamento
fa4435dec6 * Headers/Foundation/NSXMLElement.h: Change _attributes to be
a NSMutableDictionary instead of an NSMutableArray.
	* Source/NSXMLElement.m: Change implementation of some methods
	to use an NSMutableDictionary instead of arrays.  Initialize
	ivars in initializer.
	* Source/NSXMLPrivate.h: Remove redundant method.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34394 72102866-910b-0410-8b05-ffd578937521
2012-01-03 03:28:25 +00:00
Richard Frith-MacDonald
f7b8b22bae trivial formating tweaks ... add missing white space
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34374 72102866-910b-0410-8b05-ffd578937521
2012-01-01 07:38:53 +00:00
Doug Simons
44de775895 Set Elements to be NSXMLElementKind
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@34372 72102866-910b-0410-8b05-ffd578937521
2011-12-31 02:13:19 +00:00