gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-06-02 17:41:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Source/NSDateFormatter.m

Browse source 
(-initWithDateFormat:allowNaturalLanguage:):
        Use method -setDateFormat: to get correct behaviour.
        * Source/NSDateFormatter.m (-setDateFormat:): User ASSIGNCOPY
        * for _dateFormat.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@37695 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2014-02-18 21:14:11 +00:00
parent e51bd0979d
commit d268cde2e2
2 changed files with 49 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

88
ChangeLog
View file

@ -1,17 +1,24 @@
2014-02-18 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSDateFormatter.m
(-initWithDateFormat:allowNaturalLanguage:):
Use method -setDateFormat: to get correct behaviour.
* Source/NSDateFormatter.m (-setDateFormat:): User ASSIGNCOPY for _dateFormat.
2014-02-14 Quentin Mathe <quentin.mathe@gmail.com> 2014-02-14 Quentin Mathe <quentin.mathe@gmail.com>
* Headers/Foundation/NSNotification.h * Headers/Foundation/NSNotification.h
* Source/NSNotificationCenter.m * Source/NSNotificationCenter.m
(-addObserverForName:selector:queue:usingBlock:): Added new Mac OS X 10.6 (-addObserverForName:selector:queue:usingBlock:): Added new Mac OS X 10.6
method. method.
2014-02-14 Quentin Mathe <quentin.mathe@gmail.com> 2014-02-14 Quentin Mathe <quentin.mathe@gmail.com>
* Headers/Foundation/NSSortDescriptor.h * Headers/Foundation/NSSortDescriptor.h
* Source/Foundation/NSSortDescriptor.m * Source/Foundation/NSSortDescriptor.m
(+sortDescriptorWithKey:ascending:selector:, (+sortDescriptorWithKey:ascending:selector:,
+sortDescriptorWithKey:ascending, +sortDescriptorWithKey:ascending,
-[NSSet sortedArrayUsingDescriptors:]): Added missing Mac OS X 10.6 -[NSSet sortedArrayUsingDescriptors:]): Added missing Mac OS X 10.6
methods. methods.
2014-02-13 Richard Frith-Macdonald <rfm@gnu.org> 2014-02-13 Richard Frith-Macdonald <rfm@gnu.org>
@ -26,11 +33,11 @@
2014-02-12 Quentin Mathe <quentin.mathe@gmail.com> 2014-02-12 Quentin Mathe <quentin.mathe@gmail.com>
* Tools/gsdoc-1_0_4.dtd: Added new DTD version that declares 'package' * Tools/gsdoc-1_0_4.dtd: Added new DTD version that declares 'package'
visibility as a valid ivar qualifier. visibility as a valid ivar qualifier.
* Tools/AGSParser.m: Added 'package' visibility parsing. * Tools/AGSParser.m: Added 'package' visibility parsing.
* Tools/AGSOutput.m: * Tools/AGSOutput.m:
* Tools/autogsdoc.m: * Tools/autogsdoc.m:
* Tools/GNUmakefile.m: * Tools/GNUmakefile.m:
Updated to refer to the latest DTD version. Updated to refer to the latest DTD version.
@ -64,7 +71,7 @@
* Source/NSString.m (stringByResolvingSymlinksInPath) * Source/NSString.m (stringByResolvingSymlinksInPath)
On GLIBC and FreeBSD use sysconf(_SC_SYMLOOP_MAX) instead of just On GLIBC and FreeBSD use sysconf(_SC_SYMLOOP_MAX) instead of just
MAXSYMLINKS. For HURD this is necessary, since the latter is not MAXSYMLINKS. For HURD this is necessary, since the latter is not
defined. defined.
2014-01-31 Marcus Mueller <znek@mulle-kybernetik.com> 2014-01-31 Marcus Mueller <znek@mulle-kybernetik.com>
@ -125,12 +132,12 @@
* Source/NSKeyValueMutableArray.m: * Source/NSKeyValueMutableArray.m:
* Source/NSKeyValueMutableSet.m: * Source/NSKeyValueMutableSet.m:
Don't post KVO notifications if +automaticallyNotifiesObserversForKey: Don't post KVO notifications if +automaticallyNotifiesObserversForKey:
returns NO, this ensures we match Cocoa behavior. returns NO, this ensures we match Cocoa behavior.
2014-01-18 Quentin Mathe <quentin.mathe@gmail.com> 2014-01-18 Quentin Mathe <quentin.mathe@gmail.com>
* Source/NSObject.m (-respondsToSelector, * Source/NSObject.m (-respondsToSelector,
+instancesRespondToSelector:): Fixed to check +resolveInstanceMethod: +instancesRespondToSelector:): Fixed to check +resolveInstanceMethod:
and +resolveClassMethod: as documented in Cocoa NSObject API. and +resolveClassMethod: as documented in Cocoa NSObject API.
@ -200,27 +207,27 @@
2014-01-08 Quentin Mathe <quentin.mathe@gmail.com> 2014-01-08 Quentin Mathe <quentin.mathe@gmail.com>
* Source/NSValueTransformer (+valueTransformerForName:): Fixed to * Source/NSValueTransformer (+valueTransformerForName:): Fixed to
automatically register any available NSValueTransformer subclass that automatically register any available NSValueTransformer subclass that
matches the given name and is not yet registered. This behavior is matches the given name and is not yet registered. This behavior is
described in the Cocoa API documentation. described in the Cocoa API documentation.
2014-01-08 Richard Frith-Macdonald <rfm@gnu.org> 2014-01-08 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSUUID.m: * Source/NSUUID.m:
* Source/Additions/NSData+GNUstepBase.m: * Source/Additions/NSData+GNUstepBase.m:
* Headers/GNUstepBase/NSData+GNUstepBase.h: * Headers/GNUstepBase/NSData+GNUstepBase.h:
Move random data generation out to the NSData(GNUstepBase) category. Move random data generation out to the NSData(GNUstepBase) category.
2014-01-07 Quentin Mathe <quentin.mathe@gmail.com> 2014-01-07 Quentin Mathe <quentin.mathe@gmail.com>
* Source/NSJSONSerialization.m (writeObject()): Fixed double number * Source/NSJSONSerialization.m (writeObject()): Fixed double number
serialization to encode 17 significant digits (this matches the max serialization to encode 17 significant digits (this matches the max
number of significant digits in the double-precision floating point number of significant digits in the double-precision floating point
format). This prevents a loss of precision, in case the number has format). This prevents a loss of precision, in case the number has
more than 3 digits after the decimal point. more than 3 digits after the decimal point.
* Tests/base/NSJSONSerialization/json.m: Updated to test double number * Tests/base/NSJSONSerialization/json.m: Updated to test double number
serialization. serialization.
2014-01-07 Richard Frith-Macdonald <rfm@gnu.org> 2014-01-07 Richard Frith-Macdonald <rfm@gnu.org>
@ -312,9 +319,9 @@
* Source/Additions/GCDictionary.m: * Source/Additions/GCDictionary.m:
* Source/Additions/GSInsensitiveDictionary.m: * Source/Additions/GSInsensitiveDictionary.m:
* Source/GSDictionary.m: * Source/GSDictionary.m:
Changed keys argument type to (const id <NSCopying>[]) in Changed keys argument type to (const id <NSCopying>[]) in
-initWithObjects:forKeys:count: and -initWithObjects:forKeys:count: and
+dictionaryWithObjects:forKeys:count:, +dictionaryWithObjects:forKeys:count:,
to follow the current Cocoa API. to follow the current Cocoa API.
2013-12-04 Richard Frith-Macdonald <rfm@gnu.org> 2013-12-04 Richard Frith-Macdonald <rfm@gnu.org>
@ -421,7 +428,7 @@
* configure: regenerate * configure: regenerate
Use inttypes.h rather than stdint.h as it's more inclusive and works Use inttypes.h rather than stdint.h as it's more inclusive and works
on Solaris where some defines are in the wrong place. on Solaris where some defines are in the wrong place.
2013-10-29 Richard Frith-Macdonald <rfm@gnu.org> 2013-10-29 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSTimeZone.m: Implement -hash as the hash of the time zone * Source/NSTimeZone.m: Implement -hash as the hash of the time zone
@ -516,7 +523,7 @@
* Source/Additions/GSMime.m: When creating a child parser, pass on * Source/Additions/GSMime.m: When creating a child parser, pass on
the flag to say we are parsing HTTP rather than MIME. the flag to say we are parsing HTTP rather than MIME.
2013-09-09 Richard Frith-Macdonald <rfm@gnu.org> 2013-09-09 Richard Frith-Macdonald <rfm@gnu.org>
* Source/Additions/GSMime.m: Add comments and a further fallback * Source/Additions/GSMime.m: Add comments and a further fallback
@ -670,7 +677,7 @@
* Source/NSPathUtilities.m: * Source/NSPathUtilities.m:
Disabled check for secure temporary directories under Cygwin. Refer Disabled check for secure temporary directories under Cygwin. Refer
to: to:
http://stackoverflow.com/q/9561759/39974 http://stackoverflow.com/q/9561759/39974
for a possible cause of problems. for a possible cause of problems.
@ -1253,7 +1260,7 @@
* Source/NSKeyValueObserving.m * Source/NSKeyValueObserving.m
* Source/NSXMLParser.m * Source/NSXMLParser.m
char is unsigned on macppc, so don't compare it char is unsigned on macppc, so don't compare it
against negative values against negative values
2013-03-01 Richard Frith-Macdonald <rfm@gnu.org> 2013-03-01 Richard Frith-Macdonald <rfm@gnu.org>
@ -1291,7 +1298,7 @@
of a string. of a string.
* Source/GSString.m: ([rangeOfCharacterFromSet:options:range:]) * Source/GSString.m: ([rangeOfCharacterFromSet:options:range:])
Fix for overrun when searching backwards ... spotted by Fred. Fix for overrun when searching backwards ... spotted by Fred.
2013-02-17 Richard Frith-Macdonald <rfm@gnu.org> 2013-02-17 Richard Frith-Macdonald <rfm@gnu.org>
* Source/GSAvahiRunLoopIntegration.m: Remove code which was clearing * Source/GSAvahiRunLoopIntegration.m: Remove code which was clearing
@ -1537,7 +1544,7 @@
2012-10-25 Quentin Mathe <quentin.mathe@gmail.com> 2012-10-25 Quentin Mathe <quentin.mathe@gmail.com>
* Headers/GNUstepBase/GSConfig.h.in: Prevent redefinition warnings for * Headers/GNUstepBase/GSConfig.h.in: Prevent redefinition warnings for
__STDC_LIMIT_MACROS and __STC_CONSTANT_MACROS (both are ObjC++ related). __STDC_LIMIT_MACROS and __STC_CONSTANT_MACROS (both are ObjC++ related).
2012-10-22 Thomas Davie <tom.davie@gmail.com> 2012-10-22 Thomas Davie <tom.davie@gmail.com>
@ -1732,7 +1739,7 @@
* Source/GSTimSort.m: Implement timsort sorting algorithm. * Source/GSTimSort.m: Implement timsort sorting algorithm.
* Source/GSQuickSort.m * Source/GSQuickSort.m
* Source/GSShellSort.m: * Source/GSShellSort.m:
Factor out previously used sorting algorithms. Factor out previously used sorting algorithms.
* Source/GSArray.m * Source/GSArray.m
* Source/NSArray.m: * Source/NSArray.m:
Modify to use the new sorting interface for sorting using Modify to use the new sorting interface for sorting using
@ -1754,7 +1761,7 @@
* Tests/base/NSArray/random.plist * Tests/base/NSArray/random.plist
* Tests/base/NSArray/sorted.plist: * Tests/base/NSArray/sorted.plist:
Add sorting example data that is large enough to test more Add sorting example data that is large enough to test more
sophisticated sorting algorithms. sophisticated sorting algorithms.
Completely overhaul how we do sorting in -base. GSSorting.h now Completely overhaul how we do sorting in -base. GSSorting.h now
defines an interface that can be used for all sorting tasks in defines an interface that can be used for all sorting tasks in
@ -1945,7 +1952,7 @@
* Source/NSObject.m: Mark NSZombie as a root class. * Source/NSObject.m: Mark NSZombie as a root class.
Changes to support clang's __attribute__((objc_root_class)). Changes to support clang's __attribute__((objc_root_class)).
2012-08-10 Richard Frith-Macdonald <rfm@gnu.org> 2012-08-10 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSScanner.m: Fix error in comment * Source/NSScanner.m: Fix error in comment
@ -1968,10 +1975,10 @@
* Source/NSFileManager.m: ([-createDirectoryAtPath:attributes:]) * Source/NSFileManager.m: ([-createDirectoryAtPath:attributes:])
OSX compatibility change to no longer create intermediate directories OSX compatibility change to no longer create intermediate directories
(fixing bug #35672). (fixing bug #35672).
NB. Code depending on the original incorrect behavior should be NB. Code depending on the original incorrect behavior should be
updated to use the new method: updated to use the new method:
-createDirectoryAtPath:withIntermediateDirectories:attributes:error: -createDirectoryAtPath:withIntermediateDirectories:attributes:error:
2012-08-10 Richard Frith-Macdonald <rfm@gnu.org> 2012-08-10 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSSpellServer.m: * Source/NSSpellServer.m:
@ -1982,8 +1989,8 @@
* Source/NSDistributedLock.m: * Source/NSDistributedLock.m:
* Source/NSMessagePort.m: * Source/NSMessagePort.m:
* Source/NSHTTPCookieStorage.m: * Source/NSHTTPCookieStorage.m:
Use new method for creating intermediate directories rater than Use new method for creating intermediate directories rater than
depending on incorrect behavior of the old method. depending on incorrect behavior of the old method.
2012-08-09 Richard Frith-Macdonald <rfm@gnu.org> 2012-08-09 Richard Frith-Macdonald <rfm@gnu.org>
@ -2122,7 +2129,7 @@
Re-load a cached handle if the content has been invalidated. Re-load a cached handle if the content has been invalidated.
Set the status of a file handle to not-loaded if the fiel is modified. Set the status of a file handle to not-loaded if the fiel is modified.
Should fix bug #36726 Should fix bug #36726
2012-07-05 Richard Frith-Macdonald <rfm@gnu.org> 2012-07-05 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSBundle.m: Don't assume that code loading won't be called * Source/NSBundle.m: Don't assume that code loading won't be called
@ -2130,7 +2137,7 @@
2012-07-05 Quentin Mathe <quentin.mathe@gmail.com> 2012-07-05 Quentin Mathe <quentin.mathe@gmail.com>
* Source/NSPathUtilities.m: Fixed constant string comparison error * Source/NSPathUtilities.m: Fixed constant string comparison error
reported by Clang SVN trunk r158230 or more recent. reported by Clang SVN trunk r158230 or more recent.
See http://llvm.org/viewvc/llvm-project?view=rev&revision=158230 See http://llvm.org/viewvc/llvm-project?view=rev&revision=158230
This is a workaround for a Clang compiler bug ... This is a workaround for a Clang compiler bug ...
@ -2352,7 +2359,7 @@
Detect the presence of libdispatch and, if available, use it for Detect the presence of libdispatch and, if available, use it for
collection enumeration methods that take blocks as arguments. This collection enumeration methods that take blocks as arguments. This
allows us to implement the NSEnumerationConcurrent option of those allows us to implement the NSEnumerationConcurrent option of those
methods with minimal effort. methods with minimal effort.
2012-03-27 Niels Grewe <niels.grewe@halbordnung.de> 2012-03-27 Niels Grewe <niels.grewe@halbordnung.de>
@ -2934,7 +2941,7 @@
2012-02-03 Adam Fedor <fedor@gnu.org> 2012-02-03 Adam Fedor <fedor@gnu.org>
* Bump version * Bump version
2012-02-03 Adam Fedor <fedor@gnu.org> 2012-02-03 Adam Fedor <fedor@gnu.org>
@ -3672,7 +3679,7 @@
* Headers/Foundation/NSXMLNode.h: * Headers/Foundation/NSXMLNode.h:
* Source/NSXMLNode.m: * Source/NSXMLNode.m:
Fixed NSXMLNode compilation when using the "pure" non-fragile ABI Fixed NSXMLNode compilation when using the "pure" non-fragile ABI
(--disable-mixedabi was passed to Base configure). (--disable-mixedabi was passed to Base configure).
2011-10-17 Fred Kiefer <FredKiefer@gmx.de> 2011-10-17 Fred Kiefer <FredKiefer@gmx.de>
@ -3815,7 +3822,7 @@
* Source/Additions/GSMime.m (GSMimeParser -scanToken:): Return an empty * Source/Additions/GSMime.m (GSMimeParser -scanToken:): Return an empty
string instead of nil when parsing an empty quoted string. string instead of nil when parsing an empty quoted string.
2011-10-08 Richard Frith-Macdonald <rfm@gnu.org> 2011-10-08 Richard Frith-Macdonald <rfm@gnu.org>
* Source/GSFileHandle.m: * Source/GSFileHandle.m:
@ -3902,7 +3909,7 @@
* Source/NSBundle.m: ([objectForInfoDictionaryKey:]) * Source/NSBundle.m: ([objectForInfoDictionaryKey:])
Add missing one-line implementation. Add missing one-line implementation.
2011-09-29 Richard Frith-Macdonald <rfm@gnu.org> 2011-09-29 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSNumberFormatter.m: Check for _C_BOOL definition. * Source/NSNumberFormatter.m: Check for _C_BOOL definition.
@ -18619,4 +18626,3 @@ Copyright @copyright{} 2005 Free Software Foundation
Copying and distribution of this file, with or without modification, Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright are permitted in any medium without royalty provided the copyright
notice and this notice are preserved. notice and this notice are preserved.

6
Source/NSDateFormatter.m
View file

@ -257,7 +257,7 @@ static NSDateFormatterBehavior _defaultBehavior = 0;
if (self == nil) if (self == nil)
return nil; return nil;
_dateFormat = [format copy]; [self setDateFormat: format];
_allowsNaturalLanguage = flag; _allowsNaturalLanguage = flag;
internal->_behavior = NSDateFormatterBehavior10_0; internal->_behavior = NSDateFormatterBehavior10_0;
return self; return self;
@ -422,9 +422,7 @@ static NSDateFormatterBehavior _defaultBehavior = 0;
NSZoneFree ([self zone], pattern); NSZoneFree ([self zone], pattern);
#endif #endif
if (_dateFormat) ASSIGNCOPY(_dateFormat, string);
RELEASE(_dateFormat);
_dateFormat = RETAIN(string);
} }
- (NSDateFormatterStyle) dateStyle - (NSDateFormatterStyle) dateStyle