Merge branch 'fix-nsurlcomponents' of github.com:gnustep/libs-base into fix-nsurlcomponents

Source/NSURL.m

@@ -2648,9 +2648,15 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
   return query;
 }
 
-- (void) setQuery: (NSString *)query
+- (void) _setQuery: (NSString *)query fromPercentEncodedString: (BOOL)encoded
 {
-  if (query != nil)
+  /* Parse according to https://developer.apple.com/documentation/foundation/nsurlcomponents/1407752-queryitems?language=objc
+   */
+  if (nil == query)
+    {
+      [self setQueryItems: nil];
+    }
+  else
     {
       NSMutableArray	*result = [NSMutableArray arrayWithCapacity: 5];
       NSArray 		*items = [query componentsSeparatedByString: @"&"];
@@ -2659,24 +2665,51 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
 
       while ((item = [en nextObject]) != nil)
         {
-          NSArray *query = [item componentsSeparatedByString: @"="];
+          NSURLQueryItem	*qitem;
-          NSString *name = [query objectAtIndex: 0];
+	  NSString		*name;
-          NSString *value = [query objectAtIndex: 1];
+	  NSString		*value;
-          NSURLQueryItem *qitem = [NSURLQueryItem queryItemWithName: name
+
-                                                              value: value];
+	  if ([item length] == 0)
+	    {
+	      name = @"";
+	      value = nil;
+	    }
+	  else
+	    {
+	      NSRange	r = [item rangeOfString: @"="];
+
+	      if (0 == r.length)
+		{
+		  /* No '=' found in query item.  */
+		  name = item;
+		  value = nil;
+		}
+	      else
+		{
+		  name = [item substringToIndex: r.location];
+		  value = [item substringFromIndex: NSMaxRange(r)];
+		}
+	    }
+	  if (encoded)
+	    {
+	      name = [name stringByRemovingPercentEncoding];
+	      value = [value stringByRemovingPercentEncoding];
+	    }
+          qitem = [NSURLQueryItem queryItemWithName: name value: value];
           [result addObject: qitem];
         }
       [self setQueryItems: result];
     }
-  else
-    {
-      [self setQueryItems: nil];
 }
+
+- (void) setQuery: (NSString *)query
+{
+  [self _setQuery: query fromPercentEncodedString: NO];
 }
 
 - (NSArray *) queryItems
 {
-  return internal->_queryItems;
+  return AUTORELEASE(RETAIN(internal->_queryItems));
 }
 
 - (void) setQueryItems: (NSArray *)queryItems
@@ -2754,57 +2787,98 @@ GS_PRIVATE_INTERNAL(NSURLComponents)
 
 - (NSString *) percentEncodedQuery
 {
-  NSString *query = @"";
+  NSString	*result = nil;
-  NSEnumerator *en = [[self percentEncodedQueryItems] objectEnumerator];
-  NSURLQueryItem *item = nil;
 
+  if (internal->_queryItems != nil)
+    {
+      NSMutableString	*query = nil;
+      NSURLQueryItem	*item = nil;
+      NSEnumerator	*en;
+
+      en = [[self percentEncodedQueryItems] objectEnumerator];
       while ((item = (NSURLQueryItem *)[en nextObject]) != nil)
 	{
 	  NSString	*name = [item name];
 	  NSString	*value = [item value];
-      NSString *itemString = [NSString stringWithFormat: @"%@=%@",name,value];
+
-      if ([query length] > 0)
+	  if (nil == query)
 	    {
-          query = [query stringByAppendingString: @"&"];
+	      query = [[NSMutableString alloc] initWithCapacity: 1000];
 	    }
-      query = [query stringByAppendingString: itemString];
+	  else
+	    {
+	      [query appendString: @"&"];
 	    }
-  return query;
+	  [query appendString: name];
+	  if (value != nil)
+	    {
+	      [query appendString: @"="];
+	      [query appendString: value];
+	    }
+	}
+      result = AUTORELEASE([query copy]);
+      RELEASE(query);
+    }
+  return result;
 }
 
 - (void) setPercentEncodedQuery: (NSString *)query
 {
-  [self setQuery: [query stringByRemovingPercentEncoding]];
+  [self _setQuery: query fromPercentEncodedString: YES];
 }
 
 - (NSArray *) percentEncodedQueryItems
 {
-  NSMutableArray *items = [NSMutableArray arrayWithCapacity: [internal->_queryItems count]];
+  NSArray	*result = nil;
+
+  if (internal->_queryItems != nil)
+    {
+      NSMutableArray	*items;
       NSEnumerator 	*en = [internal->_queryItems objectEnumerator];
       NSURLQueryItem	*i = nil;
 
+      items = [[NSMutableArray alloc]
+	initWithCapacity: [internal->_queryItems count]];
       while ((i = [en nextObject]) != nil)
 	{
-      NSURLQueryItem *ni = [NSURLQueryItem queryItemWithName: [[i name] _stringByAddingPercentEscapesForQuery]
+	  NSURLQueryItem	*ni;
-                                                       value: [[i value] _stringByAddingPercentEscapesForQuery]];
+	  NSString		*name = [i name];
+	  NSString		*value = [i value];
+
+	  name = [name _stringByAddingPercentEscapesForQuery];
+	  value = [value _stringByAddingPercentEscapesForQuery];
+	  ni = [NSURLQueryItem queryItemWithName: name
+					   value: name];
 	  [items addObject: ni];
 	}
-
+      result = AUTORELEASE([items copy]);
-  return items;
+      RELEASE(items);
+    }
+  return result;
 }
 
 - (void) setPercentEncodedQueryItems: (NSArray *)queryItems
 {
-  NSMutableArray *items = [NSMutableArray arrayWithCapacity: [queryItems count]];
+  NSMutableArray	*items = nil;
+
+  if (queryItems != nil)
+    {
       NSEnumerator	*en = [queryItems objectEnumerator];
       NSURLQueryItem 	*i = nil;
 
+      items = [NSMutableArray arrayWithCapacity: [queryItems count]];
       while ((i = [en nextObject]) != nil)
 	{
-      NSURLQueryItem *ni = [NSURLQueryItem queryItemWithName: [[i name] stringByRemovingPercentEncoding]
+	  NSString		*name;
-                                                       value: [[i value] stringByRemovingPercentEncoding]];
+	  NSString		*value;
+	  NSURLQueryItem	*ni;
+
+	  name = [[i name] stringByRemovingPercentEncoding];
+	  value = [[i value] stringByRemovingPercentEncoding];
+	  ni = [NSURLQueryItem queryItemWithName: name value: value];
 	  [items addObject: ni];
 	}
+    }
 
   [self setQueryItems: items];
 }