Fixups for macos-x compatibility

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@23271 72102866-910b-0410-8b05-ffd578937521

ChangeLog

@@ -4,7 +4,7 @@
 	multibyte encodings) strings could be truncated at the wrong
 	precision.
 	* Source/NSIndexPath.m: ([indexAtPosition:]) return NSNotFound if
-	given a bad position.
+	given a bad position. ([compare:]) fix to match MacOS-X
 	* Source/NSObject.m: implement CRASH_ON_ZOMBIE
 	* Documentation/Base.gsdoc: document it.
 

Headers/Foundation/NSIndexPath.h

@@ -69,7 +69,8 @@
 - (void) getIndexes: (unsigned*)aBuffer;
 
 /**
- * Return the index at the specified position or raise an exception.
+ * Return the index at the specified position or NSNotFound if there
+ * is no index at the specified position.
  */
 - (unsigned) indexAtPosition: (unsigned)position;
 

Source/NSIndexPath.m

@@ -78,35 +78,38 @@ static	NSIndexPath	*dummy = nil;
 
 - (NSComparisonResult) compare: (NSIndexPath*)other
 {
-  if (other == self)
+  if (other != self)
-    {
-      return NSOrderedSame;
-    }
-  else
     {
+      unsigned	olength = other->_length;
+      unsigned	*oindexes = other->_indexes;
+      unsigned	end = (_length > olength) ? _length : olength;
       unsigned	pos;
 
-      for (pos = 0; pos < _length; pos++)
+      for (pos = 0; pos < end; pos++)
 	{
-	  if (pos >= other->_length || other->_indexes[pos] < _indexes[pos])
+	  if (pos >= _length)
-	    {
-	      return NSOrderedAscending;
-	    }
-	  if (other->_indexes[pos] > _indexes[pos])
 	    {
 	      return NSOrderedDescending;
 	    }
+	  else if (pos >= olength)
+	    {
+	      return NSOrderedAscending;
+	    }
+	  if (oindexes[pos] < _indexes[pos])
+	    {
+	      return NSOrderedDescending;
+	    }
+	  if (oindexes[pos] > _indexes[pos])
+	    {
+	      return NSOrderedAscending;
+	    }
 	}
-      if (_length == other->_length)
+      /*
-	{
+       * Should never get here.
-	  /*
+       */
-	   * Should never get here.
+      NSLog(@"Argh ... two identical index paths exist!");
-	   */
-	  NSLog(@"Argh ... two identical index paths exist!");
-          return NSOrderedSame;
-	}
-      return NSOrderedDescending;
     }
+  return NSOrderedSame;
 }
 
 - (id) copyWithZone: (NSZone*)aZone