gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-04-23 00:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Source/NSDecimalNumber.m (-initWithBytes:objCType:): Avoid

Browse source 
memory leak and memory corruption by retaining notANumber before
returning it.


git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@27473 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Fred Kiefer 2008-12-31 00:42:10 +00:00
parent 2a642f30c1
commit ba9a6dff92
2 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
2008-12-31 Fred Kiefer <FredKiefer@gmx.de>
* Source/NSDecimalNumber.m (-initWithBytes:objCType:): Avoid
memory leak and memory corruption by retaining notANumber before
returning it.
2008-12-29 Richard Frith-Macdonald <rfm@gnu.org>
* Makefile.postamble (before-all): Remove test for mingw on situation

24
Source/NSDecimalNumber.m
View file

@ -354,8 +354,16 @@ static NSDecimalNumber *one;
{
NSString *s;
float v = *(float *)value;
if (GSIsNAN(v)) return notANumber;
if (GSIsInf(v)) return (v < 0.0) ? minNumber : maxNumber;
if (GSIsNAN(v))
{
DESTROY(self);
return RETAIN(notANumber);
}
if (GSIsInf(v))
{
DESTROY(self);
return (v < 0.0) ? RETAIN(minNumber) : RETAIN(maxNumber);
}
s = [[NSString alloc] initWithFormat: @"%g"
locale: GSPrivateDefaultLocale(), (double)v];
self = [self initWithString: s];
@ -368,8 +376,16 @@ static NSDecimalNumber *one;
{
NSString *s;
double v = *(double *)value;
if (GSIsNAN(v)) return notANumber;
if (GSIsInf(v)) return (v < 0.0) ? minNumber : maxNumber;
if (GSIsNAN(v))
{
DESTROY(self);
return RETAIN(notANumber);
}
if (GSIsInf(v))
{
DESTROY(self);
return (v < 0.0) ? RETAIN(minNumber) : RETAIN(maxNumber);
}
s = [[NSString alloc] initWithFormat: @"%g"
locale: GSPrivateDefaultLocale(), v];
self = [self initWithString: s];