Skip all NSURL* test cases using GSInetServerStream on Windows (#268)

* Mark all test cases using GSSocketStream as hopeful on win32

* Update ChangeLog

* Remove allow-test-failures flag

Tests/base/NSURLConnection/basic.m

@@ -32,6 +32,11 @@ int main()
     "NSURLConnection +connectionWithRequest: delegate: with nil as delegate returns a instance");
 
   response = nil;
+ 
+#if defined(_WIN32)
+testHopeful = YES;
+#endif
+
   data = [NSURLConnection sendSynchronousRequest: mutable
                                returningResponse: &response
                                            error: &error];
@@ -40,6 +45,10 @@ int main()
   PASS(response != nil && [(NSHTTPURLResponse*)response statusCode] > 0,
     "NSURLConnection synchronous load returns a response");
 
+#if defined(_WIN32)
+testHopeful = NO;
+#endif
+
   path = [[NSFileManager defaultManager] currentDirectoryPath];
   path = [path stringByAppendingPathComponent: @"basic.m"];
   [mutable setURL: [NSURL fileURLWithPath: path]];

Tests/base/NSURLConnection/test01.m

@@ -56,6 +56,18 @@ int main(int argc, char **argv, char **env)
   NSString *urlString;
   NSURLRequest *req;
   Delegate *del;
+  
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
 
   duration = 0.0;
   timing = 0.1;
@@ -93,5 +105,9 @@ int main(int argc, char **argv, char **env)
 
   [arp release]; arp = nil;
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
+
   return 0;
 }

Tests/base/NSURLConnection/test02.m

@@ -29,6 +29,18 @@ int main(int argc, char **argv, char **env)
       TestWebServer *server;
       NSURLConnectionTest *testCase;
       BOOL debug = NO;
+  
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
 
       testClass = [bundle principalClass]; // NSURLConnectionTest
 
@@ -130,8 +142,11 @@ int main(int argc, char **argv, char **env)
 		  format: @"can't load bundle TestConnection"];
     }
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
 
   DESTROY(arp);
-
+  
   return 0;
 }

Tests/base/NSURLConnection/test03.m

@@ -15,6 +15,18 @@ int main(int argc, char **argv, char **env)
   NSBundle *bundle;
   BOOL loaded;
   NSString *helperPath;
+  
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
 
   // load the test suite's classes
   fm = [NSFileManager defaultManager];
@@ -142,5 +154,9 @@ int main(int argc, char **argv, char **env)
 
   DESTROY(arp);
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
+  
   return 0;
 }

Tests/base/NSURLConnection/test04.m

@@ -14,6 +14,18 @@ int main(int argc, char **argv, char **env)
   BOOL loaded;
   NSString *helperPath;
 
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
+
   // load the test suite's classes
   fm = [NSFileManager defaultManager];
   helperPath = [[fm currentDirectoryPath]
@@ -163,6 +175,9 @@ int main(int argc, char **argv, char **env)
 		  format: @"can't load bundle TestConnection"];
     }
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
 
   DESTROY(arp);
 

Tests/base/NSURLConnection/test05.m

@@ -14,6 +14,18 @@ int main(int argc, char **argv, char **env)
   NSBundle *bundle;
   BOOL loaded;
   NSString *helperPath;
+  
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
 
   // load the test suite's classes
   fm = [NSFileManager defaultManager];
@@ -180,6 +192,9 @@ int main(int argc, char **argv, char **env)
 		  format: @"can't load bundle TestConnection"];
     }
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
 
   DESTROY(arp);
 

Tests/base/NSURLConnection/test06.m

@@ -13,6 +13,18 @@ int main(int argc, char **argv, char **env)
   NSBundle *bundle;
   BOOL loaded;
   NSString *helperPath;
+  
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
 
   // load the test suite's classes
   fm = [NSFileManager defaultManager];
@@ -65,6 +77,9 @@ int main(int argc, char **argv, char **env)
 		  format: @"can't load bundle TestConnection"];
     }
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
 
   DESTROY(arp);
 

Tests/base/NSURLConnection/test07.m

@@ -13,6 +13,18 @@ int main(int argc, char **argv, char **env)
   NSBundle 		*bundle;
   BOOL 			loaded;
   NSString 		*helperPath;
+  
+  /* The following test cases depend on the GSInetServerStream
+   * class which is completely broken on Windows.
+   *
+   * See: https://github.com/gnustep/libs-base/issues/266
+   *
+   * We will mark the test cases as hopeful on Windows.
+   */
+#if defined(_WIN32)
+  NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
+  testHopeful = YES;
+#endif
 
   // load the test suite's classes
   fm = [NSFileManager defaultManager];
@@ -97,6 +109,9 @@ int main(int argc, char **argv, char **env)
 		  format: @"can't load bundle TestConnection"];
     }
 
+#if defined(_WIN32)
+  testHopeful = NO;
+#endif
 
   DESTROY(arp);