gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-05-31 08:41:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Update -[NSMutableArray removeLastObject] (#433)

Browse source 
* Update `-[NSMutableArray removeLastObject]`

Updates the following implementation to avoid raising an exception if the array is already empty (or notifying observers if applicable):
 * `-[NSMutableArray removeLastObject]`
 * `-[GSMutableArray removeLastObject]`
 * `-[NSKeyValueMutableArray removeLastObject]`
 * `-[NSKeyValueIvarMutableArray removeLastObject]`

This brings the behavior of `-[NSMutableArray removeLastObject]` inline with the Apple implementation, improving compatibility for code bases which use both GNUStep and Apple objc/Foundation implementations.

* Add `-[NSMutableArray removeLastObject]` test case

Adds a test case to ensure `-[NSMutableArray removeLastObject]` does not raise an exception when called on an empty array.
This commit is contained in:
Earl Robsham 2024-08-10 17:44:02 -04:00 • committed by GitHub
parent bf7ccc407d
commit a5ed5dbe11
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 22 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Source/NSKeyValueMutableArray.m
View file

@ -158,7 +158,12 @@
- (void) removeLastObject
{
[self removeObjectAtIndex: ([self count] - 1)];
NSUInteger count = [self count];
if (0 == count)
{
return;
}
[self removeObjectAtIndex: (count - 1)];
}
@end
@ -521,10 +526,15 @@
- (void) removeLastObject
{
NSIndexSet *indexes = nil;
NSUInteger count = [array count];
if (0 == count)
{
return;
}
if (notifiesObservers)
{
indexes = [NSIndexSet indexSetWithIndex: [array count] - 1];
indexes = [NSIndexSet indexSetWithIndex: count - 1];
[object willChange: NSKeyValueChangeRemoval
valuesAtIndexes: indexes
forKey: key];