gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-06-01 09:02:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix for segfault by Saso Kiselkov

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@37384 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
rfm 2013-11-19 22:36:08 +00:00
parent 6781e92ac5
commit 91a8f013d9
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2013-11-19 Saso Kiselkov <skiselkov>
Releasing a GSTLSHandle (created from +[NSFileHandle sslClass]) after
the TLS handshake will result in a segfault. Fix it.
2013-11-18 Wolfgang Lux <wolfgang.lux@gmail.com> 2013-11-18 Wolfgang Lux <wolfgang.lux@gmail.com>
* Headers/GNUstepBase/NSCalendarDate+GNUstepBase.m: * Headers/GNUstepBase/NSCalendarDate+GNUstepBase.m:

10
Source/NSFileHandle.m
View file

@ -959,8 +959,14 @@ GSTLSHandlePush(gnutls_transport_ptr_t handle, const void *buffer, size_t len)
- (void) dealloc - (void) dealloc
{ {
DESTROY(opts); // TLS may need to read data during teardown, and we need to wait for it.
DESTROY(session); [self setNonBlocking: NO];
// Don't DESTROY ivars below. First release them, then set nil, because
// `session' may need this back-reference during TLS teardown.
TEST_RELEASE(opts);
TEST_RELEASE(session);
opts = nil;
session = nil;
[super dealloc]; [super dealloc];
} }