gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-05-30 16:30:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Minor comment tidyup

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@19029 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
Richard Frith-Macdonald 2004-04-05 08:40:06 +00:00
parent 377d91cca6
commit 5ddbd93caf
1 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Headers/Additions/GNUstepBase/GSIMap.h
View file

@ -201,10 +201,11 @@
* *
* _GSIMapTable -----> C-array of buckets * _GSIMapTable -----> C-array of buckets
* *
* Where each bucket contains a count (nodeCount), describing the number of nodes in * Where each bucket contains a count (nodeCount), describing the number
* in the bucket and a pointer (firstNode) to a single linked list of nodes. * of nodes in the bucket and a pointer (firstNode) to a single linked
* list of nodes.
* *
* The second view is slightly more complicated * The second view is slightly more complicated.
* The individual nodes are allocated and deallocated in chunks. * The individual nodes are allocated and deallocated in chunks.
* In order to keep track of this we have: * In order to keep track of this we have:
* *
@ -237,10 +238,10 @@
* / | +---------------+ | * / | +---------------+ |
* ---------- v v * ---------- v v
* / +----------+ +---------------------------+ * / +----------+ +---------------------------+
* | | * ------+----->| Node1 | Node2 | Node3 ... | A chunk of nodes * | | * ------+----->| Node1 | Node2 | Node3 ... | a chunk
* chunkCount | * ------+--\ +---------------------------+ * chunkCount | * ------+--\ +---------------------------+
* is size of = | . | \ +-------------------------------+ * is size of = | . | \ +-------------------------------+
* | . | ->| Node n | Node n + 1 | ... | Another chunk of nodes * | . | ->| Node n | Node n + 1 | ... | another
* +----------+ +-------------------------------+ * +----------+ +-------------------------------+
* array pointing * array pointing
* to the chunks * to the chunks
@ -250,12 +251,14 @@
* ------------------------------------- * -------------------------------------
* Chunks are allocated when needed, that is a new chunk is allocated * Chunks are allocated when needed, that is a new chunk is allocated
* whenever the freeNodes list is empty and a new node is required. * whenever the freeNodes list is empty and a new node is required.
* In gnustep-base-1.9.0 the size of the new chunk is calculated as roughly 3/4 of the number * In gnustep-base-1.9.0 the size of the new chunk is calculated as
* of nodes in use. The problem with this approach is that it can lead to unnecessary * roughly 3/4 of the number of nodes in use.
* address space fragmentation. So in this version the algorithme * The problem with this approach is that it can lead to unnecessary
* will use the 3/4 rule until the nodeCount reaches the "increment" member variable. * address space fragmentation. So in this version the algorithm we
* If nodeCount is bigger than the "increment" it will allocate chunks of size * will use the 3/4 rule until the nodeCount reaches the "increment"
* "increment". * member variable.
* If nodeCount is bigger than the "increment" it will allocate chunks
* of size "increment".
*/ */
typedef struct _GSIMapTable GSIMapTable_t; typedef struct _GSIMapTable GSIMapTable_t;
@ -592,9 +595,9 @@ GSIMapResize(GSIMapTable map, size_t new_capacity)
size += tmp; size += tmp;
} }
/* /*
* Avoid even numbers - since hash functions frequently generate uneven distributions * Avoid even numbers - since hash functions frequently generate uneven
* around powers of two - we don't want lots of keys falling into a single * distributions around powers of two -
* bucket. * we don't want lots of keys falling into a single bucket.
*/ */
if (size % 2 == 0) if (size % 2 == 0)
{ {