Make -base compile almost without warnings again. Fixes:

- Using the correct format specifier
- Remove substringFromRange: (GNUstep extension) from NSString.h and use the non-deprecated version in -base.
- Delete definitions of methods that are the same in both a class and a category on that class (NSArray and NSObject).

Two files still have warnings:

- The GNUTLS stuff is using a load of deprecated APIs.
- xmlparse.m replaces a method using a category.  This method seems to always return nil.  Not sure what it's meant to do, or why it isn't a delegate of some kind.



git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@33756 72102866-910b-0410-8b05-ffd578937521

Source/NSNumberFormatter.m

@@ -209,6 +209,8 @@ ICUToNSRoundingMode (UNumberFormatRoundingMode mode)
       case UNUM_ROUND_HALFUP:
         result = NSNumberFormatterRoundHalfUp;
         break;
+      default:
+        result = NSNumberFormatterRoundHalfUp;
     }
   
   return result;
@@ -1276,7 +1278,7 @@ static NSUInteger _defaultBehavior = NSNumberFormatterBehavior10_4;
         {
           while (([placeHolders characterIsMember:
             [useFormat characterAtIndex: NSMaxRange(intPartRange)]]
-            || [[useFormat substringFromRange:
+            || [[useFormat substringWithRange:
               NSMakeRange(NSMaxRange(intPartRange), 1)] isEqual:
           defaultThousandsSeparator])
             && NSMaxRange(intPartRange) < [useFormat length] - 1)