gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-05-30 08:21:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

tweaks for clang static analyser warningS

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32048 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
rfm 2011-02-11 09:02:33 +00:00
parent d6502819c8
commit 53e8554a8c
6 changed files with 34 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Source/NSUserDefaults.m
View file

@ -1908,7 +1908,7 @@ NSLog(@"Creating empty user defaults database");
[_lock lock];
NS_DURING
{
if (_dictionaryRep == nil)
if (nil == _dictionaryRep)
{
NSEnumerator *enumerator;
NSMutableDictionary *dictRep;
@ -1925,8 +1925,8 @@ NSLog(@"Creating empty user defaults database");
enumerator = [_searchList reverseObjectEnumerator];
nImp = [enumerator methodForSelector: nextObjectSel];
dictRep = [NSMutableDictionaryClass allocWithZone: NSDefaultMallocZone()];
dictRep = [dictRep initWithCapacity: 512];
dictRep = [NSMutableDictionaryClass alloc];
dictRep = [[dictRep initWithCapacity: 512] autorelease];
addImp = [dictRep methodForSelector: addSel];
while ((obj = (*nImp)(enumerator, nextObjectSel)) != nil)
@ -1939,7 +1939,10 @@ NSLog(@"Creating empty user defaults database");
}
_dictionaryRep = [dictRep makeImmutableCopyOnFail: NO];
}
rep = [[_dictionaryRep retain] autorelease];
else
{
rep = [[_dictionaryRep retain] autorelease];
}
[_lock unlock];
}
NS_HANDLER