gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-05-30 16:30:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup ... avoid accessing the 'isa' variable directly.

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@32247 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
rfm 2011-02-20 16:21:43 +00:00
parent 4531875573
commit 313cf13c67
19 changed files with 150 additions and 123 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Source/NSKeyValueObserving.m
View file

@ -47,7 +47,7 @@
/*
* IMPLEMENTATION NOTES
*
* Originally, I wanted to do KVO via a proxy, with isa swizzling
* Originally, I wanted to do KVO via a proxy, with class pointer swizzling
* to turn the original instance into an instance of the proxy class.
* However, I couldn't figure a way to get decent performance out of
* this model, as every message to the instance would have to be
@ -57,7 +57,7 @@
* So, instead I arrived at the mechanism of creating a subclass of
* each class being observed, with a few subclass methods overriding
* those of the original, but most remaining the same.
* The same isa swizzling technique was used to convert between the
* The same class pointer swizzling technique was used to convert between the
* original class and the superclass.
* This subclass basically overrides several standard methods with
* those from a template class, and then overrides any setter methods
@ -211,7 +211,7 @@ static inline void setup()
{
// Turn off KVO for self ... then call the real dealloc implementation.
[self setObservationInfo: nil];
isa = [self class];
object_setClass(self, [self class]);
[self dealloc];
GSNOSUPERDEALLOC;
}
@ -1471,7 +1471,7 @@ replacementForClass(Class c)
{
info = [[GSKVOInfo alloc] initWithInstance: self];
[self setObservationInfo: info];
isa = [r replacement];
object_setClass(self, [r replacement]);
}
/*
@ -1521,7 +1521,7 @@ replacementForClass(Class c)
* The instance is no longer being observed ... so we can
* turn off key-value-observing for it.
*/
isa = [self class];
object_setClass(self, [self class]);
IF_NO_GC(AUTORELEASE(info);)
[self setObservationInfo: nil];
}