gnustep/libs-base
0
0
Fork 0
mirror of https://github.com/gnustep/libs-base.git synced 2025-05-31 00:30:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

mingw32 improvements

Browse source 
git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@28755 72102866-910b-0410-8b05-ffd578937521
This commit is contained in:
rfm 2009-09-30 20:28:42 +00:00
parent 887039424c
commit 20f499656f
3 changed files with 33 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -1,6 +1,8 @@
2009-09-30 Richard Frith-Macdonald <rfm@gnu.org> 2009-09-30 Richard Frith-Macdonald <rfm@gnu.org>
* Source/NSLock.m: Fix BOOL methods to return YES or NO. * Source/NSLock.m: Fix BOOL methods to return YES or NO.
* Source/win32/GSFileHandle.m: Implement nul device handle.
* Source/NSTask.m: Try to avoid annoying colsole window with mingw32
2009-09-27 Richard Frith-Macdonald <rfm@gnu.org> 2009-09-27 Richard Frith-Macdonald <rfm@gnu.org>

14
Source/NSTask.m
View file

@ -1222,6 +1222,11 @@ quotedFromString(NSString *aString)
} }
hErr = start_info.hStdError; hErr = start_info.hStdError;
/* Tell the system not to show a window for the subtask.
*/
start_info.wShowWindow = SW_HIDE;
start_info.dwFlags |= STARTF_USESHOWWINDOW;
/* Make the handles inheritable only temporarily while launching the /* Make the handles inheritable only temporarily while launching the
* child task. This section must be lock protected so we don't have * child task. This section must be lock protected so we don't have
* another thread trying to launch at the same time and get handles * another thread trying to launch at the same time and get handles
@ -1238,11 +1243,16 @@ quotedFromString(NSString *aString)
NULL, /* thread attrs */ NULL, /* thread attrs */
1, /* inherit handles */ 1, /* inherit handles */
0 0
// |CREATE_NO_WINDOW |CREATE_NO_WINDOW
/* One would have thought the the CREATE_NO_WINDOW flag should be used, /* One would have thought the the CREATE_NO_WINDOW flag should be used,
* but apparently this breaks for old 16bit applications/tools on XP. * but apparently this breaks for old 16bit applications/tools on XP.
* So maybe we want to leave it out?
*/
// |DETACHED_PROCESS
/* We don't set the DETACHED_PROCESS flag as it actually means that the
* child task should get a new Console allocated ... and that means it
* will pop up a console window ... which looks really bad.
*/ */
|DETACHED_PROCESS
|CREATE_UNICODE_ENVIRONMENT, |CREATE_UNICODE_ENVIRONMENT,
envp, /* env block */ envp, /* env block */
(const unichar*)[[self currentDirectoryPath] fileSystemRepresentation], (const unichar*)[[self currentDirectoryPath] fileSystemRepresentation],

23
Source/win32/GSFileHandle.m
View file

@ -1085,10 +1085,25 @@ NSString * const GSSOCKSRecvAddr = @"GSSOCKSRecvAddr";
- (id) initWithNullDevice - (id) initWithNullDevice
{ {
isNullDevice = YES; int d = _open("NUL", O_RDWR|O_BINARY);
isStandardFile = YES;
descriptor = -1; if (d < 0)
return self; {
RELEASE(self);
return nil;
}
else
{
self = [self initWithFileDescriptor: d closeOnDealloc: YES];
if (self != nil)
{
connectOK = NO;
acceptOK = NO;
isNullDevice = YES;
isStandardFile = YES;
}
return self;
}
} }
- (id) initWithFileDescriptor: (int)desc closeOnDealloc: (BOOL)flag - (id) initWithFileDescriptor: (int)desc closeOnDealloc: (BOOL)flag