dhewm/dhewm3-sdk
0
0
Fork 0
mirror of https://github.com/dhewm/dhewm3-sdk.git synced 2024-11-28 23:32:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix pot. Crash in idWinding2D::ExpandForAxialBox()

Browse source 
it could happen that i is 1 but numPlanes is still 0
(=> if for i = 0:  ( p[j] - p[i] ).LengthSqr() < 0.01f )
so planes[-1] would be accessed which of course is invalid and can crash
This commit is contained in:
Daniel Gibson 2018-12-09 04:23:41 +01:00
parent 885f594a59
commit fd514f2281
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
idlib/geometry/Winding2D.cpp
View file

@ -84,7 +84,7 @@ void idWinding2D::ExpandForAxialBox( const idVec2 bounds[2] ) {
continue; continue;
} }
plane = Plane2DFromPoints( p[i], p[j], true ); plane = Plane2DFromPoints( p[i], p[j], true );
if ( i ) { if ( numPlanes > 0 ) {
if ( GetAxialBevel( planes[numPlanes-1], plane, p[i], bevel ) ) { if ( GetAxialBevel( planes[numPlanes-1], plane, p[i], bevel ) ) {
planes[numPlanes++] = bevel; planes[numPlanes++] = bevel;
} }