darkplaces/gmqcc
0
0
Fork 0
mirror of https://github.com/DarkPlacesEngine/gmqcc.git synced 2024-11-27 22:22:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Ignore most memory comparisions by validating the lengths are the same first. Becomes O(log(n)) from O(n) for correct_exists.

Browse source
This commit is contained in:
Dale Weiler 2013-01-30 23:32:15 +00:00
parent a6ecc3cbc4
commit d7a47eb5f9
1 changed files with 7 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
correct.c
View file

@ -129,10 +129,6 @@
* edit distance the smaller the error. This usually causes some un- * edit distance the smaller the error. This usually causes some un-
* expected problems. e.g reciet->recite yields recipt. For QuakeC * expected problems. e.g reciet->recite yields recipt. For QuakeC
* this could become a problem when lots of identifiers are involved. * this could become a problem when lots of identifiers are involved.
*
* Our control mechanisim could use a limit, i.e limit the number of
* sets of edits for distance X. This would also increase execution
* speed considerably.
*/ */
@ -419,15 +415,14 @@ static GMQCC_INLINE char **correct_edit(const char *ident, size_t **lens) {
return find; return find;
} }
/* static GMQCC_INLINE int correct_exist(char **array, register size_t *sizes, size_t rows, char *ident, register size_t len) {
* We could use a hashtable but the space complexity isn't worth it
* since we're only going to determine the "did you mean?" identifier
* on error.
*/
static GMQCC_INLINE int correct_exist(char **array, size_t rows, char *ident, size_t len) {
size_t itr; size_t itr;
for (itr = 0; itr < rows; itr++) { for (itr = 0; itr < rows; itr++) {
if (!memcmp(array[itr], ident, len)) /*
* We can save tons of calls to memcmp if we simply ignore comparisions
* that we know cannot contain the same length.
*/
if (sizes[itr] == len && !memcmp(array[itr], ident, len))
return 1; return 1;
} }
@ -471,7 +466,7 @@ static char **correct_known(correction_t *corr, correct_trie_t* table, char **ar
row = correct_size(array[itr]); row = correct_size(array[itr]);
for (jtr = 0; jtr < row; jtr++) { for (jtr = 0; jtr < row; jtr++) {
if (correct_find(table, end[jtr]) && !correct_exist(res, len, end[jtr], bit[jtr])) { if (correct_find(table, end[jtr]) && !correct_exist(res, bit, len, end[jtr], bit[jtr])) {
res = correct_known_resize(res, &nxt, len+1); res = correct_known_resize(res, &nxt, len+1);
res[len++] = end[jtr]; res[len++] = end[jtr];
} }