From 5f7fb2bfb3d0e971398457611bc38383400842e2 Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Fri, 30 Dec 2022 12:55:36 +0200 Subject: [PATCH] aedi: update flags environment variable with one call --- aedi/state.py | 12 +++++------- aedi/target/base.py | 12 ++---------- 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/aedi/state.py b/aedi/state.py index 73d487ba..5e9fe909 100644 --- a/aedi/state.py +++ b/aedi/state.py @@ -212,15 +212,13 @@ class BuildState: return (self.source / path).exists() def update_environment(self, name: str, value: str): - env = self.environment - env[name] = env[name] + ' ' + value if name in env else value - - def set_sdk(self, var_name: str): sdk_path = self.sdk_path() if sdk_path: - self.update_environment(var_name, f'-isysroot {sdk_path}') + value += f' -isysroot {sdk_path}' - def set_os_version(self, var_name: str): os_version = self.os_version() if os_version: - self.update_environment(var_name, f'-mmacosx-version-min={os_version}') + value += f' -mmacosx-version-min={os_version}' + + env = self.environment + env[name] = env[name] + ' ' + value if name in env else value diff --git a/aedi/target/base.py b/aedi/target/base.py index b9bd4236..a8adaf10 100644 --- a/aedi/target/base.py +++ b/aedi/target/base.py @@ -115,17 +115,9 @@ class BuildTarget(Target): env['CXX'] = str(cxx_compiler) for prefix in ('AR', 'C', 'CPP', 'CXX', 'OBJC', 'OBJCXX'): - var_name = f'{prefix}FLAGS' + state.update_environment(f'{prefix}FLAGS', f'-I{state.include_path}') - state.update_environment(var_name, f'-I{state.include_path}') - state.set_sdk(var_name) - state.set_os_version(var_name) - - ldflags = 'LDFLAGS' - - state.update_environment(ldflags, f'-L{state.lib_path}') - state.set_sdk(ldflags) - state.set_os_version(ldflags) + state.update_environment('LDFLAGS', f'-L{state.lib_path}') def install(self, state: BuildState, options: CommandLineOptions = None, tool: str = 'gmake'): if state.xcode: