Commit graph

631 commits

Author SHA1 Message Date
Christoph Oelckers
8bb4bc55eb - set_int_change_y 2022-10-14 17:17:01 +02:00
Christoph Oelckers
b6c0560430 - set_int_change_x 2022-10-14 17:17:01 +02:00
Christoph Oelckers
390dd4d9df - wrapped a few more 2022-10-14 17:17:00 +02:00
Christoph Oelckers
6334b7d3b8 - wrapped half of the remaining access to user.change
Strictly search and replace.
2022-10-14 17:17:00 +02:00
Christoph Oelckers
420636f7ee - a bit more lightening on change 2022-10-14 17:17:00 +02:00
Christoph Oelckers
10e08556c1 - put more access to user.change behind wrappers 2022-10-14 17:16:59 +02:00
Christoph Oelckers
f81aada041 - lightened the number of references to user.change by 1/3rd
The less, the better for refactoring
2022-10-14 17:16:31 +02:00
Christoph Oelckers
ab3e7df1b9 - use UpdateChangeXY in a few more places 2022-10-14 00:06:30 +02:00
Christoph Oelckers
502994fb0a - floatified SpawnExpZadjust’s interface 2022-10-14 00:06:29 +02:00
Christoph Oelckers
f656d8b1a3 - floatified SpawnExpZadjust 2022-10-14 00:06:29 +02:00
Christoph Oelckers
4a486f5a10 - deal with an extremely redundant code fragment
Consolidates almost 100 lines that still need work in a small subfunction. :)
2022-10-13 22:54:43 +02:00
Christoph Oelckers
785575604b - no need to use int_delta when all we want is the angle. 2022-10-13 22:54:43 +02:00
Christoph Oelckers
6ce01e24d2 - renamed walltype::delta and walltype::center 2022-10-13 22:54:42 +02:00
Christoph Oelckers
0fcbe57111 - pos in DoBloodWorm 2022-10-13 19:59:15 +02:00
Christoph Oelckers
06be4eeb91 - floatified most of SpriteWarpToUnderwater 2022-10-13 19:59:15 +02:00
Mitchell Richters
2e25ccaa4d - SW: Replace some set_int_ang() usage. 2022-10-13 00:59:02 +02:00
Christoph Oelckers
0edd12bc11 - set_int_ang(getangle 2022-10-13 00:59:01 +02:00
Christoph Oelckers
f45e6317ab - SpriteWarpToSurface 2022-10-13 00:59:00 +02:00
Christoph Oelckers
2f896b859b - made the code mostly signed-char safe.
This eliminates all char function parameters that are not really ASCII characters and casts all char argument to the ctype is... functions.
2022-10-12 22:12:30 +02:00
Christoph Oelckers
f269ceff64 slope functions with position vectors 2022-10-12 22:10:37 +02:00
Christoph Oelckers
0499be0c26 - getting rid of some int_pos calls. 2022-10-12 22:10:37 +02:00
Christoph Oelckers
12b238b2bf - the remaining SpawnActor calls. 2022-10-12 22:10:36 +02:00
Christoph Oelckers
80f019c429 - next batch of SpawnActor calls. 2022-10-12 22:10:35 +02:00
Christoph Oelckers
c7437da255 - more SpawnActors 2022-10-12 22:10:35 +02:00
Christoph Oelckers
da6e8e9341 - several SpawnActor and getangle calls. 2022-10-12 22:10:35 +02:00
Christoph Oelckers
f0769048ed - yet another bunch of SpawnActor calls in weapon.cpp 2022-10-12 22:10:35 +02:00
Christoph Oelckers
5e28b2cca3 - lots of SpawnActor calls in weapon.cpp 2022-10-12 22:10:34 +02:00
Christoph Oelckers
f77ecbed32 - several HitBreakWall calls 2022-10-12 22:10:34 +02:00
Christoph Oelckers
d8f379c8fa - SetActorZ vectors 2022-10-10 17:37:20 +02:00
Christoph Oelckers
e76dfa5d3c - GetActor pos replacement 2022-10-10 17:37:19 +02:00
Christoph Oelckers
ed12e333e3 - RANDOM_ANGLE + move_debris 2022-10-10 17:31:30 +02:00
Christoph Oelckers
9444bd4370 - last FAFcansee bunch 2022-10-10 17:31:29 +02:00
Christoph Oelckers
4aa5de689c - renamed old FAFcansee function for easier searching. 2022-10-10 17:31:29 +02:00
Christoph Oelckers
ff6d1fd284 - FAFcansee refactoring, part 3. 2022-10-10 17:31:29 +02:00
Christoph Oelckers
7eb2dede6a - FAFcansee refactoring, part 2. 2022-10-10 17:31:29 +02:00
Christoph Oelckers
98b06697f7 - pass position pointers to DISTANCE. 2022-10-10 17:31:28 +02:00
Christoph Oelckers
6497456471 - most of int_phiz,int_ploz 2022-10-09 22:29:54 +02:00
Christoph Oelckers
13d9505662 - PLAYER::hiz,loz refactoring, part 1 2022-10-09 22:00:43 +02:00
Christoph Oelckers
31dfd1af7a - eliminated most int_upos calls. 2022-10-09 21:57:30 +02:00
Christoph Oelckers
0d24aeb3f5 - handle all remaining trivial int_loz. 2022-10-09 14:53:11 +02:00
Christoph Oelckers
5e14361dd6 - another set of 2 Utilities prepared for floatification. 2022-10-09 14:53:11 +02:00
Christoph Oelckers
9ed66acd44 - renamed 2 integer functions to add float variants 2022-10-09 14:53:10 +02:00
Christoph Oelckers
f53a61693b - floatified user.pos.
Special care needed to be taken for two cases where it did not store a coordinate.
2022-10-09 08:21:56 +02:00
Christoph Oelckers
f43a8d4fce - user.pos wrapping. 2022-10-09 08:21:56 +02:00
Christoph Oelckers
bc853d3a00 - user.zclip floatified 2022-10-09 08:21:56 +02:00
Christoph Oelckers
4021d13e8d - completed floatification of ceiling_dist and floor_dist. 2022-10-09 08:21:56 +02:00
Christoph Oelckers
5416100ba2 - trivial assignments
(does not compile, this commit is only supposed to reduce the noise on the next one.
2022-10-09 08:21:55 +02:00
Christoph Oelckers
5f12f0deaa - missed 3. 2022-10-09 08:21:55 +02:00
Christoph Oelckers
8672a9f051 - wrapped user.floor_dist reads. 2022-10-09 08:21:55 +02:00
Christoph Oelckers
4f073dec26 - wrapped user.ceiling_dist reads. 2022-10-09 08:21:55 +02:00
Christoph Oelckers
467ab9f7ee - int_hiz/int_loz replacements. 2022-10-09 08:21:55 +02:00
Christoph Oelckers
65d1e5cac9 - wrapped user.z_tgt reads. 2022-10-09 08:21:55 +02:00
Christoph Oelckers
d117544da8 - wrapped user.hiz reads. 2022-10-09 08:21:54 +02:00
Christoph Oelckers
ac3f6d73e3 - wrapped all reads to user.loz. 2022-10-09 08:21:54 +02:00
Christoph Oelckers
766ddeb445 - one more batch of trivial replacements 2022-10-09 08:21:53 +02:00
Christoph Oelckers
6111b11359 - trivial replacements in SW. 2022-10-09 08:21:53 +02:00
Christoph Oelckers
b32c4444c4 - replaced all add_int_z calls with constants. 2022-10-08 19:28:57 +02:00
Christoph Oelckers
4a6f9f316a - one assignment 2022-10-08 19:28:57 +02:00
Christoph Oelckers
5df5520754 - one more 2022-10-08 16:11:23 +02:00
Christoph Oelckers
5db79fecd7 - more int_ppos 2022-10-06 20:50:45 +02:00
Christoph Oelckers
8e966fc575 - int_ppos replacements 2022-10-06 20:50:45 +02:00
Christoph Oelckers
da73d2bba4 - renamed player position variables. 2022-10-06 20:50:45 +02:00
Christoph Oelckers
b9dbcebe2e - floatified SECTOR_OBJECT::pmid 2022-10-06 20:50:44 +02:00
Christoph Oelckers
48cbdeb697 - replaced all possible __int_pmid with access functions. 2022-10-06 20:50:44 +02:00
Christoph Oelckers
819297a409 - SW: renamed SECTOR_OBJECT::pmid 2022-10-06 20:50:44 +02:00
Christoph Oelckers
049c6f948d - deleted unused SpawnWallHole function. 2022-10-06 20:50:43 +02:00
Christoph Oelckers
e8d18e42d1 - SW: QueueHole 2022-10-06 20:50:43 +02:00
Christoph Oelckers
661655fb67 - SW: use a DVector3 in SpawnVis 2022-10-06 20:50:43 +02:00
Christoph Oelckers
3a9f9988f4 - redid clipinsidebox* functions.
* Completely rewritten to be less obtuse.
* Consolidated the two variants.
* Renamed to be clearer about what they do.
2022-10-05 18:31:45 +02:00
Christoph Oelckers
643d3e7eba - SW’s BulletHitSprite 2022-10-05 18:19:56 +02:00
Christoph Oelckers
b3d9320d54 - Distance in SW 2022-10-05 18:18:27 +02:00
Christoph Oelckers
84f690654e - hitpos replacements in spawn calls 2022-10-05 18:17:15 +02:00
Christoph Oelckers
5505c362e2 - floatified hitpos 2022-10-05 18:11:59 +02:00
Christoph Oelckers
55ade2eda4 - use int_hitpos() access function where applicable 2022-10-05 18:10:44 +02:00
Christoph Oelckers
296b5d7edd - renamed HitInfo::hitpos 2022-10-05 18:03:41 +02:00
Christoph Oelckers
086c699df0 - use float coords for spawning some SW actors. 2022-10-05 18:01:57 +02:00
Christoph Oelckers
8f4c418a1b - pos simplifications 2022-10-05 18:00:25 +02:00
Christoph Oelckers
cdff2b12cc - renamed ActorZOfMiddle 2022-10-05 17:58:37 +02:00
Mitchell Richters
d28d6cd4cf - Utilise actor sprite's full precision in instances where angle was converted to Build and back again. 2022-10-05 00:36:30 +02:00
Mitchell Richters
ad908719ec - Remaining manual changes to replace player's ang with DAngle object. 2022-10-05 00:36:27 +02:00
Mitchell Richters
b23e77d9c7 - Replace player's ang with DAngle object.
* This commit does not build. Committed items are everything that's been done by find and replace.
* Next commit has hand-performed changes that are better separated out for clarity.
2022-10-05 00:36:27 +02:00
Christoph Oelckers
9a27dc2020 - handle all leftover __int_angles.
Most were in comments but were changed anyway.
2022-10-05 00:36:21 +02:00
Christoph Oelckers
6bdfa09dd1 - the remaining angle stuff. 2022-10-05 00:36:21 +02:00
Christoph Oelckers
2d51058de8 - add_int_ang 2022-10-05 00:35:14 +02:00
Christoph Oelckers
2533841541 - set_int_ang in SW. 2022-10-04 23:56:44 +02:00
Christoph Oelckers
6381015229 - set_int_ang in SW, part 1. 2022-10-04 23:56:44 +02:00
Christoph Oelckers
f54e4b8a9a - more int_ang() 2022-10-04 23:56:43 +02:00
Christoph Oelckers
33d5b54ce0 - use int_ang(). 2022-10-04 23:56:43 +02:00
Christoph Oelckers
735b9a8fed - renamed ang to __int_angle 2022-10-04 23:56:42 +02:00
Christoph Oelckers
b327f7f03a - some simple replacements. 2022-10-04 18:44:15 +02:00
Christoph Oelckers
c84d75b8bf - use inline access functions to read floorz/ceilingz. 2022-08-27 09:58:16 +02:00
Christoph Oelckers
0672572e63 - renamed sectortype::floorz and ceilingz as preparation for floatification 2022-08-27 09:47:48 +02:00
Christoph Oelckers
e732e2f947 - SW: replaced spr.pos globally (except two functions)
# Conflicts:
#	source/games/sw/src/_polymost.cpp
2022-08-26 19:53:09 +02:00
Christoph Oelckers
b49aed6620 - SW: more spr.pos write wraps. 2022-08-26 19:53:09 +02:00
Christoph Oelckers
6a5384f39e - SW: eighth batch of spr.pos wraps. 2022-08-26 19:53:09 +02:00
Christoph Oelckers
1101a8c9e8 - SW: seventh batch of spr.pos wraps. 2022-08-26 19:53:09 +02:00
Christoph Oelckers
2d91ea29ce - SW: fifth batch of spr.pos wraps. 2022-08-26 19:53:08 +02:00
Christoph Oelckers
53ce186e7b - SW: third batch of spr.pos wraps. 2022-08-26 19:53:08 +02:00
Mitchell Richters
00e12ea031 - Remove some uses of xs_Float.h functions in game-side code where overflow protection isn't needed.
* Went a little bit nuts and just used this everywhere back way back when.
2022-07-23 10:37:32 +10:00
Christoph Oelckers
f8aacb3825 - fixed crash in Last Warrior map 9.
Really, asserts should not be used to test for errors that can actually happen!
2022-06-06 20:56:50 +02:00
Christoph Oelckers
f44736a5b6 -use an access function for reading wall positions so that we have a non-modifiable value wherever this is possible. 2022-02-15 22:18:23 +01:00
Christoph Oelckers
89ef81da55 - renamed walltype::pos as preparation for refactoring.
no functional changes here
2022-02-15 22:18:22 +01:00
Christoph Oelckers
c5b382907d - SW: fixed velocity issue in InitEnemyFireball.
The value of the first shot was retrieved too early.
2022-01-15 10:36:55 +01:00
Christoph Oelckers
468aea78ef - SW: fixed wrong actor being checked in ContinueHitscan. 2022-01-04 12:42:46 +01:00
Christoph Oelckers
e302c45a0b Revert "- added two FAFcansee variants that take shorter parameter lists for clearer code."
This reverts commit 29da39dda0.

Something in here was wrong, so back to the start with it.
The positive effect was too small anyway.
2022-01-02 17:35:12 +01:00
Christoph Oelckers
1294f10cd7 - SW: fixed negated FAFcansee call in explosion code. 2022-01-01 17:14:49 +01:00
Christoph Oelckers
27eae52228 - fixed incorrect argument in FAFcansee call. 2022-01-01 17:11:15 +01:00
Mitchell Richters
45057ff8a0 - SW: Fix all GCC warning: suggest parentheses around assignment used as truth value [-Wparentheses] warnings.
Regex to match such conditions: `while (\([\w]+\s?=\s?.+\.Next\(\)\))`.
2022-01-01 20:49:31 +11:00
Mitchell Richters
9145895b47 - SW: Replace SECTOR_OBJECT ymid with pmid.Y calls. 2022-01-01 09:33:30 +11:00
Mitchell Richters
5e2bbb12b5 - SW: Replace SECTOR_OBJECT xmid with pmid.X calls. 2022-01-01 09:32:40 +11:00
Mitchell Richters
1c0ba71c69 - SW: Eliminated ANIMATORp typedef. 2022-01-01 09:09:41 +11:00
Christoph Oelckers
84ca96c52c eliminated STATEp 2021-12-31 16:00:14 +01:00
Christoph Oelckers
d1be430fbf - eliminated PLAYERp 2021-12-31 15:59:11 +01:00
Christoph Oelckers
392397c2b0 - replaced SECTOR_OBJECTp 2021-12-31 15:50:44 +01:00
Christoph Oelckers
8fb769649b - eliminated sectortype aliases. 2021-12-31 15:43:47 +01:00
Christoph Oelckers
98492aae54 - eliminated walltype aliases. 2021-12-31 15:41:39 +01:00
Christoph Oelckers
72962cc098 - the last batch of small scale typedefs eliminated. 2021-12-31 15:40:29 +01:00
Christoph Oelckers
87d2b3274b - cleaned out most of the less frequent typedef types in SW. 2021-12-31 15:27:18 +01:00
Christoph Oelckers
085eb8a36e - eliminated SHRAP typedefs. 2021-12-31 13:26:07 +01:00
Christoph Oelckers
271af39a59 - consolidated MISSILE_PLACEMENT definitions. 2021-12-31 13:20:56 +01:00
Christoph Oelckers
90ad4b8ef1 - eliminated typedefs for DECISION and BREAK_INFO. 2021-12-31 13:16:38 +01:00
Christoph Oelckers
552668418a - moved opos and oang to DCoreActor. 2021-12-30 18:21:02 +01:00
Christoph Oelckers
c10fb1278a - moved the backup... methods to DCoreActor. 2021-12-30 17:10:08 +01:00
Christoph Oelckers
5498699faf - use DCoreActor::sector() wherever possible. 2021-12-30 16:51:56 +01:00
Christoph Oelckers
af6ca40e3d - use DCoreActor::insector instead of spritetype::insector. 2021-12-30 16:24:51 +01:00
Mitchell Richters
ab6b9fd083 - SW: Replace USER zchange with change.Z calls. 2021-12-31 00:23:30 +11:00
Mitchell Richters
50cb85e389 - SW: Replace USER ychange with change.Y calls. 2021-12-31 00:22:48 +11:00
Mitchell Richters
ad0ea3f2f1 - SW: Replace USER xchange with change.X calls. 2021-12-31 00:22:42 +11:00
Mitchell Richters
e4d19a0bbe - SW: Replace PLAYERstruct slide_yvect with slide_vect.Y calls. 2021-12-31 00:19:33 +11:00
Mitchell Richters
8c1c5f3d55 - SW: Replace PLAYERstruct slide_xvect with slide_vect.X calls. 2021-12-31 00:19:33 +11:00
Mitchell Richters
5515830e2b - SW: Replace PLAYERstruct yvect with vect.Y calls. 2021-12-31 00:19:33 +11:00
Mitchell Richters
f2497d7d08 - SW: Replace PLAYERstruct xvect with vect.X calls. 2021-12-31 00:19:33 +11:00
Mitchell Richters
9c1e54a148 - SW: Replace USER sz with pos.Z calls. 2021-12-30 20:40:29 +11:00
Mitchell Richters
0d70d26625 - SW: Replace USER sy with pos.Y calls. 2021-12-30 20:31:09 +11:00
Mitchell Richters
fcf18c8c63 - SW: Replace USER sx with pos.X calls. 2021-12-30 20:31:09 +11:00
Mitchell Richters
9bbb54fe2e - Replace every line that just contains spaces or tabs with an empty line feed in all files except 3rd party libraries. 2021-12-30 20:30:21 +11:00
Mitchell Richters
1b077251e3 - SW: Use BIT() inline in a few places that were changed in "- SW: Replace the last few remaining TEST() macro uses and remove from mytypes.h."
Originally, `BIT()` was going to be dropped in a subsequent commit but we've elected not to.
2021-12-30 20:14:01 +11:00
Mitchell Richters
ae49a55fce - SW: Replace the last few remaining TEST() macro uses and remove from mytypes.h. 2021-12-30 09:58:45 +01:00
Mitchell Richters
1439d5f268 - SW: Replace TEST\(([\w\-\>.()\[\]]+),\s?([\w\_\|\s]+)\) with ($1 & ($2)). 2021-12-30 09:58:45 +01:00
Mitchell Richters
48b0058d38 - SW: Replace TEST\(([\w\-\>.()]+),\s?(\w+)\) with ($1 & $2). 2021-12-30 09:58:45 +01:00
Mitchell Richters
5316e23737 - SW: Replace !TEST\(([\w\-\>.()\[\]]+),\s?([\w\_\|\s]+)\) with !($1 & ($2)) 2021-12-30 09:58:45 +01:00
Mitchell Richters
8df3966d08 - SW: Replace !TEST\(([\w\-\>.()\[\]]+),\s?(\w+)\) with !($1 & $2). 2021-12-30 09:58:44 +01:00
Christoph Oelckers
c24aafd3d6 - SW: game.h cleanup
Turned almost all #defines into enums or inline functions, removed unused declarations and all leftover MONO_PRINT fragments elsewhere.
2021-12-30 09:58:13 +01:00
Christoph Oelckers
96396385e7 - more TEST() replacements.
This covers roughly half of the original use.
2021-12-30 09:58:13 +01:00
Christoph Oelckers
61564ab96a - one third of TEST(). 2021-12-30 09:58:13 +01:00
Christoph Oelckers
7727597bd7 - removed FLIP macro
was only used 3 times
2021-12-30 09:58:12 +01:00
Christoph Oelckers
08fcfb382c - the remaining RESET() calls. 2021-12-30 09:58:12 +01:00
Christoph Oelckers
e29d0f50cf - lots of RESET() flags replaced. 2021-12-30 09:58:12 +01:00
Christoph Oelckers
d15c3aeff6 - got rid of the DIV2 macro. 2021-12-30 09:58:11 +01:00
Christoph Oelckers
387d65abb4 - the remaining SET()s.
These had to be done manually.
2021-12-30 09:58:11 +01:00