/home/mrichters/Repos/Raze/source/core/rts.cpp: In function ‘bool RTS_IsInitialized()’:
/home/mrichters/Repos/Raze/source/core/rts.cpp:123:51: warning: ‘.rts’ directive output may be truncated writing 4 bytes into a region of size between 3 and 11 [-Wformat-truncation=]
123 | snprintf(rts, 16, "rts%02d.rts", i);
| ^~~~
/home/mrichters/Repos/Raze/source/core/rts.cpp:123:33: note: ‘snprintf’ output between 10 and 18 bytes into a destination of size 16
123 | snprintf(rts, 16, "rts%02d.rts", i);
| ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/mrichters/Repos/Raze/source/common/filesystem/include/fs_filesystem.h:12,
from /home/mrichters/Repos/Raze/source/common/engine/filesystem.h:2,
from /home/mrichters/Repos/Raze/source/common/utility/zstring.h:43,
from /home/mrichters/Repos/Raze/source/common/platform/posix/i_system.h:14,
from /home/mrichters/Repos/Raze/source/common/platform/posix/sdl/hardware.cpp:38:
/home/mrichters/Repos/Raze/source/common/filesystem/include/resourcefile.h: In member function ‘int FileSys::FResourceFile::GetEntryNamespace(uint32_t)’:
/home/mrichters/Repos/Raze/source/common/filesystem/include/resourcefile.h:180:43: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
180 | return (entry < NumLumps) ? Entries[entry].Namespace : ns_hidden;
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* This was causing transparent images to sit on a pure black canvas rather than the colour of the dialogue box.
* This change has been submitted upstream also.
* Returning a nullptr and having the caller return from that potentially results in no animation being drawn at all.
* Change here is akin to fix applied in 1cb15ed878.
This reverts commit fe356f3183.
* The applied fix in 1cb15ed878 covers this and probably does it in a better manner (i.e., play the last frame again vs. resetting the frame sequence).
The CON code for this sets its correct size with 'sizeto' which is an animating instruction so it is clearly visible when they shrink to their proper size.
This now sets this size in the actual spawn function so that no shrinking animation can be seen.
