zdoom/raze
0
0
Fork 0
mirror of https://github.com/ZDoom/Raze.git synced 2025-01-18 22:51:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

Duke3d: improve nextsectorneighborz() return value checks

Browse source 
Improves the messages printed to console when bailing out of sector effect processing due to nextsectorneighborz() returning -1. This also adds such a check to ST_21_FLOOR_DOOR, which was missing it entirely. (!!)

# Conflicts:
#	source/duke3d/src/sector.cpp
This commit is contained in:
Richard C. Gobeille 2020-05-25 08:33:05 -07:00 committed by Christoph Oelckers
parent 86f2a7a578
commit 94eda45df9
1 changed files with 29 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
source/duke3d/src/sector.cpp
View file

@ -733,7 +733,11 @@ void G_OperateSectors(int sectNum, int spriteNum)
if (i == -1)
{
i = nextsectorneighborz(sectNum,pSector->floorz,1,-1);
if (i == -1) return;
if (i == -1)
{
OSD_Printf("ST_16_PLATFORM_DOWN/ST_17_PLATFORM_UP: bad neighbor for sector %d!\n", sectNum);
return;
}
j = sector[i].floorz;
SetAnimation(sectNum,&pSector->floorz,j,pSector->extra);
}
@ -760,7 +764,10 @@ void G_OperateSectors(int sectNum, int spriteNum)
i = nextsectorneighborz(sectNum, pSector->floorz, 1, 1);
if (i == -1)
{
OSD_Printf("ST_18_ELEVATOR_DOWN/ST_19_ELEVATOR_UP: bad neighbor for sector %d!\n", sectNum);
return;
}
j = sector[i].floorz;
@ -794,7 +801,7 @@ void G_OperateSectors(int sectNum, int spriteNum)
if (j == -1) j = nextsectorneighborz(sectNum,pSector->ceilingz,1,1);
if (j == -1)
{
Printf("WARNING: ST29: null sector!\n");
Printf("ST_29_TEETH_DOOR: bad neighbor for sector %d!\n", sectNum);
return;
}
j = sector[j].ceilingz;
@ -805,7 +812,7 @@ void G_OperateSectors(int sectNum, int spriteNum)
if (j == -1) j = nextsectorneighborz(sectNum,pSector->ceilingz,-1,-1);
if (j == -1)
{
Printf("WARNING: ST29: null sector!\n");
Printf("ST_29_TEETH_DOOR: bad neighbor for sector %d!\n", sectNum);
return;
}
j = sector[j].floorz;
@ -854,13 +861,29 @@ REDODOOR:
if (i >= 0)
{
if (g_animateGoal[sectNum] == pSector->ceilingz)
g_animateGoal[i] = sector[nextsectorneighborz(sectNum,pSector->ceilingz,1,1)].floorz;
{
j = nextsectorneighborz(sectNum, pSector->ceilingz, 1, 1);
if (j == -1)
{
OSD_Printf("ST_21_FLOOR_DOOR: bad neighbor for sector %d!\n", sectNum);
return;
}
g_animateGoal[i] = sector[j].floorz;
}
else g_animateGoal[i] = pSector->ceilingz;
}
else
{
if (pSector->ceilingz == pSector->floorz)
j = sector[nextsectorneighborz(sectNum,pSector->ceilingz,1,1)].floorz;
{
i = nextsectorneighborz(sectNum, pSector->ceilingz, 1, 1);
if (i == -1)
{
OSD_Printf("ST_21_FLOOR_DOOR: bad neighbor for sector %d!\n", sectNum);
return;
}
j = sector[i].floorz;
}
else j = pSector->ceilingz;
pSector->lotag ^= 0x8000u;
@ -890,8 +913,7 @@ REDODOOR:
}
else
{
Printf("WARNING: ST_22_SPLITTING_DOOR: null sector: floor neighbor=%d, ceiling neighbor=%d!\n",
floorNeighbor, ceilingNeighbor);
Printf("ST_22_SPLITTING_DOOR: bad neighbor for sector %d; floor neighbor=%d, ceiling neighbor=%d!\n", sectNum, floorNeighbor, ceilingNeighbor);
pSector->lotag ^= 0x8000u;
}
}