- changed palette lookup to consider the remapping of color 0 to 255.

This is to ensure that black maps to the proper index, even if there's duplicates.

source/common/engine/palettecontainer.cpp

@@ -51,7 +51,7 @@ extern uint8_t IcePalette[16][3];
 //
 //----------------------------------------------------------------------------
 
-void PaletteContainer::Init(int numslots)	// This cannot be a constructor!!!
+void PaletteContainer::Init(int numslots, const uint8_t* indexmap)	// This cannot be a constructor!!!
 {
 	if (numslots < 1) numslots = 1;
 	Clear();
@@ -63,6 +63,7 @@ void PaletteContainer::Init(int numslots)	// This cannot be a constructor!!!
 	TranslationTables.Resize(numslots);
 	StoreTranslation(0, &remap);	// make sure that translation ID 0 is the identity.
 	ColorMatcher.SetPalette(BaseColors);
+	ColorMatcher.SetIndexMap(indexmap);
 }
 
 void PaletteContainer::SetPalette(const uint8_t* colors, int transparent_index)

source/common/engine/palettecontainer.h

@@ -116,7 +116,7 @@ private:
 	FMemArena remapArena;
 	TArray<TAutoGrowArray<FRemapTablePtr, FRemapTable*>> TranslationTables;
 public:
-	void Init(int numslots);	// This cannot be a constructor!!!
+	void Init(int numslots, const uint8_t *indexmap);	// This cannot be a constructor!!!
 	void SetPalette(const uint8_t* colors, int transparent_index = -1);
 	void Clear();
 	int DetermineTranslucency(FileReader& file);

source/common/utility/colormatcher.h

@@ -42,23 +42,21 @@
 
 #include "palutil.h"
 
-int BestColor (const uint32_t *pal_in, int r, int g, int b, int first, int num);
+int BestColor (const uint32_t *pal_in, int r, int g, int b, int first, int num, const uint8_t* indexmap);
 
 class FColorMatcher
 {
 public:
-	FColorMatcher () = default;
-	FColorMatcher (const uint32_t *palette) { Pal = reinterpret_cast<const PalEntry*>(palette); }
-	FColorMatcher (const FColorMatcher &other) = default;
 
 	void SetPalette(PalEntry* palette) { Pal = palette; }
 	void SetPalette (const uint32_t *palette) { Pal = reinterpret_cast<const PalEntry*>(palette); }
+	void SetIndexMap(const uint8_t* index) { indexmap = index; startindex = index ? 0 : 1; }
 	uint8_t Pick (int r, int g, int b)
 	{
 		if (Pal == nullptr)
 			return 1;
 
-		return (uint8_t)BestColor ((uint32_t *)Pal, r, g, b, 1, 255);
+		return (uint8_t)BestColor ((uint32_t *)Pal, r, g, b, startindex, 255, indexmap);
 	}
 	
 	uint8_t Pick (PalEntry pe)
@@ -66,10 +64,10 @@ public:
 		return Pick(pe.r, pe.g, pe.b);
 	}
 
-	FColorMatcher &operator= (const FColorMatcher &other) = default;
-
 private:
-	const PalEntry *Pal;
+	const PalEntry *Pal = nullptr;
+	const uint8_t* indexmap = nullptr;
+	int startindex = 1;
 };
 
 extern FColorMatcher ColorMatcher;

source/common/utility/palette.cpp

@@ -46,7 +46,7 @@
 /* Palette management stuff */
 /****************************/
 
-int BestColor (const uint32_t *pal_in, int r, int g, int b, int first, int num)
+int BestColor (const uint32_t *pal_in, int r, int g, int b, int first, int num, const uint8_t* indexmap)
 {
 	const PalEntry *pal = (const PalEntry *)pal_in;
 	int bestcolor = first;
@@ -54,17 +54,18 @@ int BestColor (const uint32_t *pal_in, int r, int g, int b, int first, int num)
 
 	for (int color = first; color < num; color++)
 	{
-		int x = r - pal[color].r;
+		int co = indexmap ? indexmap[color] : color;
-		int y = g - pal[color].g;
+		int x = r - pal[co].r;
-		int z = b - pal[color].b;
+		int y = g - pal[co].g;
+		int z = b - pal[co].b;
 		int dist = x*x + y*y + z*z;
 		if (dist < bestdist)
 		{
 			if (dist == 0)
-				return color;
+				return co;
 
 			bestdist = dist;
-			bestcolor = color;
+			bestcolor = co;
 		}
 	}
 	return bestcolor;

source/common/utility/palutil.h

@@ -7,7 +7,7 @@
 struct FScriptPosition;
 class FScanner;
 
-int BestColor(const uint32_t* pal, int r, int g, int b, int first = 1, int num = 255);
+int BestColor(const uint32_t* pal, int r, int g, int b, int first = 1, int num = 255, const uint8_t* indexmap = nullptr);
 int PTM_BestColor(const uint32_t* pal_in, int r, int g, int b, bool reverselookup, float powtable, int first = 1, int num = 255);
 void DoBlending(const PalEntry* from, PalEntry* to, int count, int r, int g, int b, int a);
 

source/core/gamecontrol.cpp

@@ -914,6 +914,8 @@ static void InitTextures()
 //
 //==========================================================================
 
+static uint8_t palindexmap[256];
+
 int RunGame()
 {
 	GameStartupInfo.FgColor = 0xffffff;
@@ -1023,7 +1025,11 @@ int RunGame()
 	}
 	GameTicRate = 30;
 	CheckUserMap();
-	GPalette.Init(MAXPALOOKUPS + 2);    // one slot for each translation, plus a separate one for the base palettes and the internal one
+
+	palindexmap[0] = 255;
+	for (int i = 1; i <= 255; i++) palindexmap[i] = i;
+	GPalette.Init(MAXPALOOKUPS + 2, palindexmap);    // one slot for each translation, plus a separate one for the base palettes and the internal one
+	int v = ColorMatcher.Pick(0, 0, 0);
 	gi->loadPalette();
 	StartScreen->Progress();
 	InitTextures();