zdoom/raze-gles
0
0
Fork 0
mirror of https://github.com/ZDoom/raze-gles.git synced 2025-01-27 09:20:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

- fixed stale pointer access in Unix version of D_AddFile.

Browse source 
Pointer was assigned a buffer of a local variable that went out of scope before checking its content.
Fixes #268 (hopefully)
This commit is contained in:
Christoph Oelckers 2021-02-26 13:28:02 +01:00
parent a46792e519
commit 4c915180da
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
source/common/utility/findfile.cpp
View file

@ -208,10 +208,10 @@ bool D_AddFile(TArray<FString>& wadfiles, const char* file, bool check, int posi
// Confirm file exists in filesystem. // Confirm file exists in filesystem.
struct stat info; struct stat info;
bool found = stat(file, &info) == 0; bool found = stat(file, &info) == 0;
FString fullpath = file;
if (!found) if (!found)
{ {
// File not found, so split file into path and filename so we can enumerate the path for the file. // File not found, so split file into path and filename so we can enumerate the path for the file.
FString fullpath = file;
auto lastindex = fullpath.LastIndexOf("/"); auto lastindex = fullpath.LastIndexOf("/");
FString basepath = fullpath.Left(lastindex); FString basepath = fullpath.Left(lastindex);
FString filename = fullpath.Right(fullpath.Len() - lastindex - 1); FString filename = fullpath.Right(fullpath.Len() - lastindex - 1);