From 46f39b725c3337b038680b20bcea00d277cb2419 Mon Sep 17 00:00:00 2001 From: helixhorned Date: Mon, 4 Jul 2016 14:09:05 +0000 Subject: [PATCH] engine.c: fix potential smostwall[-1] access. Found by ASan. git-svn-id: https://svn.eduke32.com/eduke32@5807 1a8010ca-5511-0410-912e-c29ae57300e0 --- polymer/eduke32/build/src/engine.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/polymer/eduke32/build/src/engine.c b/polymer/eduke32/build/src/engine.c index c8d63ab79..ae07b4f02 100644 --- a/polymer/eduke32/build/src/engine.c +++ b/polymer/eduke32/build/src/engine.c @@ -5867,8 +5867,9 @@ static void drawmaskwall(int16_t damaskwallcnt) setup_globals_wall1(wal, wal->overpicnum); setup_globals_wall2(wal, sec->visibility, z1, z2); - for (int i=smostwallcnt-1, j=smostwall[i]; i>=0; j=smostwall[--i]) + for (int i=smostwallcnt-1; i>=0; i--) { + int j=smostwall[i]; if ((xb1[j] > xb2[z]) || (xb2[j] < xb1[z])) continue; if (wallfront(j,z)) continue;