From c840368446bfcdb185ac45073f2061c8238d626e Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Sat, 20 Jan 2018 14:59:29 +0200 Subject: [PATCH] Fixed compilation warnings reported by GCC/Clang src/s_environment.cpp:908:6: warning: variable 'v' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] src/s_environment.cpp:908:26: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] src/s_environment.cpp:934:26: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] --- src/s_environment.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/s_environment.cpp b/src/s_environment.cpp index 4d83dd2d4..ac268bc5f 100644 --- a/src/s_environment.cpp +++ b/src/s_environment.cpp @@ -903,9 +903,9 @@ DEFINE_ACTION_FUNCTION(DReverbEdit, GetValue) { PARAM_PROLOGUE; PARAM_INT(index); - float v; + float v = 0; - if (index >= 0 && index < countof(ReverbFields)) + if (index >= 0 && index < (int)countof(ReverbFields)) { auto rev = &ReverbFields[index]; if (rev->Int != nullptr) @@ -931,7 +931,7 @@ DEFINE_ACTION_FUNCTION(DReverbEdit, SetValue) PARAM_INT(index); PARAM_FLOAT(v); - if (index >= 0 && index < countof(ReverbFields)) + if (index >= 0 && index < (int)countof(ReverbFields)) { auto rev = &ReverbFields[index]; if (rev->Int != nullptr)