From c6c6487a3014e954d4db8cf4533619e98bda95cb Mon Sep 17 00:00:00 2001 From: Braden Obrzut Date: Thu, 28 Nov 2013 14:41:40 -0500 Subject: [PATCH 1/3] - Fixed: Got a little hyper corrective in c763217. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a442b9ea5..c6f9fd6ad 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -30,7 +30,7 @@ function( add_pk3 PK3_NAME PK3_DIR ) DEPENDS zipdir ${PK3_DIR} ) else( NOT NO_GENERATOR_EXPRESSIONS AND NOT ZDOOM_OUTPUT_OLDSTYLE ) add_custom_command( OUTPUT ${ZDOOM_OUTPUT_DIR}/${PK3_NAME} - COMMAND ${ZIPDIR_EXE} -udf ${ZDOOM_OUTPUT_DIR}/${PK3_NAME} ${PK3_DIR}/${PK3_NAME} + COMMAND ${ZIPDIR_EXE} -udf ${ZDOOM_OUTPUT_DIR}/${PK3_NAME} ${PK3_DIR} DEPENDS zipdir ${PK3_DIR} ) endif( NOT NO_GENERATOR_EXPRESSIONS AND NOT ZDOOM_OUTPUT_OLDSTYLE ) From c21beb0b6c88e0cbf599c01c601da3ee31d4a25e Mon Sep 17 00:00:00 2001 From: Braden Obrzut Date: Fri, 29 Nov 2013 01:54:46 -0500 Subject: [PATCH 2/3] - Fixed: Some versions of Visual Studio put the map file in a different location. --- src/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 6c31ca69c..ff29f27e7 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1101,7 +1101,7 @@ if( MSVC ) option( ZDOOM_GENERATE_MAPFILE "Generate .map file for debugging." OFF ) if( ZDOOM_GENERATE_MAPFILE ) if( NOT MSVC80 ) - set_target_properties(zdoom PROPERTIES LINK_FLAGS "/MANIFEST:NO /DELAYLOAD:\"fmodex${X64}.dll\" /MAP:${ZDOOM_EXE_NAME}.map") + set_target_properties(zdoom PROPERTIES LINK_FLAGS "/MANIFEST:NO /DELAYLOAD:\"fmodex${X64}.dll\" /MAP:\"$(TargetDir)${ZDOOM_EXE_NAME}.map\"") else( NOT MSVC80 ) # 2005 doesn't support naming the map file. set_target_properties(zdoom PROPERTIES LINK_FLAGS "/MANIFEST:NO /DELAYLOAD:\"fmodex${X64}.dll\" /MAP") endif( NOT MSVC80 ) From a8090dc22c31a765961a01a64108576fd0637fc9 Mon Sep 17 00:00:00 2001 From: Braden Obrzut Date: Fri, 29 Nov 2013 02:09:27 -0500 Subject: [PATCH 3/3] - Remove a hardcoded "zdoom" so that the name passed into the copy operation should always match that passed to /MAP. --- src/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ff29f27e7..60cdb01f8 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1128,7 +1128,7 @@ if( ZDOOM_OUTPUT_OLDSTYLE AND NOT NO_GENERATOR_EXPRESSIONS ) if( ZDOOM_GENERATE_MAPFILE ) add_custom_command(TARGET zdoom POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy_if_different $ ${ZDOOM_OUTPUT_DIR}/$ - COMMAND ${CMAKE_COMMAND} -E copy_if_different $/zdoom.map ${ZDOOM_OUTPUT_DIR}/$.map + COMMAND ${CMAKE_COMMAND} -E copy_if_different $/${ZDOOM_EXE_NAME}.map ${ZDOOM_OUTPUT_DIR}/$.map COMMENT "Copying to output directory..." ) else( ZDOOM_GENERATE_MAPFILE ) add_custom_command(TARGET zdoom POST_BUILD