zdoom/qzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/qzdoom.git synced 2024-11-11 07:11:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Set more suitable limit for sound velocity validation

Browse source 
https://forum.zdoom.org/viewtopic.php?t=59979
This commit is contained in:
alexey.lysiuk 2018-03-29 17:36:48 +03:00
parent cbad9ac219
commit b952653303
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/s_sound.cpp
View file

@ -817,14 +817,17 @@ static void CalcPosVel(int type, const AActor *actor, const sector_t *sector,
//
//==========================================================================
inline bool Validate(const float value)
inline bool Validate(const float value, const float limit)
{
return value >= -32768.f && value <= 32768.f;
return value >= -limit && value <= limit;
}
static bool Validate(const FVector3 &value, const char *const name, const AActor *const actor)
static bool Validate(const FVector3 &value, const float limit, const char *const name, const AActor *const actor)
{
const bool valid = Validate(value.X) && Validate(value.Y) && Validate(value.Z);
const bool valid =
Validate(value.X, limit)
&& Validate(value.Y, limit)
&& Validate(value.Z, limit);
if (!valid)
{
@ -845,8 +848,13 @@ static bool Validate(const FVector3 &value, const char *const name, const AActor
static bool ValidatePosVel(const AActor *actor, const FVector3 &pos, const FVector3 &vel)
{
const bool valid = Validate(pos, "position", actor);
return Validate(vel, "velocity", actor) && valid;
// The actual limit for map coordinates
static const float POSITION_LIMIT = 32768.f;
const bool valid = Validate(pos, POSITION_LIMIT, "position", actor);
// The maximum velocity is enough to travel through entire map in one tic
static const float VELOCITY_LIMIT = 2 * sqrtf(2.f) * POSITION_LIMIT * TICRATE;
return Validate(vel, VELOCITY_LIMIT, "velocity", actor) && valid;
}
static bool ValidatePosVel(const FSoundChan *const chan, const FVector3 &pos, const FVector3 &vel)