- fixed a few compilation warnings

src/d_main.cpp:280:18: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
src/rendering/r_videoscale.cpp:147:22: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
src/sound/s_reverbedit.cpp:250:18: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Wsign-compare]
This commit is contained in:
alexey.lysiuk 2020-01-04 12:59:26 +02:00
parent 8b3c03d416
commit 651dfbc49f
3 changed files with 3 additions and 4 deletions

View file

@ -277,7 +277,7 @@ void D_ToggleHud()
static int saved_screenblocks;
static bool saved_drawplayersprite, saved_showmessages;
if (hud_toggled = !hud_toggled)
if ((hud_toggled = !hud_toggled))
{
saved_screenblocks = screenblocks;
saved_drawplayersprite = r_drawplayersprites;

View file

@ -144,7 +144,7 @@ namespace
};
bool isOutOfBounds(int x)
{
return (x < 0 || x >= NUMSCALEMODES || vScaleTable[x].isValid == false);
return (x < 0 || x >= int(NUMSCALEMODES) || vScaleTable[x].isValid == false);
}
}

View file

@ -236,7 +236,6 @@ void ExportEnvironments(const char *filename, uint32_t count, const ReverbContai
{
const ReverbContainer *env = envs[i];
const ReverbContainer *base;
size_t j;
if ((unsigned int)env->Properties.Environment < 26)
{
@ -247,7 +246,7 @@ void ExportEnvironments(const char *filename, uint32_t count, const ReverbContai
base = nullptr;
}
f->Printf("\"%s\" %u %u\n{\n", env->Name, HIBYTE(env->ID), LOBYTE(env->ID));
for (j = 0; j < NumReverbs; ++j)
for (int j = 0; j < NumReverbs; ++j)
{
const FReverbField *ctl = &ReverbFields[j];
const char *ctlName = ReverbFieldNames[j];