zdoom/qzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/qzdoom.git synced 2024-11-10 14:51:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

- removed an unchecked fixed size buffer in the KEYCONF parser.

Browse source
This commit is contained in:
Christoph Oelckers 2018-03-03 09:14:33 +01:00
parent b327aa737a
commit 4f68b78c3b
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/keysections.cpp
View file

@ -155,7 +155,7 @@ CCMD (addmenukey)
void D_LoadWadSettings ()
{
char cmd[4096];
TArray<char> command;
int lump, lastlump = 0;
ParsingKeyConf = true;
@ -173,16 +173,17 @@ void D_LoadWadSettings ()
size_t i;
// Fetch a line to execute
command.Clear();
for (i = 0; conf + i < eof && conf[i] != '\n'; ++i)
{
cmd[i] = conf[i];
command.Push(conf[i]);
}
if (i == 0)
{
conf++;
continue;
}
cmd[i] = 0;
command.Push(0);
conf += i;
if (*conf == '\n')
{
@ -190,8 +191,8 @@ void D_LoadWadSettings ()
}
// Comments begin with //
char *stop = cmd + i - 1;
char *comment = cmd;
char *stop = &command[i - 1];
char *comment = &command[0];
int inQuote = 0;
if (*stop == '\r')
@ -209,7 +210,7 @@ void D_LoadWadSettings ()
}
comment++;
}
if (comment == cmd)
if (comment == &command[0])
{ // Comment at line beginning
continue;
}
@ -218,7 +219,7 @@ void D_LoadWadSettings ()
*comment = 0;
}
AddCommandString (cmd);
AddCommandString (&command[0]);
}
}
ParsingKeyConf = false;