From 396bac5e4f048dbc2cf1dbf7d5bac3ab70d60ab5 Mon Sep 17 00:00:00 2001 From: nashmuhandes Date: Tue, 15 Feb 2022 00:34:10 +0800 Subject: [PATCH] - Initialize some variables in FModelVertex::Set - Fix wrong normal vector in the FModelVertexBuffer constructor This fixes models having strange flickering when the model animation frame changes --- src/common/rendering/hwrenderer/data/hw_modelvertexbuffer.cpp | 2 +- src/common/rendering/i_modelvertexbuffer.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/common/rendering/hwrenderer/data/hw_modelvertexbuffer.cpp b/src/common/rendering/hwrenderer/data/hw_modelvertexbuffer.cpp index 8fd8e0ab4..da5b3be3c 100644 --- a/src/common/rendering/hwrenderer/data/hw_modelvertexbuffer.cpp +++ b/src/common/rendering/hwrenderer/data/hw_modelvertexbuffer.cpp @@ -50,7 +50,7 @@ FModelVertexBuffer::FModelVertexBuffer(bool needindex, bool singleframe) { 1, VATTR_VERTEX2, VFmt_Float3, (int)myoffsetof(FModelVertex, x) }, { 1, VATTR_NORMAL2, VFmt_Packed_A2R10G10B10, (int)myoffsetof(FModelVertex, packedNormal) } }; - mVertexBuffer->SetFormat(2, 5, sizeof(FModelVertex), format); + mVertexBuffer->SetFormat(2, 6, sizeof(FModelVertex), format); } //=========================================================================== diff --git a/src/common/rendering/i_modelvertexbuffer.h b/src/common/rendering/i_modelvertexbuffer.h index 929826ca9..bd3df3767 100644 --- a/src/common/rendering/i_modelvertexbuffer.h +++ b/src/common/rendering/i_modelvertexbuffer.h @@ -17,6 +17,8 @@ struct FModelVertex z = zz; u = uu; v = vv; + lu = 0.0f; + lv = 0.0f; lindex = -1.0f; }