zdoom/qzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/qzdoom.git synced 2024-12-01 08:31:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

- fixed: FxAssign used the wrong value type for emitting the store operation.

Browse source 
It used the expression's value type, but needs to use the variable's, which can be different when the assignment is synthesized from a builtin function.
This commit is contained in:
Christoph Oelckers 2017-03-19 21:36:18 +01:00
parent 403c5693a9
commit 0721aef218
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/scripting/backend/codegen.cpp
View file

@ -2563,7 +2563,7 @@ ExpEmit FxAssign::Emit(VMFunctionBuilder *build)
if (IsBitWrite == -1) if (IsBitWrite == -1)
{ {
build->Emit(ValueType->GetStoreOp(), pointer.RegNum, result.RegNum, build->GetConstantInt(0)); build->Emit(Base->ValueType->GetStoreOp(), pointer.RegNum, result.RegNum, build->GetConstantInt(0));
} }
else else
{ {

2
src/scripting/backend/vmbuilder.cpp
View file

@ -570,8 +570,6 @@ size_t VMFunctionBuilder::Emit(int opcode, int opa, int opb, int opc)
assert(opb >= 0); assert(opb >= 0);
assert(opc >= 0); assert(opc >= 0);
assert(opcode != OP_NOP);
// The following were just asserts, meaning this would silently create broken code if there was an overflow // The following were just asserts, meaning this would silently create broken code if there was an overflow
// if this happened in a release build. Not good. // if this happened in a release build. Not good.
// These are critical errors that need to be reported to the user. // These are critical errors that need to be reported to the user.