From bfc116b2a4a64662b8c07eaf0053d1b3c7f9ae8b Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Sun, 17 Jan 2016 11:51:46 +0200 Subject: [PATCH] Fixed exit crash on legacy OS X There is no need to close (and thus deallocate) console window explicitly This will be done by autorelease pool in application controller event loop OS X with GC and/or ARC was not affected by this issue Older versions like 10.4 or 10.5 crashed because of double deallocation --- src/posix/cocoa/st_console.h | 1 - src/posix/cocoa/st_console.mm | 5 ----- 2 files changed, 6 deletions(-) diff --git a/src/posix/cocoa/st_console.h b/src/posix/cocoa/st_console.h index 49b6e0547..6b6f01820 100644 --- a/src/posix/cocoa/st_console.h +++ b/src/posix/cocoa/st_console.h @@ -85,7 +85,6 @@ private: int m_netMaxPos; FConsoleWindow(); - ~FConsoleWindow(); void ExpandTextView(float height); diff --git a/src/posix/cocoa/st_console.mm b/src/posix/cocoa/st_console.mm index 342e251a3..e952d22d6 100644 --- a/src/posix/cocoa/st_console.mm +++ b/src/posix/cocoa/st_console.mm @@ -118,11 +118,6 @@ FConsoleWindow::FConsoleWindow() [m_window makeKeyAndOrderFront:nil]; } -FConsoleWindow::~FConsoleWindow() -{ - [m_window close]; -} - static FConsoleWindow* s_instance;