From 5a5fb9b3d19372d9323ba31fa5689fc95f94250b Mon Sep 17 00:00:00 2001
From: Randy Heit <rheit@zdoom.fake>
Date: Mon, 24 Feb 2014 18:16:18 -0600
Subject: [PATCH] Clamp xy angle range in P_SetSlope()

- This function just assumed that every xy angle passed to it was within
  the range [0,360). This is obviously bad, since anything outside that
  range can result in accessing data outside the range of the finecosine
  and finesine tables.
---
 src/p_slopes.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/p_slopes.cpp b/src/p_slopes.cpp
index 07ddf2e0d..af0ad7a20 100644
--- a/src/p_slopes.cpp
+++ b/src/p_slopes.cpp
@@ -178,6 +178,12 @@ void P_SetSlope (secplane_t *plane, bool setCeil, int xyangi, int zangi,
 	}
 	zang >>= ANGLETOFINESHIFT;
 
+	// Sanitize xyangi to [0,360) range
+	xyangi = xyangi % 360;
+	if (xyangi < 0)
+	{
+		xyangi = 360 + xyangi;
+	}
 	xyang = (angle_t)Scale (xyangi, ANGLE_90, 90 << ANGLETOFINESHIFT);
 
 	FVector3 norm;
@@ -446,11 +452,11 @@ void P_SpawnSlopeMakers (FMapThing *firstmt, FMapThing *lastmt, const int *oldve
 				P_VavoomSlope(sec, mt->thingid, x, y, mt->z, mt->type & 1); 
 			}
 			else if (mt->type <= THING_SlopeCeilingPointLine)
-			{
+			{ // THING_SlopeFloorPointLine and THING_SlopCeilingPointLine
 				P_SlopeLineToPoint (mt->args[0], x, y, z, mt->type & 1);
 			}
 			else
-			{
+			{ // THING_SetFloorSlope and THING_SetCeilingSlope
 				P_SetSlope (refplane, mt->type & 1, mt->angle, mt->args[0], x, y, z);
 			}
 			mt->type = 0;