zdoom/gzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom.git synced 2025-03-26 04:31:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

fixed: The savegame's PNG loader must use a caching FileReader to avoid holding a handle to the containing file.

Browse source 
This blocked savegame deletion.
This commit is contained in:
Christoph Oelckers 2024-05-01 09:49:45 +02:00
parent 81dade9ed5
commit f2d582f680
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/common/menu/savegamemanager.cpp
View file

@ -316,7 +316,8 @@ unsigned FSavegameManagerBase::ExtractSaveData(int index)
auto pic = resf->FindEntry("savepic.png");
if (pic >= 0)
{
FileReader picreader = resf->GetEntryReader(pic, FileSys::READER_NEW, FileSys::READERFLAG_SEEKABLE);
// This must use READER_CACHED or it will lock the savegame file.
FileReader picreader = resf->GetEntryReader(pic, FileSys::READER_CACHED, FileSys::READERFLAG_SEEKABLE);
PNGHandle *png = M_VerifyPNG(picreader);
if (png != nullptr)
{