zdoom/gzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom.git synced 2024-11-30 07:41:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

Removed redundant comparison in compatibility renderer

Browse source 
Clang no longer reports "warning: comparison of array 'this->tcs' not equal to a null pointer is always true"
This commit is contained in:
alexey.lysiuk 2016-07-30 10:25:42 +03:00
parent da1762ac2c
commit e2a2d38a25
1 changed files with 15 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/gl/compatibility/gl_20.cpp
View file

@ -705,28 +705,25 @@ bool GLWall::PrepareLight(ADynamicLight * light, int pass)
return false; return false;
} }
if (tcs != NULL) Vector t1;
int outcnt[4] = { 0,0,0,0 };
for (int i = 0; i<4; i++)
{ {
Vector t1; t1.Set(&vtx[i * 3]);
int outcnt[4] = { 0,0,0,0 }; Vector nearToVert = t1 - nearPt;
tcs[i].u = (nearToVert.Dot(right) * scale) + 0.5f;
tcs[i].v = (nearToVert.Dot(up) * scale) + 0.5f;
for (int i = 0; i<4; i++) // quick check whether the light touches this polygon
{ if (tcs[i].u<0) outcnt[0]++;
t1.Set(&vtx[i * 3]); if (tcs[i].u>1) outcnt[1]++;
Vector nearToVert = t1 - nearPt; if (tcs[i].v<0) outcnt[2]++;
tcs[i].u = (nearToVert.Dot(right) * scale) + 0.5f; if (tcs[i].v>1) outcnt[3]++;
tcs[i].v = (nearToVert.Dot(up) * scale) + 0.5f;
// quick check whether the light touches this polygon
if (tcs[i].u<0) outcnt[0]++;
if (tcs[i].u>1) outcnt[1]++;
if (tcs[i].v<0) outcnt[2]++;
if (tcs[i].v>1) outcnt[3]++;
}
// The light doesn't touch this polygon
if (outcnt[0] == 4 || outcnt[1] == 4 || outcnt[2] == 4 || outcnt[3] == 4) return false;
} }
// The light doesn't touch this polygon
if (outcnt[0] == 4 || outcnt[1] == 4 || outcnt[2] == 4 || outcnt[3] == 4) return false;
draw_dlight++; draw_dlight++;
return true; return true;