- removed bogus errno check from Dehacked parser.

This checked errno without first confirming that there has been an error, it is also pointless because the value range check will automatically catch the error case as well.
This commit is contained in:
Christoph Oelckers 2022-12-08 09:50:06 +01:00
parent b1cb044a15
commit e17e6868e6
3 changed files with 8 additions and 1 deletions

View file

@ -2,6 +2,10 @@ cmake_minimum_required( VERSION 3.1.0 )
make_release_only()
if (MSVC)
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4244" )
endif()
add_definitions( -DBZ_NO_STDIO )
add_library( bz2 STATIC
blocksort.c

View file

@ -1484,6 +1484,9 @@ source_group("Common\\Third Party\\RapidJSON" REGULAR_EXPRESSION "^${CMAKE_CURRE
source_group("Common\\Third Party\\SFMT" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/common/thirdparty/sfmt/.+")
source_group("Utility" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/utility/.+")
source_group("Utility\\Node Builder" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/utility/nodebuilder/.+")
source_group("Utility\\Smackerdec" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/smackerdec/.+")
source_group("Utility\\Smackerdec\\Headers" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/libsmackerdec/include/.+")
source_group("Utility\\Smackerdec\\Sources" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/libsmackerdec/src/.+")
source_group("Statusbar" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/g_statusbar/.+")
source_group("Versioning" FILES version.h win32/zdoom.rc)
source_group("Xlat" REGULAR_EXPRESSION "^${CMAKE_CURRENT_SOURCE_DIR}/xlat/.+" FILES ${CMAKE_CURRENT_BINARY_DIR}/xlat_parser.c ${CMAKE_CURRENT_BINARY_DIR}/xlat_parser.h)

View file

@ -1142,7 +1142,7 @@ static int PatchThing (int thingy)
size_t linelen = strlen (Line1);
// Supported value range is all valid representations of signed int and unsigned int.
if (errno == ERANGE || val < INT_MIN || val > UINT_MAX)
if (val < INT_MIN || val > UINT_MAX)
{
Printf("Bad numeric constant %s for %s\n", Line2, Line1);
}