zdoom/gzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom.git synced 2024-11-22 12:11:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

- added safeguards against very early access to console variables in Cocoa backend

Browse source 
for an unknown reason, application activation functions can be called way too early during app launch
`S_SetSoundPaused()` function tries to read values of `i_pauseinbackground` and `i_soundinbackground` console variables before their initialization leading to a null pointer dereference

https://forum.zdoom.org/viewtopic.php?t=78092
This commit is contained in:
alexey.lysiuk 2023-08-22 13:49:32 +03:00
parent 22271d146a
commit ae2fa11963
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/common/platform/posix/cocoa/i_main.mm
View file

@ -282,7 +282,8 @@ extern bool AppActive;
{ {
ZD_UNUSED(aNotification); ZD_UNUSED(aNotification);
S_SetSoundPaused(1); if (GSnd)
S_SetSoundPaused(1);
AppActive = true; AppActive = true;
} }
@ -291,7 +292,8 @@ extern bool AppActive;
{ {
ZD_UNUSED(aNotification); ZD_UNUSED(aNotification);
S_SetSoundPaused(0); if (GSnd)
S_SetSoundPaused(0);
AppActive = false; AppActive = false;
} }