Somehow fix lightmaps being corrupted in debug build

src/common/rendering/vulkan/accelstructs/vk_lightmap.cpp

@@ -54,7 +54,6 @@ void VkLightmap::Raytrace(LevelMesh* level, const TArray<LevelMeshSurface*>& sur
 {
 	bool newLevel = (mesh != level);
 	mesh = level;
-
 	if (newLevel)
 	{
 		UpdateAccelStructDescriptors();
@@ -63,62 +62,65 @@ void VkLightmap::Raytrace(LevelMesh* level, const TArray<LevelMeshSurface*>& sur
 		lightmapRaytraceLast.Reset();
 	}
 
-	lightmapRaytrace.active = true;
+	if (surfaces.Size())
-	lightmapRaytraceLast.active = true;
+	{
+		lightmapRaytrace.active = true;
+		lightmapRaytraceLast.active = true;
 
-	lightmapRaytrace.Clock();
+		lightmapRaytrace.Clock();
-	lightmapRaytraceLast.ResetAndClock();
+		lightmapRaytraceLast.ResetAndClock();
 
-	CreateAtlasImages(surfaces);
+		CreateAtlasImages(surfaces);
 
 #if 0 // SmoothGroups
-	TArray<int> allSurfaces;
+		TArray<int> allSurfaces;
 
-	std::set<int> s;
+		std::set<int> s;
 
-	for (auto& surface : surfaceIndices)
+		for (auto& surface : surfaceIndices)
-	{
-		s.insert(mesh->GetSurface(surface)->smoothingGroupIndex);
-	}
-
-	for (int i = 0, count = level->GetSurfaceCount(); i < count; ++i)
-	{
-		auto surface = level->GetSurface(i);
-		
-		if (s.find(surface->smoothingGroupIndex) != s.end())
 		{
-			allSurfaces.Push(i);
+			s.insert(mesh->GetSurface(surface)->smoothingGroupIndex);
-			surface->needsUpdate = false;
+		}
+
+		for (int i = 0, count = level->GetSurfaceCount(); i < count; ++i)
+		{
+			auto surface = level->GetSurface(i);
+
+			if (s.find(surface->smoothingGroupIndex) != s.end())
+			{
+				allSurfaces.Push(i);
+				surface->needsUpdate = false;
+			}
 		}
-	}
 #else
-	const auto& allSurfaces = surfaces;
+		const auto& allSurfaces = surfaces;
 #endif
 
-	UploadUniforms();
+		UploadUniforms();
 
-	lastSurfaceCount = allSurfaces.Size();
+		lastSurfaceCount = allSurfaces.Size();
 
-	for (size_t pageIndex = 0; pageIndex < atlasImages.size(); pageIndex++)
+		for (size_t pageIndex = 0; pageIndex < atlasImages.size(); pageIndex++)
-	{
-		if (atlasImages[pageIndex].pageMaxX && atlasImages[pageIndex].pageMaxY)
 		{
-			RenderAtlasImage(pageIndex, allSurfaces);
+			if (atlasImages[pageIndex].pageMaxX && atlasImages[pageIndex].pageMaxY)
+			{
+				RenderAtlasImage(pageIndex, allSurfaces);
+			}
 		}
-	}
 
-	for (size_t pageIndex = 0; pageIndex < atlasImages.size(); pageIndex++)
+		for (size_t pageIndex = 0; pageIndex < atlasImages.size(); pageIndex++)
-	{
-		if (atlasImages[pageIndex].pageMaxX && atlasImages[pageIndex].pageMaxY)
 		{
-			ResolveAtlasImage(pageIndex);
+			if (atlasImages[pageIndex].pageMaxX && atlasImages[pageIndex].pageMaxY)
-			BlurAtlasImage(pageIndex);
+			{
-			CopyAtlasImageResult(pageIndex, allSurfaces);
+				ResolveAtlasImage(pageIndex);
+				BlurAtlasImage(pageIndex);
+				CopyAtlasImageResult(pageIndex, allSurfaces);
+			}
 		}
-	}
 
-	lightmapRaytrace.Unclock();
+		lightmapRaytrace.Unclock();
-	lightmapRaytraceLast.Unclock();
+		lightmapRaytraceLast.Unclock();
+	}
 }
 
 void VkLightmap::RenderAtlasImage(size_t pageIndex, const TArray<LevelMeshSurface*>& surfaces)
@@ -272,7 +274,7 @@ void VkLightmap::CreateAtlasImages(const TArray<LevelMeshSurface*>& surfaces)
 		LevelMeshSurface* surface = surfaces[i];
 	//for (int i = 0, count = mesh->GetSurfaceCount(); i < count; i++)
 	//{
-		//LevelMeshSurface* surface = mesh->GetSurface(i);
+	//	LevelMeshSurface* surface = mesh->GetSurface(i);
 
 		auto result = packer.insert(surface->texWidth + 2, surface->texHeight + 2);
 		surface->lightmapperAtlasX = result.pos.x + 1;

src/rendering/hwrenderer/doom_levelmesh.cpp

@@ -369,8 +369,6 @@ void DoomLevelMesh::BindLightmapSurfacesToGeometry(FLevelLocals& doomMap)
 	{
 		surface.TexCoords = (float*)&LightmapUvs[surface.startUvIndex];
 
-		surface.LightmapNum = surface.atlasPageIndex;
-
 		if (surface.Type == ST_FLOOR || surface.Type == ST_CEILING)
 		{
 			surface.Subsector = &doomMap.subsectors[surface.typeIndex];

src/rendering/hwrenderer/doom_levelmesh.h

@@ -16,10 +16,9 @@ struct FLevelLocals;
 
 struct DoomLevelMeshSurface : public LevelMeshSurface
 {
-	subsector_t* Subsector;
+	subsector_t* Subsector = nullptr;
-	side_t* Side;
+	side_t* Side = nullptr;
-	sector_t* ControlSector;
+	sector_t* ControlSector = nullptr;
-	uint32_t LightmapNum; // To do: same as atlasPageIndex. Delete one of them!
 	float* TexCoords;
 };
 

src/rendering/hwrenderer/hw_vertexbuilder.cpp

@@ -243,7 +243,7 @@ static int CreateIndexedSectorVerticesLM(FRenderState& renderstate, sector_t* se
 		if (lightmap && lightmap->Type != ST_UNKNOWN) // lightmap may be missing if the subsector is degenerate triangle
 		{
 			float* luvs = lightmap->TexCoords;
-			int lindex = lightmap->LightmapNum;
+			int lindex = lightmap->atlasPageIndex;
 			for (unsigned int j = 0; j < sub->numlines; j++)
 			{
 				SetFlatVertex(vbo_shadowdata[vi + pos], sub->firstline[j].v1, plane, luvs[j * 2], luvs[j * 2 + 1], lindex);

src/rendering/hwrenderer/scene/hw_walls.cpp

@@ -1019,7 +1019,7 @@ bool HWWall::SetWallCoordinates(seg_t * seg, FTexCoordInfo *tci, float textureto
 	if (lightmap && lightmap->Type != ST_UNKNOWN)
 	{
 		srclightuv = (texcoord*)lightmap->TexCoords;
-		lindex = (float)lightmap->LightmapNum;
+		lindex = (float)lightmap->atlasPageIndex;
 	}
 	else
 	{
@@ -1725,7 +1725,7 @@ void HWWall::BuildFFBlock(HWDrawInfo *di, FRenderState& state, seg_t * seg, F3DF
 		if (lightmap && lightmap->Type != ST_UNKNOWN)
 		{
 			srclightuv = (texcoord*)lightmap->TexCoords;
-			lindex = (float)lightmap->LightmapNum;
+			lindex = (float)lightmap->atlasPageIndex;
 		}
 		else
 		{