From 82af7f4f68c8eb97af0b38f2c40126d3e28c1e74 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Wed, 10 Jun 2020 12:54:17 +0200 Subject: [PATCH] - mapped "Smooth mouse" back to m_filter CVAR and removed smooth_mouse. The option effectively disables per frame mouse checks. The motivation to add it was that many wireless mice 10-15 years ago had update rates of less than 35Hz, and on these it was necessary to sync mouse input with the playsim to properly interpolate between updates. Today this is totally useless and even counterproductive because modern mice have significantly higher update rates, so this option no longer smoothes things but instead makes the mouse feel more choppy. --- src/g_game.cpp | 7 ++----- wadsrc/static/menudef.txt | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/g_game.cpp b/src/g_game.cpp index 7cdebeee85..95f37f069d 100644 --- a/src/g_game.cpp +++ b/src/g_game.cpp @@ -797,9 +797,6 @@ void G_BuildTiccmd (ticcmd_t *cmd) cmd->ucmd.sidemove <<= 8; } -//[Graf Zahl] This really helps if the mouse update rate can't be increased! -CVAR (Bool, smooth_mouse, false, CVAR_GLOBALCONFIG|CVAR_ARCHIVE) - static int LookAdjust(int look) { look <<= 16; @@ -857,7 +854,7 @@ void G_AddViewPitch (int look, bool mouse) } if (look != 0) { - LocalKeyboardTurner = (!mouse || smooth_mouse); + LocalKeyboardTurner = !mouse; } } @@ -872,7 +869,7 @@ void G_AddViewAngle (int yaw, bool mouse) LocalViewAngle -= yaw; if (yaw != 0) { - LocalKeyboardTurner = (!mouse || smooth_mouse); + LocalKeyboardTurner = !mouse; } } diff --git a/wadsrc/static/menudef.txt b/wadsrc/static/menudef.txt index 94c6dd47a5..1e06d6cd84 100644 --- a/wadsrc/static/menudef.txt +++ b/wadsrc/static/menudef.txt @@ -726,7 +726,7 @@ OptionMenu "MouseOptions" protected StaticText "" Slider "$MOUSEMNU_SENSITIVITY", "mouse_sensitivity", 0.5, 2.5, 0.1 Option "$MOUSEMNU_NOPRESCALE", "m_noprescale", "NoYes" - Option "$MOUSEMNU_SMOOTHMOUSE", "smooth_mouse", "YesNo" + Option "$MOUSEMNU_SMOOTHMOUSE", "m_filter", "YesNo" StaticText "" Slider "$MOUSEMNU_TURNSPEED", "m_yaw", 0, 2.5, 0.1 Slider "$MOUSEMNU_MOUSELOOKSPEED", "m_pitch", 0, 2.5, 0.1