zdoom/gzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom.git synced 2024-11-26 05:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix SNDINFO $rolloff always changing global rolloff

Browse source 
I investigated the issue a bit more by copying the grenade sounds from Wolfenstein: Blade of Agony and the definitions for the sounds from its SNDINFO lump, and then copying the entire SNDINFO lump from Wolfenstein: Blade of Agony into a small test mod, and disabling tags like $volume and $rolloff using sed. It turns out disabling $rolloff tags fixed the issue, and looking into the code, it seems as though the global rolloff was always being changed, or that rolloff was picking up a garbage pointer.

Fixes #1849
This commit is contained in:
Kevin Caccamo 2022-11-27 10:08:48 -05:00 committed by Christoph Oelckers
parent 1a7a56ce39
commit 6cf3dc045f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/sound/s_advsound.cpp
View file

@ -952,7 +952,7 @@ static void S_AddSNDINFO (int lump)
{ {
sfx = soundEngine->FindSoundTentative(sc.String); sfx = soundEngine->FindSoundTentative(sc.String);
auto sfxp = soundEngine->GetWritableSfx(sfx); auto sfxp = soundEngine->GetWritableSfx(sfx);
sfxp->Rolloff; rolloff = &sfxp->Rolloff;
} }
type = ROLLOFF_Doom; type = ROLLOFF_Doom;
if (!sc.CheckFloat()) if (!sc.CheckFloat())