From 5e1100096e34715bd91bce96ed937570cee202b3 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Sun, 3 Dec 2017 17:04:10 +0100 Subject: [PATCH] - work on reverb save menu. --- src/s_environment.cpp | 81 +++++++++++++++++++++-- wadsrc/static/menudef.txt | 10 +++ wadsrc/static/zscript/menu/reverbedit.txt | 48 ++++++++++++++ 3 files changed, 134 insertions(+), 5 deletions(-) diff --git a/src/s_environment.cpp b/src/s_environment.cpp index 8c9d61e05b..cf2da7c5e6 100644 --- a/src/s_environment.cpp +++ b/src/s_environment.cpp @@ -55,6 +55,12 @@ REVERB_PROPERTIES SavedProperties; ReverbContainer *CurrentEnv; extern ReverbContainer *ForcedEnvironment; +// These are for internal use only and not supposed to be user-settable +CVAR(String, reverbedit_name, "", CVAR_NOSET); +CVAR(Int, reverbedit_id1, 0, CVAR_NOSET); +CVAR(Int, reverbedit_id2, 0, CVAR_NOSET); +CVAR(String, reverbsavename, "", CVAR_NOSET); + struct FReverbField { int Min, Max; @@ -971,7 +977,7 @@ DEFINE_ACTION_FUNCTION(DReverbEdit, FillSelectMenu) PARAM_PROLOGUE; PARAM_STRING(ccmd); PARAM_OBJECT(desc, DOptionMenuDescriptor); - desc->mItems.Clear(); + desc->mItems.Resize(2); for (auto env = Environments; env != nullptr; env = env->Next) { FStringf text("(%d, %d) %s", HIBYTE(env->ID), LOBYTE(env->ID), env->Name); @@ -992,10 +998,75 @@ DEFINE_ACTION_FUNCTION(DReverbEdit, FillSelectMenu) return 0; } -// These are for internal use only and not supposed to be user-settable -CVAR(String, reverbedit_name, "", CVAR_NOSET); -CVAR(Int, reverbedit_id1, 0, CVAR_NOSET); -CVAR(Int, reverbedit_id2, 0, CVAR_NOSET); +static TArray> SaveState; + +DEFINE_ACTION_FUNCTION(DReverbEdit, FillSaveMenu) +{ + PARAM_PROLOGUE; + PARAM_OBJECT(desc, DOptionMenuDescriptor); + desc->mItems.Clear(); + SaveState.Clear(); + for (auto env = Environments; env != nullptr; env = env->Next) + { + if (!env->Builtin) + { + int index = (int)SaveState.Push(std::make_pair(env, false)); + + FStringf text("(%d, %d) %s", HIBYTE(env->ID), LOBYTE(env->ID), env->Name); + PClass *cls = PClass::FindClass("OptionMenuItemReverbSaveSelect"); + if (cls != nullptr && cls->IsDescendantOf("OptionMenuItem")) + { + auto func = dyn_cast(cls->FindSymbol("Init", true)); + if (func != nullptr) + { + DMenuItemBase *item = (DMenuItemBase*)cls->CreateNew(); + VMValue params[] = { item, &text, index, FName("OnOff").GetIndex() }; + VMCall(func->Variants[0].Implementation, params, 4, nullptr, 0); + desc->mItems.Push((DMenuItemBase*)item); + } + } + } + } + return 0; +} + +DEFINE_ACTION_FUNCTION(DReverbEdit, GetSaveSelection) +{ + PARAM_PROLOGUE; + PARAM_INT(index); + bool res = false; + if ((unsigned)index <= SaveState.Size()) + { + res = SaveState[index].second; + } + ACTION_RETURN_BOOL(res); +} + +DEFINE_ACTION_FUNCTION(DReverbEdit, ToggleSaveSelection) +{ + PARAM_PROLOGUE; + PARAM_INT(index); + if ((unsigned)index <= SaveState.Size()) + { + SaveState[index].second = !SaveState[index].second; + } + return 0; +} + + +CCMD(savereverbs) +{ + if (SaveState.Size() == 0) return; + + TArray toSave; + + for (auto &p : SaveState) + { + if (p.second) toSave.Push(p.first); + } + ExportEnvironments(reverbsavename, toSave.Size(), &toSave[0]); + SaveState.Clear(); +} static void SelectEnvironment(const char *envname) { diff --git a/wadsrc/static/menudef.txt b/wadsrc/static/menudef.txt index 420c0e8c0e..c7a147399d 100644 --- a/wadsrc/static/menudef.txt +++ b/wadsrc/static/menudef.txt @@ -2280,4 +2280,14 @@ OptionMenu "ReverbNew" protected NumberField "ID #1", "reverbedit_id1", 0, 255 NumberField "ID #2", "reverbedit_id2", 0, 255 Command "Create", "createenvironment", 0, 1 +} + +OptionMenu "ReverbSave" protected +{ + Class "ReverbSave" + Title "Save Reverb Environments" + Command "Save...", "savereverbs" + StaticText "" + StaticText "Environments to save" + // Rest is filled in by code. } \ No newline at end of file diff --git a/wadsrc/static/zscript/menu/reverbedit.txt b/wadsrc/static/zscript/menu/reverbedit.txt index 353db7339c..2f372968c6 100644 --- a/wadsrc/static/zscript/menu/reverbedit.txt +++ b/wadsrc/static/zscript/menu/reverbedit.txt @@ -6,6 +6,9 @@ class ReverbEdit : OptionMenu static native bool GrayCheck(); static native string, int GetSelectedEnvironment(); static native void FillSelectMenu(String ccmd, OptionMenuDescriptor desc); + static native void FillSaveMenu(OptionMenuDescriptor desc); + static native int GetSaveSelection(int num); + static native void ToggleSaveSelection(int num); override void Init(Menu parent, OptionMenuDescriptor desc) { @@ -64,6 +67,51 @@ class ReverbSelect : OptionMenu } } +class ReverbSave : OptionMenu +{ + //============================================================================= + // + // + // + //============================================================================= + + override void Init(Menu parent, OptionMenuDescriptor desc) + { + ReverbEdit.FillSaveMenu(desc); + super.Init(parent, desc); + } +} + +//============================================================================= +// +// Change a CVAR, command is the CVAR name +// +//============================================================================= + +class OptionMenuItemReverbSaveSelect : OptionMenuItemOptionBase +{ + int mValIndex; + + OptionMenuItemReverbSaveSelect Init(String label, int index, Name values) + { + Super.Init(label, 'None', values, null, 0); + mValIndex = index; + return self; + } + + //============================================================================= + override int GetSelection() + { + return ReverbEdit.GetSaveSelection(mValIndex); + } + + override void SetSelection(int Selection) + { + ReverbEdit.ToggleSaveSelection(mValIndex); + } +} + + //============================================================================= // // opens a submenu, command is a submenu name