zdoom/gzdoom
0
0
Fork 0
mirror of https://github.com/ZDoom/gzdoom.git synced 2024-11-25 13:31:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

change version, improve errors for array/map/struct copy

Browse source
This commit is contained in:
Ricardo Luís Vaz Silva 2023-10-07 11:44:44 -03:00 committed by Christoph Oelckers
parent b9104e8aa9
commit 42df40941c
1 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/common/scripting/backend/codegen.cpp
View file

@ -2489,7 +2489,7 @@ FxExpression *FxAssign::Resolve(FCompileContext &ctx)
if (btype->isDynArray())
{
if(ctx.Version >= MakeVersion(4, 11, 0))
if(ctx.Version >= MakeVersion(4, 11, 1))
{
FArgumentList args;
args.Push(Right);
@ -2502,12 +2502,14 @@ FxExpression *FxAssign::Resolve(FCompileContext &ctx)
{
if(Base->ValueType->isRealPointer() && Right->ValueType->isRealPointer())
{
ScriptPosition.Message(MSG_WARNING, "Dynamic Array assignments not allowed in ZScript versions below 4.11, use the Copy() or Move() functions instead\n"
TEXTCOLOR_RED "!! Assigning an out array pointer to another out array pointer does not alter either of the underlying arrays' values below ZScript version 4.11 !!");
ScriptPosition.Message(MSG_WARNING, "Dynamic Array assignments not allowed in ZScript versions below 4.11.1, use the Copy() or Move() functions instead\n"
TEXTCOLOR_RED " Assigning an out array pointer to another out array pointer\n"
" does not alter either of the underlying arrays' values\n"
" it only swaps the pointers below ZScript version 4.11.1!!");
}
else
{
ScriptPosition.Message(MSG_ERROR, "Dynamic Array assignments not allowed in ZScript versions below 4.11, use the Copy() or Move() functions instead");
ScriptPosition.Message(MSG_ERROR, "Dynamic Array assignments not allowed in ZScript versions below 4.11.1, use the Copy() or Move() functions instead");
delete this;
return nullptr;
}
@ -2515,7 +2517,7 @@ FxExpression *FxAssign::Resolve(FCompileContext &ctx)
}
else if (btype->isMap())
{
if(ctx.Version >= MakeVersion(4, 11, 0))
if(ctx.Version >= MakeVersion(4, 11, 1))
{
FArgumentList args;
args.Push(Right);
@ -2528,12 +2530,14 @@ FxExpression *FxAssign::Resolve(FCompileContext &ctx)
{
if(Base->ValueType->isRealPointer() && Right->ValueType->isRealPointer())
{ // don't break existing code, but warn that it's a no-op
ScriptPosition.Message(MSG_WARNING, "Map assignments not allowed in ZScript versions below 4.11, use the Copy() or Move() functions instead\n"
TEXTCOLOR_RED "!! Assigning an out map pointer to another out map pointer does not alter either of the underlying maps' values below ZScript version 4.11 !!");
ScriptPosition.Message(MSG_WARNING, "Map assignments not allowed in ZScript versions below 4.11.1, use the Copy() or Move() functions instead\n"
TEXTCOLOR_RED " Assigning an out map pointer to another out map pointer\n"
" does not alter either of the underlying maps' values\n"
" it only swaps the pointers below ZScript version 4.11.1!!");
}
else
{
ScriptPosition.Message(MSG_ERROR, "Map assignments not allowed in ZScript versions below 4.11, use the Copy() or Move() functions instead");
ScriptPosition.Message(MSG_ERROR, "Map assignments not allowed in ZScript versions below 4.11.1, use the Copy() or Move() functions instead");
delete this;
return nullptr;
}
@ -2550,7 +2554,9 @@ FxExpression *FxAssign::Resolve(FCompileContext &ctx)
if(Base->ValueType->isRealPointer() && Right->ValueType->isRealPointer())
{ // don't break existing code, but warn that it's a no-op
ScriptPosition.Message(MSG_WARNING, "Struct assignment not implemented yet\n"
TEXTCOLOR_RED "!! Assigning an out struct pointer to another out struct pointer does not alter either of the underlying structs' values !!");
TEXTCOLOR_RED " Assigning an out struct pointer to another out struct pointer\n"
" does not alter either of the underlying structs' values\n"
" it only swaps the pointers!!");
}
else
{