From 38fcfa5ba9d8970b8633d32ce48b73b341133bd6 Mon Sep 17 00:00:00 2001 From: Alexander Kromm Date: Wed, 30 Jun 2021 23:15:00 +0700 Subject: [PATCH] get rid of unnecessary string conversions in option menu shortcuts --- wadsrc/static/zscript/engine/ui/menu/optionmenu.zs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs b/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs index 47ec02069f..305dcddb42 100644 --- a/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs +++ b/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs @@ -203,7 +203,7 @@ class OptionMenu : Menu } else if (ev.type == UIEvent.Type_Char) { - String key = String.Format("%c", ev.keyChar).MakeLower(); + int key = String.CharLower(ev.keyChar); int itemsNumber = mDesc.mItems.Size(); int direction = ev.IsAlt ? -1 : 1; for (int i = 0; i < itemsNumber; ++i) @@ -211,7 +211,7 @@ class OptionMenu : Menu int index = (mDesc.mSelectedItem + direction * (i + 1) + itemsNumber) % itemsNumber; if (!mDesc.mItems[index].Selectable()) continue; String label = StringTable.Localize(mDesc.mItems[index].mLabel); - String firstLabelCharacter = String.Format("%c", label.GetNextCodePoint(0)).MakeLower(); + int firstLabelCharacter = String.CharLower(label.GetNextCodePoint(0)); if (firstLabelCharacter == key) { mDesc.mSelectedItem = index;