From 320fb9aec566196e92a094469ec2aea57262e3ee Mon Sep 17 00:00:00 2001
From: Randy Heit <rheit@users.noreply.github.com>
Date: Tue, 6 Jan 2015 19:44:20 -0600
Subject: [PATCH] Allow empty parameter lists for action functions without
 parameters

- Using A_Scream() in a state instead of A_Scream is now valid.
---
 src/thingdef/thingdef_states.cpp | 111 +++++++++++++++----------------
 1 file changed, 55 insertions(+), 56 deletions(-)

diff --git a/src/thingdef/thingdef_states.cpp b/src/thingdef/thingdef_states.cpp
index d1c1f8209c..26c4deddb6 100644
--- a/src/thingdef/thingdef_states.cpp
+++ b/src/thingdef/thingdef_states.cpp
@@ -391,6 +391,8 @@ void ParseFunctionParameters(FScanner &sc, PClassActor *cls, TArray<FxExpression
 	const TArray<DWORD> &paramflags = afd->Variants[0].ArgFlags;
 	int numparams = (int)params.Size();
 	int pnum = 0;
+	bool zeroparm;
+
 	if (afd->Flags & VARF_Method)
 	{
 		numparams--;
@@ -401,83 +403,80 @@ void ParseFunctionParameters(FScanner &sc, PClassActor *cls, TArray<FxExpression
 		numparams -= 2;
 		pnum += 2;
 	}
-	if (numparams > 0)
+	assert(numparams >= 0);
+	zeroparm = numparams == 0;
+	if (numparams > 0 && !(paramflags[pnum] & VARF_Optional))
 	{
-		int v;
-
-		if (!(paramflags[pnum] & VARF_Optional))
+		sc.MustGetStringName("(");
+	}
+	else
+	{
+		if (!sc.CheckString("(")) 
 		{
-			sc.MustGetStringName("(");
+			return;
 		}
-		else
+	}
+	while (numparams > 0)
+	{
+		FxExpression *x;
+		if (statedef != NULL && params[pnum] == TypeState && sc.CheckNumber())
 		{
-			if (!sc.CheckString("(")) 
+			// Special case: State label as an offset
+			if (sc.Number > 0 && statestring.Len() > 1)
 			{
-				return;
+				sc.ScriptError("You cannot use state jumps commands with a jump offset on multistate definitions\n");
 			}
-		}
-		
-		while (numparams > 0)
-		{
-			FxExpression *x;
-			if (statedef != NULL && params[pnum] == TypeState && sc.CheckNumber())
+
+			int v = sc.Number;
+			if (v < 0)
 			{
-				// Special case: State label as an offset
-				if (sc.Number > 0 && statestring.Len() > 1)
-				{
-					sc.ScriptError("You cannot use state jumps commands with a jump offset on multistate definitions\n");
-				}
+				sc.ScriptError("Negative jump offsets are not allowed");
+			}
 
-				v = sc.Number;
-				if (v<0)
-				{
-					sc.ScriptError("Negative jump offsets are not allowed");
-				}
-
-				if (v > 0)
-				{
-					x = new FxStateByIndex(statedef->GetStateCount() + v, sc);
-				}
-				else
-				{
-					x = new FxConstant((FState*)NULL, sc);
-				}
+			if (v > 0)
+			{
+				x = new FxStateByIndex(statedef->GetStateCount() + v, sc);
 			}
 			else
 			{
-				// Use the generic parameter parser for everything else
-				x = ParseParameter(sc, cls, params[pnum], false);
+				x = new FxConstant((FState*)NULL, sc);
 			}
-			out_params.Push(new FxParameter(x));
-			pnum++;
-			numparams--;
-			if (numparams > 0)
-			{
-				if (params[pnum] == NULL)
-				{ // varargs function
-					if (sc.CheckString(")"))
-					{
-						return;
-					}
-					pnum--;
-					numparams++;
-				}
-				else if ((paramflags[pnum] & VARF_Optional) && sc.CheckString(")"))
+		}
+		else
+		{
+			// Use the generic parameter parser for everything else
+			x = ParseParameter(sc, cls, params[pnum], false);
+		}
+		out_params.Push(new FxParameter(x));
+		pnum++;
+		numparams--;
+		if (numparams > 0)
+		{
+			if (params[pnum] == NULL)
+			{ // varargs function
+				if (sc.CheckString(")"))
 				{
 					return;
 				}
-				sc.MustGetStringName (",");
+				pnum--;
+				numparams++;
 			}
+			else if ((paramflags[pnum] & VARF_Optional) && sc.CheckString(")"))
+			{
+				return;
+			}
+			sc.MustGetStringName (",");
 		}
-		sc.MustGetStringName(")");
 	}
-	else 
+	if (zeroparm)
 	{
-		sc.MustGetString();
-		if (sc.Compare("("))
+		if (!sc.CheckString(")"))
 		{
 			sc.ScriptError("You cannot pass parameters to '%s'\n", afd->SymbolName.GetChars());
 		}
-		sc.UnGet();
+	}
+	else
+	{
+		sc.MustGetStringName(")");
 	}
 }