From b5b9baaa87a621e8236e8645890e3ba3651768b8 Mon Sep 17 00:00:00 2001 From: Leonard2 Date: Wed, 14 Sep 2016 13:56:58 +0200 Subject: [PATCH 01/27] The VM now aborts when a wrong self pointer is used with user variables to avoid random crashes --- src/thingdef/thingdef_expression.cpp | 13 +++++++++++++ src/zscript/vm.h | 1 + src/zscript/vmdisasm.cpp | 13 ++++++++++++- src/zscript/vmexec.h | 6 +++++- src/zscript/vmframe.cpp | 4 ++++ src/zscript/vmops.h | 3 ++- 6 files changed, 37 insertions(+), 3 deletions(-) diff --git a/src/thingdef/thingdef_expression.cpp b/src/thingdef/thingdef_expression.cpp index ce603f2617..695b127996 100644 --- a/src/thingdef/thingdef_expression.cpp +++ b/src/thingdef/thingdef_expression.cpp @@ -3373,6 +3373,19 @@ FxExpression *FxClassMember::Resolve(FCompileContext &ctx) ExpEmit FxClassMember::Emit(VMFunctionBuilder *build) { + if (~membervar->Flags & VARF_Native) + { // Check if this is a user-defined variable. + // As of right now, FxClassMember is only ever used with FxSelf. + // This very user variable was defined in stateowner so if + // self (a0) != stateowner (a1) then the offset is most likely + // going to end up being totally wrong even if the variable was + // redefined in self which means we have to abort to avoid reading + // or writing to a random address and possibly crash. + build->Emit(OP_EQA_R, 1, 0, 1); + build->Emit(OP_JMP, 1); + build->Emit(OP_THROW, 2, X_BAD_SELF); + } + ExpEmit obj = classx->Emit(build); assert(obj.RegType == REGT_POINTER); diff --git a/src/zscript/vm.h b/src/zscript/vm.h index 0d45ad90a3..a000e9533f 100644 --- a/src/zscript/vm.h +++ b/src/zscript/vm.h @@ -163,6 +163,7 @@ enum EVMAbortException X_TOO_MANY_TRIES, X_ARRAY_OUT_OF_BOUNDS, X_DIVISION_BY_ZERO, + X_BAD_SELF, }; class VMFunction : public DObject diff --git a/src/zscript/vmdisasm.cpp b/src/zscript/vmdisasm.cpp index 35eb6085df..4e6f33ec75 100644 --- a/src/zscript/vmdisasm.cpp +++ b/src/zscript/vmdisasm.cpp @@ -371,7 +371,18 @@ void VMDisasm(FILE *out, const VMOP *code, int codesize, const VMScriptFunction col = print_reg(out, 0, a, (mode & MODE_ATYPE) >> MODE_ASHIFT, 24, func); if ((mode & MODE_BCTYPE) == MODE_BCTHROW) { - mode = (code[i].a == 0) ? (MODE_BP | MODE_CUNUSED) : (MODE_BKP | MODE_CUNUSED); + if (code[i].a == 0) + { + mode = (MODE_BP | MODE_CUNUSED); + } + else if (code[i].a == 1) + { + mode = (MODE_BKP | MODE_CUNUSED); + } + else + { + mode = (MODE_BCJOINT | MODE_BCIMMS); + } } else if ((mode & MODE_BCTYPE) == MODE_BCCATCH) { diff --git a/src/zscript/vmexec.h b/src/zscript/vmexec.h index 42a3740301..adf2986c50 100644 --- a/src/zscript/vmexec.h +++ b/src/zscript/vmexec.h @@ -616,12 +616,16 @@ begin: ASSERTA(B); throw((VMException *)reg.a[B]); } - else + else if (a == 1) { ASSERTKA(B); assert(konstatag[B] == ATAG_OBJECT); throw((VMException *)konsta[B].o); } + else + { + THROW(BC); + } NEXTOP; OP(CATCH): // This instruction is handled by our own catch handler and should diff --git a/src/zscript/vmframe.cpp b/src/zscript/vmframe.cpp index 29da0c5b91..50c7d78d9e 100644 --- a/src/zscript/vmframe.cpp +++ b/src/zscript/vmframe.cpp @@ -440,6 +440,10 @@ int VMFrameStack::Call(VMFunction *func, VMValue *params, int numparams, VMRetur case X_DIVISION_BY_ZERO: Printf("division by zero."); break; + + case X_BAD_SELF: + Printf("invalid self pointer."); + break; } Printf("\n"); diff --git a/src/zscript/vmops.h b/src/zscript/vmops.h index decb0b93d1..39d224f5c9 100644 --- a/src/zscript/vmops.h +++ b/src/zscript/vmops.h @@ -83,7 +83,8 @@ xx(RETI, reti, I8I16), // Copy immediate from BC to return value A, possibly re xx(TRY, try, I24), // When an exception is thrown, start searching for a handler at pc + ABC xx(UNTRY, untry, I8), // Pop A entries off the exception stack xx(THROW, throw, THROW), // A == 0: Throw exception object pB - // A != 0: Throw exception object pkB + // A == 1: Throw exception object pkB + // A >= 2: Throw VM exception of type BC xx(CATCH, catch, CATCH), // A == 0: continue search on next try // A == 1: continue execution at instruction immediately following CATCH (catches any exception) // A == 2: (pB == ) then pc++ ; next instruction must JMP to another CATCH From 780d672b255022562f4ac12b94c5aac720c8f6a9 Mon Sep 17 00:00:00 2001 From: raa-eruanna Date: Fri, 16 Sep 2016 03:01:52 -0400 Subject: [PATCH 02/27] Adds user-definable weapon bob speed --- src/d_netinfo.cpp | 2 ++ src/d_player.h | 4 ++++ src/namedef.h | 1 + src/p_pspr.cpp | 6 +++++- wadsrc/static/language.enu | 1 + wadsrc/static/menudef.txt | 1 + 6 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/d_netinfo.cpp b/src/d_netinfo.cpp index 0b99fd73d4..3504c58744 100644 --- a/src/d_netinfo.cpp +++ b/src/d_netinfo.cpp @@ -70,6 +70,7 @@ CVAR (String, gender, "male", CVAR_USERINFO | CVAR_ARCHIVE); CVAR (Bool, neverswitchonpickup, false, CVAR_USERINFO | CVAR_ARCHIVE); CVAR (Float, movebob, 0.25f, CVAR_USERINFO | CVAR_ARCHIVE); CVAR (Float, stillbob, 0.f, CVAR_USERINFO | CVAR_ARCHIVE); +CVAR (Float, wbobspeed, 1.f, CVAR_USERINFO | CVAR_ARCHIVE); CVAR (String, playerclass, "Fighter", CVAR_USERINFO | CVAR_ARCHIVE); enum @@ -83,6 +84,7 @@ enum INFO_NeverSwitchOnPickup, INFO_MoveBob, INFO_StillBob, + INFO_WBobSpeed, INFO_PlayerClass, INFO_ColorSet, }; diff --git a/src/d_player.h b/src/d_player.h index e932223aaa..6f68aa6f70 100644 --- a/src/d_player.h +++ b/src/d_player.h @@ -337,6 +337,10 @@ struct userinfo_t : TMap { return *static_cast(*CheckKey(NAME_StillBob)); } + double GetWBobSpeed() const + { + return *static_cast(*CheckKey(NAME_WBobSpeed)); + } int GetPlayerClassNum() const { return *static_cast(*CheckKey(NAME_PlayerClass)); diff --git a/src/namedef.h b/src/namedef.h index e5b6c452a7..f1279d27cc 100644 --- a/src/namedef.h +++ b/src/namedef.h @@ -644,6 +644,7 @@ xx(ColorSet) xx(NeverSwitchOnPickup) xx(MoveBob) xx(StillBob) +xx(WBobSpeed) xx(PlayerClass) xx(Wi_NoAutostartMap) diff --git a/src/p_pspr.cpp b/src/p_pspr.cpp index 9f12336096..4274d81a8b 100644 --- a/src/p_pspr.cpp +++ b/src/p_pspr.cpp @@ -524,9 +524,13 @@ void P_DropWeapon (player_t *player) // A_WeaponReady every tic, and it looks bad if they don't bob smoothly. // // [XA] Added new bob styles and exposed bob properties. Thanks, Ryan Cordell! +// [SP] Added new user option for bob speed // //============================================================================ +// [SP] Changes how quickly the weapon bobs +EXTERN_CVAR(Float, wbobspeed) + void P_BobWeapon (player_t *player, float *x, float *y, double ticfrac) { static float curbob; @@ -552,7 +556,7 @@ void P_BobWeapon (player_t *player, float *x, float *y, double ticfrac) for (int i = 0; i < 2; i++) { // Bob the weapon based on movement speed. - FAngle angle = (BobSpeed * 35 / TICRATE*(level.time - 1 + i)) * (360.f / 8192.f); + FAngle angle = (BobSpeed * wbobspeed * 35 / TICRATE*(level.time - 1 + i)) * (360.f / 8192.f); // [RH] Smooth transitions between bobbing and not-bobbing frames. // This also fixes the bug where you can "stick" a weapon off-center by diff --git a/wadsrc/static/language.enu b/wadsrc/static/language.enu index e91c9dd434..4839e1146f 100644 --- a/wadsrc/static/language.enu +++ b/wadsrc/static/language.enu @@ -1802,6 +1802,7 @@ DSPLYMNU_MENUDIM = "Menu dim"; DSPLYMNU_DIMCOLOR = "Dim color"; DSPLYMNU_MOVEBOB = "View bob amount while moving"; DSPLYMNU_STILLBOB = "View bob amount while not moving"; +DSPLYMNU_BOBSPEED = "Weapon bob speed"; // HUD Options HUDMNU_TITLE = "HUD Options"; diff --git a/wadsrc/static/menudef.txt b/wadsrc/static/menudef.txt index a605b5cc46..0bcbd3af7c 100644 --- a/wadsrc/static/menudef.txt +++ b/wadsrc/static/menudef.txt @@ -690,6 +690,7 @@ OptionMenu "VideoOptions" ColorPicker "$DSPLYMNU_DIMCOLOR", "dimcolor" Slider "$DSPLYMNU_MOVEBOB", "movebob", 0, 1.0, 0.05, 2 Slider "$DSPLYMNU_STILLBOB", "stillbob", 0, 1.0, 0.05, 2 + Slider "$DSPLYMNU_BOBSPEED", "wbobspeed", 0, 2.0, 0.1, 2 } //------------------------------------------------------------------------------------------- From bc0624e3b2c8c8993a120e1d17d82dd117742fce Mon Sep 17 00:00:00 2001 From: raa-eruanna Date: Fri, 16 Sep 2016 03:48:09 -0400 Subject: [PATCH 03/27] Fixed my error where I was using a local session variable rather than the proper user info for the weapon bob speed. --- src/d_player.h | 2 +- src/p_pspr.cpp | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/d_player.h b/src/d_player.h index 6f68aa6f70..5206fd7708 100644 --- a/src/d_player.h +++ b/src/d_player.h @@ -337,7 +337,7 @@ struct userinfo_t : TMap { return *static_cast(*CheckKey(NAME_StillBob)); } - double GetWBobSpeed() const + float GetWBobSpeed() const { return *static_cast(*CheckKey(NAME_WBobSpeed)); } diff --git a/src/p_pspr.cpp b/src/p_pspr.cpp index 4274d81a8b..099a39f020 100644 --- a/src/p_pspr.cpp +++ b/src/p_pspr.cpp @@ -528,9 +528,6 @@ void P_DropWeapon (player_t *player) // //============================================================================ -// [SP] Changes how quickly the weapon bobs -EXTERN_CVAR(Float, wbobspeed) - void P_BobWeapon (player_t *player, float *x, float *y, double ticfrac) { static float curbob; @@ -555,8 +552,9 @@ void P_BobWeapon (player_t *player, float *x, float *y, double ticfrac) for (int i = 0; i < 2; i++) { - // Bob the weapon based on movement speed. - FAngle angle = (BobSpeed * wbobspeed * 35 / TICRATE*(level.time - 1 + i)) * (360.f / 8192.f); + // Bob the weapon based on movement speed. ([SP] And user's bob speed setting) + FAngle angle = (BobSpeed * player->userinfo.GetWBobSpeed() * 35 / + TICRATE*(level.time - 1 + i)) * (360.f / 8192.f); // [RH] Smooth transitions between bobbing and not-bobbing frames. // This also fixes the bug where you can "stick" a weapon off-center by From 4f7e1f01717a4c3e1d7092c6e28a8aedb7303641 Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Sat, 17 Sep 2016 16:53:19 +0300 Subject: [PATCH 04/27] FluisSynth dynamic library is now referenced by system specific name on macOS --- src/sound/music_fluidsynth_mididevice.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/sound/music_fluidsynth_mididevice.cpp b/src/sound/music_fluidsynth_mididevice.cpp index b3f7b7d458..9777494fdb 100644 --- a/src/sound/music_fluidsynth_mididevice.cpp +++ b/src/sound/music_fluidsynth_mididevice.cpp @@ -59,7 +59,11 @@ #else #include +#ifdef __APPLE__ +#define FLUIDSYNTHLIB "libfluidsynth.1.dylib" +#else // !__APPLE__ #define FLUIDSYNTHLIB "libfluidsynth.so.1" +#endif // __APPLE__ #endif #define FLUID_REVERB_DEFAULT_ROOMSIZE 0.2f From 0a24c1544517a052c00da0c76107d90b008454fe Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Sat, 17 Sep 2016 16:54:02 +0300 Subject: [PATCH 05/27] Added ability to customize path to FluidSynth dynamic library Use fluid_lib CVAR to set path or default name of dynamic library will be used instead --- src/sound/music_fluidsynth_mididevice.cpp | 54 ++++++++++++++++++----- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/src/sound/music_fluidsynth_mididevice.cpp b/src/sound/music_fluidsynth_mididevice.cpp index 9777494fdb..fd0bab645f 100644 --- a/src/sound/music_fluidsynth_mididevice.cpp +++ b/src/sound/music_fluidsynth_mididevice.cpp @@ -96,6 +96,8 @@ // PUBLIC DATA DEFINITIONS ------------------------------------------------- +CVAR(String, fluid_lib, "", CVAR_ARCHIVE|CVAR_GLOBALCONFIG) + CVAR(String, fluid_patchset, "", CVAR_ARCHIVE|CVAR_GLOBALCONFIG) CUSTOM_CVAR(Float, fluid_gain, 0.5, CVAR_ARCHIVE|CVAR_GLOBALCONFIG) @@ -693,22 +695,54 @@ bool FluidSynthMIDIDevice::LoadFluidSynth() const char *libname; #ifdef _WIN32 - FluidSynthDLL = LoadLibrary((libname = FLUIDSYNTHLIB1)); - if (FluidSynthDLL == NULL) + if (strlen(fluid_lib) > 0) { - FluidSynthDLL = LoadLibrary((libname = FLUIDSYNTHLIB2)); - if (FluidSynthDLL == NULL) + FluidSynthDLL = LoadLibrary(libname = fluid_lib); + if (nullptr == FluidSynthDLL) { - Printf(TEXTCOLOR_RED"Could not load " FLUIDSYNTHLIB1 " or " FLUIDSYNTHLIB2 "\n"); - return false; + Printf(TEXTCOLOR_RED "Could not load %s\n", libname); + } + } + else + { + FluidSynthDLL = nullptr; + } + + if (nullptr == FluidSynthDLL) + { + FluidSynthDLL = LoadLibrary(libname = FLUIDSYNTHLIB1); + if (nullptr == FluidSynthDLL) + { + FluidSynthDLL = LoadLibrary(libname = FLUIDSYNTHLIB2); + if (nullptr == FluidSynthDLL) + { + Printf(TEXTCOLOR_RED "Could not load " FLUIDSYNTHLIB1 " or " FLUIDSYNTHLIB2 "\n"); + return false; + } } } #else - FluidSynthSO = dlopen((libname = FLUIDSYNTHLIB), RTLD_LAZY); - if (FluidSynthSO == NULL) + if (strlen(fluid_lib) > 0) { - Printf(TEXTCOLOR_RED"Could not load " FLUIDSYNTHLIB ": %s\n", dlerror()); - return false; + FluidSynthSO = dlopen(libname = fluid_lib, RTLD_LAZY); + if (nullptr == FluidSynthSO) + { + Printf(TEXTCOLOR_RED "Could not load %s: %s\n", libname, dlerror()); + } + } + else + { + FluidSynthSO = nullptr; + } + + if (nullptr == FluidSynthSO) + { + FluidSynthSO = dlopen(libname = FLUIDSYNTHLIB, RTLD_LAZY); + if (nullptr == FluidSynthSO) + { + Printf(TEXTCOLOR_RED "Could not load " FLUIDSYNTHLIB ": %s\n", dlerror()); + return false; + } } #endif From 76c5ff29febf7c866da693559b40f7c4db9fb147 Mon Sep 17 00:00:00 2001 From: raa-eruanna Date: Sun, 18 Sep 2016 02:26:03 -0400 Subject: [PATCH 06/27] If Inventory.MaxAmount > 1 on weapons, allow and track multiple pickups. --- src/g_shared/a_weapons.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/g_shared/a_weapons.cpp b/src/g_shared/a_weapons.cpp index 575914fe8d..6143f52066 100644 --- a/src/g_shared/a_weapons.cpp +++ b/src/g_shared/a_weapons.cpp @@ -222,6 +222,10 @@ bool AWeapon::HandlePickup (AInventory *item) { item->ItemFlags |= IF_PICKUPGOOD; } + if (MaxAmount > 1) //[SP] If amount Date: Mon, 19 Sep 2016 10:49:38 -0500 Subject: [PATCH 07/27] Removed the positive-only ripper level requirement. - Several mods were able to just take advantage of A_SetRipperLevel and the likes, essentially bypassing this gate so there really is no point in doing this anymore. --- src/thingdef/thingdef_properties.cpp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/thingdef/thingdef_properties.cpp b/src/thingdef/thingdef_properties.cpp index 52194435b4..3cb424ea32 100644 --- a/src/thingdef/thingdef_properties.cpp +++ b/src/thingdef/thingdef_properties.cpp @@ -1576,10 +1576,6 @@ DEFINE_PROPERTY(telefogdesttype, S, Actor) DEFINE_PROPERTY(ripperlevel, I, Actor) { PROP_INT_PARM(id, 0); - if (id < 0) - { - I_Error ("RipperLevel must not be negative"); - } defaults->RipperLevel = id; } @@ -1589,10 +1585,6 @@ DEFINE_PROPERTY(ripperlevel, I, Actor) DEFINE_PROPERTY(riplevelmin, I, Actor) { PROP_INT_PARM(id, 0); - if (id < 0) - { - I_Error ("RipLevelMin must not be negative"); - } defaults->RipLevelMin = id; } @@ -1602,10 +1594,6 @@ DEFINE_PROPERTY(riplevelmin, I, Actor) DEFINE_PROPERTY(riplevelmax, I, Actor) { PROP_INT_PARM(id, 0); - if (id < 0) - { - I_Error ("RipLevelMax must not be negative"); - } defaults->RipLevelMax = id; } From 2d55f713c22c070f0a0d4a0ca41540fab51a4b5a Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Mon, 19 Sep 2016 22:54:41 +0300 Subject: [PATCH 08/27] Fixed support for automatic graphics switching on macOS The corresponding setting in .plist is wrong but Xcode fixes it automatically This doesn't happen however when building via makefiles --- src/posix/osx/zdoom-info.plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/posix/osx/zdoom-info.plist b/src/posix/osx/zdoom-info.plist index 73be09aa8f..e2f8965607 100644 --- a/src/posix/osx/zdoom-info.plist +++ b/src/posix/osx/zdoom-info.plist @@ -44,6 +44,6 @@ NSPrincipalClass NSApplication NSSupportsAutomaticGraphicsSwitching - YES + From 715aa80cf2da39c74d4066438a9be09696d35a7d Mon Sep 17 00:00:00 2001 From: LordMisfit Date: Tue, 20 Sep 2016 14:32:40 -0400 Subject: [PATCH 09/27] - Fix for DamageFactor bug w/ PowerDamage & PowerProtection --- src/g_shared/a_artifacts.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/g_shared/a_artifacts.cpp b/src/g_shared/a_artifacts.cpp index b5ac970ca3..72ad84c2d9 100644 --- a/src/g_shared/a_artifacts.cpp +++ b/src/g_shared/a_artifacts.cpp @@ -1668,7 +1668,7 @@ void APowerDamage::ModifyDamage(int damage, FName damageType, int &newdamage, bo newdam = damage * 4; } if (Owner != NULL && newdam > damage) S_Sound(Owner, 5, ActiveSound, 1.0f, ATTN_NONE); - newdamage = newdam; + newdamage = damage = newdam; } if (Inventory != NULL) Inventory->ModifyDamage(damage, damageType, newdamage, passive); } @@ -1743,7 +1743,7 @@ void APowerProtection::ModifyDamage(int damage, FName damageType, int &newdamage newdam = damage / 4; } if (Owner != NULL && newdam < damage) S_Sound(Owner, CHAN_AUTO, ActiveSound, 1.0f, ATTN_NONE); - newdamage = newdam; + newdamage = damage = newdam; } if (Inventory != NULL) { From a49e15c5416fae67ed7908e1507acf5c63a38c4b Mon Sep 17 00:00:00 2001 From: nashmuhandes Date: Mon, 29 Aug 2016 22:45:28 +0800 Subject: [PATCH 10/27] Added REOPEN script type. These scripts behave just like OPEN scripts, except they will re-execute themselves every time the level is re-entered (ie as part of a hub). --- src/g_level.cpp | 3 +++ src/p_acs.cpp | 3 ++- src/p_acs.h | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/g_level.cpp b/src/g_level.cpp index 60e9b06990..fadfd9245a 100644 --- a/src/g_level.cpp +++ b/src/g_level.cpp @@ -1291,6 +1291,9 @@ void G_FinishTravel () if (level.FromSnapshot) { FBehavior::StaticStartTypedScripts (SCRIPT_Return, pawn, true); + + // [Nash] run REOPEN scripts upon map re-entry + FBehavior::StaticStartTypedScripts(SCRIPT_Reopen, NULL, false); } } diff --git a/src/p_acs.cpp b/src/p_acs.cpp index ffac7a78f1..c85cc65d6b 100644 --- a/src/p_acs.cpp +++ b/src/p_acs.cpp @@ -2822,7 +2822,8 @@ void FBehavior::StaticStartTypedScripts (WORD type, AActor *activator, bool alwa "Lightning", "Unloading", "Disconnect", - "Return" + "Return", + "Reopen" }; DPrintf(DMSG_NOTIFY, "Starting all scripts of type %d (%s)\n", type, type < countof(TypeNames) ? TypeNames[type] : TypeNames[SCRIPT_Lightning - 1]); diff --git a/src/p_acs.h b/src/p_acs.h index 243e2ccf39..d26829c616 100644 --- a/src/p_acs.h +++ b/src/p_acs.h @@ -272,6 +272,7 @@ enum SCRIPT_Return = 15, SCRIPT_Event = 16, // [BB] SCRIPT_Kill = 17, // [JM] + SCRIPT_Reopen = 18, // [Nash] }; // Script flags From 146b5d2d066e06b255fa0095da1dafe25f0ac695 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Thu, 22 Sep 2016 09:06:21 +0200 Subject: [PATCH 11/27] - use 'override' qualifier on renderer interface. Bad things can happen if these get changed in ZDoom without adapting to the change so better let the compiler handle this automatically. --- src/gl/scene/gl_scene.cpp | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/gl/scene/gl_scene.cpp b/src/gl/scene/gl_scene.cpp index ccceeac5fe..cca4528008 100644 --- a/src/gl/scene/gl_scene.cpp +++ b/src/gl/scene/gl_scene.cpp @@ -979,25 +979,25 @@ void FGLRenderer::WriteSavePic (player_t *player, FILE *file, int width, int hei struct FGLInterface : public FRenderer { - bool UsesColormap() const; + bool UsesColormap() const override; void PrecacheTexture(FTexture *tex, int cache); void PrecacheSprite(FTexture *tex, SpriteHits &hits); - void Precache(BYTE *texhitlist, TMap &actorhitlist); - void RenderView(player_t *player); - void WriteSavePic (player_t *player, FILE *file, int width, int height); - void StateChanged(AActor *actor); - void StartSerialize(FArchive &arc); - void EndSerialize(FArchive &arc); - void RenderTextureView (FCanvasTexture *self, AActor *viewpoint, int fov); - sector_t *FakeFlat(sector_t *sec, sector_t *tempsec, int *floorlightlevel, int *ceilinglightlevel, bool back); - void SetFogParams(int _fogdensity, PalEntry _outsidefogcolor, int _outsidefogdensity, int _skyfog); - void PreprocessLevel(); - void CleanLevelData(); - bool RequireGLNodes(); + void Precache(BYTE *texhitlist, TMap &actorhitlist) override; + void RenderView(player_t *player) override; + void WriteSavePic (player_t *player, FILE *file, int width, int height) override; + void StateChanged(AActor *actor) override; + void StartSerialize(FArchive &arc) override; + void EndSerialize(FArchive &arc) override; + void RenderTextureView (FCanvasTexture *self, AActor *viewpoint, int fov) override; + sector_t *FakeFlat(sector_t *sec, sector_t *tempsec, int *floorlightlevel, int *ceilinglightlevel, bool back) override; + void SetFogParams(int _fogdensity, PalEntry _outsidefogcolor, int _outsidefogdensity, int _skyfog) override; + void PreprocessLevel() override; + void CleanLevelData() override; + bool RequireGLNodes() override; - int GetMaxViewPitch(bool down); - void ClearBuffer(int color); - void Init(); + int GetMaxViewPitch(bool down) override; + void ClearBuffer(int color) override; + void Init() override; }; //=========================================================================== From f7b6b1433cf688cefa7a9bd9c05167d04a8e039a Mon Sep 17 00:00:00 2001 From: Magnus Norddahl Date: Sun, 18 Sep 2016 15:57:22 +0200 Subject: [PATCH 12/27] Added exposure pass calculating the bloom/tonemap exposure based on what the eye is seeing --- src/gl/renderer/gl_postprocess.cpp | 90 ++++++++++++++++++- src/gl/renderer/gl_postprocessstate.cpp | 26 +++++- src/gl/renderer/gl_postprocessstate.h | 5 +- src/gl/renderer/gl_renderbuffers.cpp | 66 ++++++++++++-- src/gl/renderer/gl_renderbuffers.h | 22 ++++- src/gl/renderer/gl_renderer.cpp | 9 ++ src/gl/renderer/gl_renderer.h | 8 +- src/gl/scene/gl_scene.cpp | 15 +--- src/gl/shaders/gl_bloomshader.cpp | 2 +- src/gl/shaders/gl_bloomshader.h | 2 +- src/gl/shaders/gl_tonemapshader.cpp | 50 ++++++++++- src/gl/shaders/gl_tonemapshader.h | 41 ++++++++- wadsrc/static/shaders/glsl/bloomextract.fp | 5 +- wadsrc/static/shaders/glsl/exposureaverage.fp | 23 +++++ wadsrc/static/shaders/glsl/exposurecombine.fp | 16 ++++ wadsrc/static/shaders/glsl/exposureextract.fp | 13 +++ wadsrc/static/shaders/glsl/tonemap.fp | 5 +- 17 files changed, 358 insertions(+), 40 deletions(-) create mode 100644 wadsrc/static/shaders/glsl/exposureaverage.fp create mode 100644 wadsrc/static/shaders/glsl/exposurecombine.fp create mode 100644 wadsrc/static/shaders/glsl/exposureextract.fp diff --git a/src/gl/renderer/gl_postprocess.cpp b/src/gl/renderer/gl_postprocess.cpp index b6b658a415..1cdad9f9be 100644 --- a/src/gl/renderer/gl_postprocess.cpp +++ b/src/gl/renderer/gl_postprocess.cpp @@ -75,7 +75,10 @@ CUSTOM_CVAR(Float, gl_bloom_amount, 1.4f, 0) if (self < 0.1f) self = 0.1f; } -CVAR(Float, gl_exposure, 0.0f, 0) +CVAR(Float, gl_exposure_scale, 0.75f, 0) +CVAR(Float, gl_exposure_min, 0.35f, 0) +CVAR(Float, gl_exposure_base, 0.35f, 0) +CVAR(Float, gl_exposure_speed, 0.05f, 0) CUSTOM_CVAR(Int, gl_tonemap, 0, CVAR_ARCHIVE|CVAR_GLOBALCONFIG) { @@ -106,6 +109,78 @@ void FGLRenderer::RenderScreenQuad() GLRenderer->mVBO->RenderArray(GL_TRIANGLE_STRIP, FFlatVertexBuffer::PRESENT_INDEX, 4); } +//----------------------------------------------------------------------------- +// +// Extracts light average from the scene and updates the camera exposure texture +// +//----------------------------------------------------------------------------- + +void FGLRenderer::UpdateCameraExposure() +{ + if (!gl_bloom && gl_tonemap == 0) + return; + + FGLDebug::PushGroup("UpdateCameraExposure"); + + FGLPostProcessState savedState; + savedState.SaveTextureBinding1(); + + // Extract light level from scene texture: + const auto &level0 = mBuffers->ExposureLevels[0]; + glBindFramebuffer(GL_FRAMEBUFFER, level0.Framebuffer); + glViewport(0, 0, level0.Width, level0.Height); + mBuffers->BindCurrentTexture(0); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); + mExposureExtractShader->Bind(); + mExposureExtractShader->SceneTexture.Set(0); + mExposureExtractShader->Scale.Set(mSceneViewport.width / (float)mScreenViewport.width, mSceneViewport.height / (float)mScreenViewport.height); + mExposureExtractShader->Offset.Set(mSceneViewport.left / (float)mScreenViewport.width, mSceneViewport.top / (float)mScreenViewport.height); + RenderScreenQuad(); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); + + // Find the average value: + for (int i = 0; i + 1 < mBuffers->ExposureLevels.Size(); i++) + { + const auto &level = mBuffers->ExposureLevels[i]; + const auto &next = mBuffers->ExposureLevels[i + 1]; + + glBindFramebuffer(GL_FRAMEBUFFER, next.Framebuffer); + glViewport(0, 0, next.Width, next.Height); + glBindTexture(GL_TEXTURE_2D, level.Texture); + mExposureAverageShader->Bind(); + mExposureAverageShader->ExposureTexture.Set(0); + RenderScreenQuad(); + } + + // Combine average value with current camera exposure: + glBindFramebuffer(GL_FRAMEBUFFER, mBuffers->ExposureFB); + glViewport(0, 0, 1, 1); + if (!mBuffers->FirstExposureFrame) + { + glEnable(GL_BLEND); + glBlendEquation(GL_FUNC_ADD); + glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); + } + else + { + mBuffers->FirstExposureFrame = false; + } + glActiveTexture(GL_TEXTURE0); + glBindTexture(GL_TEXTURE_2D, mBuffers->ExposureLevels.Last().Texture); + mExposureCombineShader->Bind(); + mExposureCombineShader->ExposureTexture.Set(0); + mExposureCombineShader->ExposureBase.Set(gl_exposure_base); + mExposureCombineShader->ExposureMin.Set(gl_exposure_min); + mExposureCombineShader->ExposureScale.Set(gl_exposure_scale); + mExposureCombineShader->ExposureSpeed.Set(gl_exposure_speed); + RenderScreenQuad(); + glViewport(mScreenViewport.left, mScreenViewport.top, mScreenViewport.width, mScreenViewport.height); + + FGLDebug::PopGroup(); +} + //----------------------------------------------------------------------------- // // Adds bloom contribution to scene texture @@ -121,6 +196,7 @@ void FGLRenderer::BloomScene() FGLDebug::PushGroup("BloomScene"); FGLPostProcessState savedState; + savedState.SaveTextureBinding1(); const float blurAmount = gl_bloom_amount; int sampleCount = gl_bloom_kernel_size; @@ -133,9 +209,12 @@ void FGLRenderer::BloomScene() mBuffers->BindCurrentTexture(0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); + glActiveTexture(GL_TEXTURE1); + glBindTexture(GL_TEXTURE_2D, mBuffers->ExposureTexture); + glActiveTexture(GL_TEXTURE0); mBloomExtractShader->Bind(); mBloomExtractShader->SceneTexture.Set(0); - mBloomExtractShader->Exposure.Set(mCameraExposure); + mBloomExtractShader->ExposureTexture.Set(1); mBloomExtractShader->Scale.Set(mSceneViewport.width / (float)mScreenViewport.width, mSceneViewport.height / (float)mScreenViewport.height); mBloomExtractShader->Offset.Set(mSceneViewport.left / (float)mScreenViewport.width, mSceneViewport.top / (float)mScreenViewport.height); RenderScreenQuad(); @@ -220,7 +299,12 @@ void FGLRenderer::TonemapScene() } else { - mTonemapShader->Exposure.Set(mCameraExposure); + savedState.SaveTextureBinding1(); + glActiveTexture(GL_TEXTURE1); + glBindTexture(GL_TEXTURE_2D, mBuffers->ExposureTexture); + glActiveTexture(GL_TEXTURE0); + + mTonemapShader->ExposureTexture.Set(1); } RenderScreenQuad(); diff --git a/src/gl/renderer/gl_postprocessstate.cpp b/src/gl/renderer/gl_postprocessstate.cpp index 9d995783d4..57b7862f5d 100644 --- a/src/gl/renderer/gl_postprocessstate.cpp +++ b/src/gl/renderer/gl_postprocessstate.cpp @@ -45,7 +45,7 @@ FGLPostProcessState::FGLPostProcessState() { glGetIntegerv(GL_ACTIVE_TEXTURE, &activeTex); glActiveTexture(GL_TEXTURE0); - glGetIntegerv(GL_TEXTURE_BINDING_2D, &textureBinding); + glGetIntegerv(GL_TEXTURE_BINDING_2D, &textureBinding[0]); glBindTexture(GL_TEXTURE_2D, 0); if (gl.flags & RFL_SAMPLER_OBJECTS) { @@ -75,6 +75,15 @@ FGLPostProcessState::FGLPostProcessState() glDisable(GL_BLEND); } +void FGLPostProcessState::SaveTextureBinding1() +{ + glActiveTexture(GL_TEXTURE1); + glGetIntegerv(GL_TEXTURE_BINDING_2D, &textureBinding[1]); + glBindTexture(GL_TEXTURE_2D, 0); + textureBinding1Saved = true; + glActiveTexture(GL_TEXTURE0); +} + //----------------------------------------------------------------------------- // // Restores state at the end of post processing @@ -108,6 +117,12 @@ FGLPostProcessState::~FGLPostProcessState() glUseProgram(currentProgram); + if (textureBinding1Saved) + { + glActiveTexture(GL_TEXTURE1); + glBindTexture(GL_TEXTURE_2D, 0); + } + glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, 0); if (gl.flags & RFL_SAMPLER_OBJECTS) @@ -115,6 +130,13 @@ FGLPostProcessState::~FGLPostProcessState() glBindSampler(0, samplerBinding[0]); glBindSampler(1, samplerBinding[1]); } - glBindTexture(GL_TEXTURE_2D, textureBinding); + glBindTexture(GL_TEXTURE_2D, textureBinding[0]); + + if (textureBinding1Saved) + { + glActiveTexture(GL_TEXTURE1); + glBindTexture(GL_TEXTURE_2D, textureBinding[1]); + } + glActiveTexture(activeTex); } diff --git a/src/gl/renderer/gl_postprocessstate.h b/src/gl/renderer/gl_postprocessstate.h index 4f2ca81a12..bf53aa7de9 100644 --- a/src/gl/renderer/gl_postprocessstate.h +++ b/src/gl/renderer/gl_postprocessstate.h @@ -14,12 +14,14 @@ public: FGLPostProcessState(); ~FGLPostProcessState(); + void SaveTextureBinding1(); + private: FGLPostProcessState(const FGLPostProcessState &) = delete; FGLPostProcessState &operator=(const FGLPostProcessState &) = delete; GLint activeTex; - GLint textureBinding; + GLint textureBinding[2]; GLint samplerBinding[2]; GLboolean blendEnabled; GLboolean scissorEnabled; @@ -32,6 +34,7 @@ private: GLint blendSrcAlpha; GLint blendDestRgb; GLint blendDestAlpha; + bool textureBinding1Saved = false; }; #endif diff --git a/src/gl/renderer/gl_renderbuffers.cpp b/src/gl/renderer/gl_renderbuffers.cpp index 4383d706e4..b2471e4b91 100644 --- a/src/gl/renderer/gl_renderbuffers.cpp +++ b/src/gl/renderer/gl_renderbuffers.cpp @@ -74,6 +74,7 @@ FGLRenderBuffers::~FGLRenderBuffers() ClearPipeline(); ClearEyeBuffers(); ClearBloom(); + ClearExposureLevels(); } void FGLRenderBuffers::ClearScene() @@ -107,6 +108,18 @@ void FGLRenderBuffers::ClearBloom() } } +void FGLRenderBuffers::ClearExposureLevels() +{ + for (auto &level : ExposureLevels) + { + DeleteTexture(level.Texture); + DeleteFrameBuffer(level.Framebuffer); + } + ExposureLevels.Clear(); + DeleteTexture(ExposureTexture); + DeleteFrameBuffer(ExposureFB); +} + void FGLRenderBuffers::ClearEyeBuffers() { for (auto handle : mEyeFBs) @@ -186,11 +199,12 @@ bool FGLRenderBuffers::Setup(int width, int height, int sceneWidth, int sceneHei } // Bloom bluring buffers need to match the scene to avoid bloom bleeding artifacts - if (mBloomWidth != sceneWidth || mBloomHeight != sceneHeight) + if (mSceneWidth != sceneWidth || mSceneHeight != sceneHeight) { CreateBloom(sceneWidth, sceneHeight); - mBloomWidth = sceneWidth; - mBloomHeight = sceneHeight; + CreateExposureLevels(sceneWidth, sceneHeight); + mSceneWidth = sceneWidth; + mSceneHeight = sceneHeight; } glBindTexture(GL_TEXTURE_2D, textureBinding); @@ -204,11 +218,12 @@ bool FGLRenderBuffers::Setup(int width, int height, int sceneWidth, int sceneHei ClearPipeline(); ClearEyeBuffers(); ClearBloom(); + ClearExposureLevels(); mWidth = 0; mHeight = 0; mSamples = 0; - mBloomWidth = 0; - mBloomHeight = 0; + mSceneWidth = 0; + mSceneHeight = 0; } return !FailedCreate; @@ -281,6 +296,41 @@ void FGLRenderBuffers::CreateBloom(int width, int height) } } +//========================================================================== +// +// Creates camera exposure level buffers +// +//========================================================================== + +void FGLRenderBuffers::CreateExposureLevels(int width, int height) +{ + ClearExposureLevels(); + + int i = 0; + do + { + width = MAX(width / 2, 1); + height = MAX(height / 2, 1); + + FString textureName, fbName; + textureName.Format("Exposure.Texture%d", i); + fbName.Format("Exposure.Framebuffer%d", i); + i++; + + FGLExposureTextureLevel level; + level.Width = width; + level.Height = height; + level.Texture = Create2DTexture(textureName, GL_R32F, level.Width, level.Height); + level.Framebuffer = CreateFrameBuffer(fbName, level.Texture); + ExposureLevels.Push(level); + } while (width > 1 || height > 1); + + ExposureTexture = Create2DTexture("Exposure.CameraTexture", GL_R32F, 1, 1); + ExposureFB = CreateFrameBuffer("Exposure.CameraFB", ExposureTexture); + + FirstExposureFrame = true; +} + //========================================================================== // // Creates eye buffers if needed @@ -316,14 +366,14 @@ void FGLRenderBuffers::CreateEyeBuffers(int eye) // //========================================================================== -GLuint FGLRenderBuffers::Create2DTexture(const FString &name, GLuint format, int width, int height) +GLuint FGLRenderBuffers::Create2DTexture(const FString &name, GLuint format, int width, int height, const void *data) { - GLuint type = (format == GL_RGBA16F) ? GL_FLOAT : GL_UNSIGNED_BYTE; + GLuint type = (format == GL_RGBA16F || format == GL_R32F) ? GL_FLOAT : GL_UNSIGNED_BYTE; GLuint handle = 0; glGenTextures(1, &handle); glBindTexture(GL_TEXTURE_2D, handle); FGLDebug::LabelObject(GL_TEXTURE, handle, name); - glTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, GL_RGBA, type, nullptr); + glTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, format != GL_R32F ? GL_RGBA : GL_RED, type, data); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); diff --git a/src/gl/renderer/gl_renderbuffers.h b/src/gl/renderer/gl_renderbuffers.h index 08731e39f7..4477718f4b 100644 --- a/src/gl/renderer/gl_renderbuffers.h +++ b/src/gl/renderer/gl_renderbuffers.h @@ -14,6 +14,15 @@ public: GLuint Height = 0; }; +class FGLExposureTextureLevel +{ +public: + GLuint Texture = 0; + GLuint Framebuffer = 0; + GLuint Width = 0; + GLuint Height = 0; +}; + class FGLRenderBuffers { public: @@ -39,6 +48,11 @@ public: enum { NumBloomLevels = 4 }; FGLBloomTextureLevel BloomLevels[NumBloomLevels]; + TArray ExposureLevels; + GLuint ExposureTexture = 0; + GLuint ExposureFB = 0; + bool FirstExposureFrame = true; + static bool IsEnabled(); int GetWidth() const { return mWidth; } @@ -49,11 +63,13 @@ private: void ClearPipeline(); void ClearEyeBuffers(); void ClearBloom(); + void ClearExposureLevels(); void CreateScene(int width, int height, int samples); void CreatePipeline(int width, int height); void CreateBloom(int width, int height); + void CreateExposureLevels(int width, int height); void CreateEyeBuffers(int eye); - GLuint Create2DTexture(const FString &name, GLuint format, int width, int height); + GLuint Create2DTexture(const FString &name, GLuint format, int width, int height, const void *data = nullptr); GLuint CreateRenderBuffer(const FString &name, GLuint format, int width, int height); GLuint CreateRenderBuffer(const FString &name, GLuint format, int samples, int width, int height); GLuint CreateFrameBuffer(const FString &name, GLuint colorbuffer); @@ -69,8 +85,8 @@ private: int mHeight = 0; int mSamples = 0; int mMaxSamples = 0; - int mBloomWidth = 0; - int mBloomHeight = 0; + int mSceneWidth = 0; + int mSceneHeight = 0; static const int NumPipelineTextures = 2; int mCurrentPipelineTexture = 0; diff --git a/src/gl/renderer/gl_renderer.cpp b/src/gl/renderer/gl_renderer.cpp index 4b59ad1a91..ab0e658e70 100644 --- a/src/gl/renderer/gl_renderer.cpp +++ b/src/gl/renderer/gl_renderer.cpp @@ -104,6 +104,9 @@ FGLRenderer::FGLRenderer(OpenGLFrameBuffer *fb) mPresentShader = nullptr; mBloomExtractShader = nullptr; mBloomCombineShader = nullptr; + mExposureExtractShader = nullptr; + mExposureAverageShader = nullptr; + mExposureCombineShader = nullptr; mBlurShader = nullptr; mTonemapShader = nullptr; mTonemapPalette = nullptr; @@ -119,6 +122,9 @@ void FGLRenderer::Initialize(int width, int height) mBuffers = new FGLRenderBuffers(); mBloomExtractShader = new FBloomExtractShader(); mBloomCombineShader = new FBloomCombineShader(); + mExposureExtractShader = new FExposureExtractShader(); + mExposureAverageShader = new FExposureAverageShader(); + mExposureCombineShader = new FExposureCombineShader(); mBlurShader = new FBlurShader(); mTonemapShader = new FTonemapShader(); mColormapShader = new FColormapShader(); @@ -179,6 +185,9 @@ FGLRenderer::~FGLRenderer() if (mPresentShader) delete mPresentShader; if (mBloomExtractShader) delete mBloomExtractShader; if (mBloomCombineShader) delete mBloomCombineShader; + if (mExposureExtractShader) delete mExposureExtractShader; + if (mExposureAverageShader) delete mExposureAverageShader; + if (mExposureCombineShader) delete mExposureCombineShader; if (mBlurShader) delete mBlurShader; if (mTonemapShader) delete mTonemapShader; if (mTonemapPalette) delete mTonemapPalette; diff --git a/src/gl/renderer/gl_renderer.h b/src/gl/renderer/gl_renderer.h index 162fb6dcf4..b954085214 100644 --- a/src/gl/renderer/gl_renderer.h +++ b/src/gl/renderer/gl_renderer.h @@ -21,6 +21,9 @@ class DPSprite; class FGLRenderBuffers; class FBloomExtractShader; class FBloomCombineShader; +class FExposureExtractShader; +class FExposureAverageShader; +class FExposureCombineShader; class FBlurShader; class FTonemapShader; class FColormapShader; @@ -92,6 +95,9 @@ public: FGLRenderBuffers *mBuffers; FBloomExtractShader *mBloomExtractShader; FBloomCombineShader *mBloomCombineShader; + FExposureExtractShader *mExposureExtractShader; + FExposureAverageShader *mExposureAverageShader; + FExposureCombineShader *mExposureCombineShader; FBlurShader *mBlurShader; FTonemapShader *mTonemapShader; FColormapShader *mColormapShader; @@ -118,7 +124,6 @@ public: GL_IRECT mSceneViewport; GL_IRECT mOutputLetterbox; bool mDrawingScene2D = false; - float mCameraExposure = 1.0f; float mSceneClearColor[3]; @@ -166,6 +171,7 @@ public: void SetFixedColormap (player_t *player); void WriteSavePic (player_t *player, FILE *file, int width, int height); void EndDrawScene(sector_t * viewsector); + void UpdateCameraExposure(); void BloomScene(); void TonemapScene(); void ColormapScene(); diff --git a/src/gl/scene/gl_scene.cpp b/src/gl/scene/gl_scene.cpp index cca4528008..7c04ce77a8 100644 --- a/src/gl/scene/gl_scene.cpp +++ b/src/gl/scene/gl_scene.cpp @@ -790,20 +790,6 @@ sector_t * FGLRenderer::RenderViewpoint (AActor * camera, GL_IRECT * bounds, flo mViewActor=camera; } - if (toscreen) - { - if (gl_exposure == 0.0f) - { - float light = viewsector->lightlevel / 255.0f; - float exposure = MAX(1.0f + (1.0f - light * light) * 0.9f, 0.5f); - mCameraExposure = mCameraExposure * 0.995f + exposure * 0.005f; - } - else - { - mCameraExposure = gl_exposure; - } - } - // 'viewsector' will not survive the rendering so it cannot be used anymore below. lviewsector = viewsector; @@ -839,6 +825,7 @@ sector_t * FGLRenderer::RenderViewpoint (AActor * camera, GL_IRECT * bounds, flo if (mainview && FGLRenderBuffers::IsEnabled()) { mBuffers->BlitSceneToTexture(); + UpdateCameraExposure(); BloomScene(); TonemapScene(); ColormapScene(); diff --git a/src/gl/shaders/gl_bloomshader.cpp b/src/gl/shaders/gl_bloomshader.cpp index a16c9ed1ea..44253ae79c 100644 --- a/src/gl/shaders/gl_bloomshader.cpp +++ b/src/gl/shaders/gl_bloomshader.cpp @@ -46,7 +46,7 @@ void FBloomExtractShader::Bind() mShader.Link("shaders/glsl/bloomextract"); mShader.SetAttribLocation(0, "PositionInProjection"); SceneTexture.Init(mShader, "SceneTexture"); - Exposure.Init(mShader, "ExposureAdjustment"); + ExposureTexture.Init(mShader, "ExposureTexture"); Scale.Init(mShader, "Scale"); Offset.Init(mShader, "Offset"); } diff --git a/src/gl/shaders/gl_bloomshader.h b/src/gl/shaders/gl_bloomshader.h index b20277a42d..8b34bb479c 100644 --- a/src/gl/shaders/gl_bloomshader.h +++ b/src/gl/shaders/gl_bloomshader.h @@ -9,7 +9,7 @@ public: void Bind(); FBufferedUniformSampler SceneTexture; - FBufferedUniform1f Exposure; + FBufferedUniformSampler ExposureTexture; FBufferedUniform2f Scale; FBufferedUniform2f Offset; diff --git a/src/gl/shaders/gl_tonemapshader.cpp b/src/gl/shaders/gl_tonemapshader.cpp index 144981b180..3db6db8ba8 100644 --- a/src/gl/shaders/gl_tonemapshader.cpp +++ b/src/gl/shaders/gl_tonemapshader.cpp @@ -47,7 +47,7 @@ void FTonemapShader::Bind() shader.Link("shaders/glsl/tonemap"); shader.SetAttribLocation(0, "PositionInProjection"); SceneTexture.Init(shader, "InputTexture"); - Exposure.Init(shader, "ExposureAdjustment"); + ExposureTexture.Init(shader, "ExposureTexture"); PaletteLUT.Init(shader, "PaletteLUT"); } shader.Bind(); @@ -70,3 +70,51 @@ const char *FTonemapShader::GetDefines(int mode) case Palette: return "#define PALETTE\n"; } } + +void FExposureExtractShader::Bind() +{ + if (!mShader) + { + mShader.Compile(FShaderProgram::Vertex, "shaders/glsl/screenquad.vp", "", 330); + mShader.Compile(FShaderProgram::Fragment, "shaders/glsl/exposureextract.fp", "", 330); + mShader.SetFragDataLocation(0, "FragColor"); + mShader.Link("shaders/glsl/exposureextract"); + mShader.SetAttribLocation(0, "PositionInProjection"); + SceneTexture.Init(mShader, "SceneTexture"); + Scale.Init(mShader, "Scale"); + Offset.Init(mShader, "Offset"); + } + mShader.Bind(); +} + +void FExposureAverageShader::Bind() +{ + if (!mShader) + { + mShader.Compile(FShaderProgram::Vertex, "shaders/glsl/screenquad.vp", "", 400); + mShader.Compile(FShaderProgram::Fragment, "shaders/glsl/exposureaverage.fp", "", 400); + mShader.SetFragDataLocation(0, "FragColor"); + mShader.Link("shaders/glsl/exposureaverage"); + mShader.SetAttribLocation(0, "PositionInProjection"); + ExposureTexture.Init(mShader, "ExposureTexture"); + } + mShader.Bind(); +} + +void FExposureCombineShader::Bind() +{ + if (!mShader) + { + mShader.Compile(FShaderProgram::Vertex, "shaders/glsl/screenquad.vp", "", 330); + mShader.Compile(FShaderProgram::Fragment, "shaders/glsl/exposurecombine.fp", "", 330); + mShader.SetFragDataLocation(0, "FragColor"); + mShader.Link("shaders/glsl/exposurecombine"); + mShader.SetAttribLocation(0, "PositionInProjection"); + ExposureTexture.Init(mShader, "ExposureTexture"); + ExposureBase.Init(mShader, "ExposureBase"); + ExposureMin.Init(mShader, "ExposureMin"); + ExposureScale.Init(mShader, "ExposureScale"); + ExposureSpeed.Init(mShader, "ExposureSpeed"); + } + mShader.Bind(); +} \ No newline at end of file diff --git a/src/gl/shaders/gl_tonemapshader.h b/src/gl/shaders/gl_tonemapshader.h index 7ec24117b1..b4cd102de6 100644 --- a/src/gl/shaders/gl_tonemapshader.h +++ b/src/gl/shaders/gl_tonemapshader.h @@ -9,7 +9,7 @@ public: void Bind(); FBufferedUniformSampler SceneTexture; - FBufferedUniform1f Exposure; + FBufferedUniformSampler ExposureTexture; FBufferedUniformSampler PaletteLUT; static bool IsPaletteMode(); @@ -31,4 +31,43 @@ private: FShaderProgram mShader[NumTonemapModes]; }; +class FExposureExtractShader +{ +public: + void Bind(); + + FBufferedUniformSampler SceneTexture; + FBufferedUniform2f Scale; + FBufferedUniform2f Offset; + +private: + FShaderProgram mShader; +}; + +class FExposureAverageShader +{ +public: + void Bind(); + + FBufferedUniformSampler ExposureTexture; + +private: + FShaderProgram mShader; +}; + +class FExposureCombineShader +{ +public: + void Bind(); + + FBufferedUniformSampler ExposureTexture; + FBufferedUniform1f ExposureBase; + FBufferedUniform1f ExposureMin; + FBufferedUniform1f ExposureScale; + FBufferedUniform1f ExposureSpeed; + +private: + FShaderProgram mShader; +}; + #endif \ No newline at end of file diff --git a/wadsrc/static/shaders/glsl/bloomextract.fp b/wadsrc/static/shaders/glsl/bloomextract.fp index bc94c3c0e4..9c5aa0bea3 100644 --- a/wadsrc/static/shaders/glsl/bloomextract.fp +++ b/wadsrc/static/shaders/glsl/bloomextract.fp @@ -3,12 +3,13 @@ in vec2 TexCoord; out vec4 FragColor; uniform sampler2D SceneTexture; -uniform float ExposureAdjustment; +uniform sampler2D ExposureTexture; uniform vec2 Scale; uniform vec2 Offset; void main() { + float exposureAdjustment = texture(ExposureTexture, vec2(0.5)).x; vec4 color = texture(SceneTexture, Offset + TexCoord * Scale); - FragColor = max(vec4(color.rgb * ExposureAdjustment - 1, 1), vec4(0)); + FragColor = max(vec4((color.rgb + vec3(0.001)) * exposureAdjustment - 1, 1), vec4(0)); } diff --git a/wadsrc/static/shaders/glsl/exposureaverage.fp b/wadsrc/static/shaders/glsl/exposureaverage.fp new file mode 100644 index 0000000000..41c0909d2d --- /dev/null +++ b/wadsrc/static/shaders/glsl/exposureaverage.fp @@ -0,0 +1,23 @@ + +in vec2 TexCoord; +out vec4 FragColor; + +uniform sampler2D ExposureTexture; + +void main() +{ +#if __VERSION__ < 400 + ivec2 size = textureSize(ExposureTexture, 0); + ivec2 tl = max(ivec2(TexCoord * vec2(size) - 0.5), ivec2(0)); + ivec2 br = min(tl + ivec2(1), size - ivec2(1)); + vec4 values = vec4( + texelFetch(ExposureTexture, tl, 0).x, + texelFetch(ExposureTexture, ivec2(tl.x, br.y), 0).x, + texelFetch(ExposureTexture, ivec2(br.x, tl.y), 0).x, + texelFetch(ExposureTexture, br, 0).x); +#else + vec4 values = textureGather(ExposureTexture, TexCoord); +#endif + + FragColor = vec4((values.x + values.y + values.z + values.w) * 0.25, 0.0, 0.0, 1.0); +} diff --git a/wadsrc/static/shaders/glsl/exposurecombine.fp b/wadsrc/static/shaders/glsl/exposurecombine.fp new file mode 100644 index 0000000000..f806f8f860 --- /dev/null +++ b/wadsrc/static/shaders/glsl/exposurecombine.fp @@ -0,0 +1,16 @@ + +in vec2 TexCoord; +out vec4 FragColor; + +uniform sampler2D ExposureTexture; +uniform float ExposureBase; +uniform float ExposureMin; +uniform float ExposureScale; +uniform float ExposureSpeed; + +void main() +{ + float light = texture(ExposureTexture, TexCoord).x; + float exposureAdjustment = 1.0 / max(ExposureBase + light * ExposureScale, ExposureMin); + FragColor = vec4(exposureAdjustment, 0.0, 0.0, ExposureSpeed); +} diff --git a/wadsrc/static/shaders/glsl/exposureextract.fp b/wadsrc/static/shaders/glsl/exposureextract.fp new file mode 100644 index 0000000000..f673bf0295 --- /dev/null +++ b/wadsrc/static/shaders/glsl/exposureextract.fp @@ -0,0 +1,13 @@ + +in vec2 TexCoord; +out vec4 FragColor; + +uniform sampler2D SceneTexture; +uniform vec2 Scale; +uniform vec2 Offset; + +void main() +{ + vec4 color = texture(SceneTexture, Offset + TexCoord * Scale); + FragColor = vec4(max(max(color.r, color.g), color.b), 0.0, 0.0, 1.0); +} diff --git a/wadsrc/static/shaders/glsl/tonemap.fp b/wadsrc/static/shaders/glsl/tonemap.fp index d6574b2959..5cb7cf8bd2 100644 --- a/wadsrc/static/shaders/glsl/tonemap.fp +++ b/wadsrc/static/shaders/glsl/tonemap.fp @@ -3,7 +3,7 @@ in vec2 TexCoord; out vec4 FragColor; uniform sampler2D InputTexture; -uniform float ExposureAdjustment; +uniform sampler2D ExposureTexture; vec3 Linear(vec3 c) { @@ -84,7 +84,8 @@ void main() { vec3 color = texture(InputTexture, TexCoord).rgb; #ifndef PALETTE - color = color * ExposureAdjustment; + float exposureAdjustment = texture(ExposureTexture, vec2(0.5)).x; + color = color * exposureAdjustment; color = Linear(color); // needed because gzdoom's scene texture is not linear at the moment #endif FragColor = vec4(Tonemap(color), 1.0); From af699dcebccb8205eea6b17a9d3b6ed21d4036b0 Mon Sep 17 00:00:00 2001 From: Magnus Norddahl Date: Sun, 18 Sep 2016 19:31:09 +0200 Subject: [PATCH 13/27] Make bloom/exposure less aggressive --- src/gl/renderer/gl_postprocess.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gl/renderer/gl_postprocess.cpp b/src/gl/renderer/gl_postprocess.cpp index 1cdad9f9be..7ce8be0adc 100644 --- a/src/gl/renderer/gl_postprocess.cpp +++ b/src/gl/renderer/gl_postprocess.cpp @@ -75,7 +75,7 @@ CUSTOM_CVAR(Float, gl_bloom_amount, 1.4f, 0) if (self < 0.1f) self = 0.1f; } -CVAR(Float, gl_exposure_scale, 0.75f, 0) +CVAR(Float, gl_exposure_scale, 1.3f, 0) CVAR(Float, gl_exposure_min, 0.35f, 0) CVAR(Float, gl_exposure_base, 0.35f, 0) CVAR(Float, gl_exposure_speed, 0.05f, 0) From 72491049e0b371dff959e567ac88ca6dc733c2c7 Mon Sep 17 00:00:00 2001 From: raa-eruanna Date: Wed, 21 Sep 2016 15:08:53 -0400 Subject: [PATCH 14/27] Changes to the contrast/brightness/gamma formula for both hardware and shader gamma correction. Mainly makes a correction with the shader version where contrast/brightness being negative values would clip them inappropriately. --- src/gl/system/gl_framebuffer.cpp | 2 +- wadsrc/static/shaders/glsl/present.fp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gl/system/gl_framebuffer.cpp b/src/gl/system/gl_framebuffer.cpp index 07d8abaef7..1ca2f7eddc 100644 --- a/src/gl/system/gl_framebuffer.cpp +++ b/src/gl/system/gl_framebuffer.cpp @@ -250,8 +250,8 @@ void OpenGLFrameBuffer::DoSetGamma() for (int i = 0; i < 256; i++) { double val = i * contrast - (contrast - 1) * 127; - if(gamma != 1) val = pow(val, invgamma) / norm; val += bright * 128; + if(gamma != 1) val = pow(val, invgamma) / norm; gammaTable[i] = gammaTable[i + 256] = gammaTable[i + 512] = (WORD)clamp(val*256, 0, 0xffff); } diff --git a/wadsrc/static/shaders/glsl/present.fp b/wadsrc/static/shaders/glsl/present.fp index 53fc007b67..4f5c7cffa0 100644 --- a/wadsrc/static/shaders/glsl/present.fp +++ b/wadsrc/static/shaders/glsl/present.fp @@ -9,9 +9,9 @@ uniform float Brightness; vec4 ApplyGamma(vec4 c) { - vec3 val = max(c.rgb * Contrast - (Contrast - 1.0) * 0.5, vec3(0.0)); - val = pow(val, vec3(InvGamma)); + vec3 val = c.rgb * Contrast - (Contrast - 1.0) * 0.5; val += Brightness * 0.5; + val = pow(val, vec3(InvGamma)); return vec4(val, c.a); } From 2339b18b0140005d3d5cbac46cc47004764f732d Mon Sep 17 00:00:00 2001 From: raa-eruanna Date: Wed, 21 Sep 2016 15:13:10 -0400 Subject: [PATCH 15/27] Quick fix: prevents negative values being passed to pow. --- wadsrc/static/shaders/glsl/present.fp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wadsrc/static/shaders/glsl/present.fp b/wadsrc/static/shaders/glsl/present.fp index 4f5c7cffa0..31c1217cb8 100644 --- a/wadsrc/static/shaders/glsl/present.fp +++ b/wadsrc/static/shaders/glsl/present.fp @@ -11,7 +11,7 @@ vec4 ApplyGamma(vec4 c) { vec3 val = c.rgb * Contrast - (Contrast - 1.0) * 0.5; val += Brightness * 0.5; - val = pow(val, vec3(InvGamma)); + val = pow(max(val, vec3(0.0)), vec3(InvGamma)); return vec4(val, c.a); } From 9a257ac158617be196713d0f4b3d9f2b919ce6f3 Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Sat, 10 Sep 2016 15:34:15 -0400 Subject: [PATCH 16/27] Implement side-by-side narrow 3D mode. --- src/CMakeLists.txt | 1 + src/gl/stereo3d/gl_sidebyside3d.cpp | 79 +++++++++++++++++++++++++++++ src/gl/stereo3d/gl_sidebyside3d.h | 63 +++++++++++++++++++++++ src/gl/stereo3d/gl_stereo_cvars.cpp | 6 ++- wadsrc/static/language.enu | 1 + wadsrc/static/menudef.z | 1 + 6 files changed, 150 insertions(+), 1 deletion(-) create mode 100644 src/gl/stereo3d/gl_sidebyside3d.cpp create mode 100644 src/gl/stereo3d/gl_sidebyside3d.h diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 6edd616aee..230c3dac9d 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1115,6 +1115,7 @@ set( FASTMATH_SOURCES gl/stereo3d/scoped_view_shifter.cpp gl/stereo3d/gl_anaglyph.cpp gl/stereo3d/gl_quadstereo.cpp + gl/stereo3d/gl_sidebyside3d.cpp gl/dynlights/gl_dynlight.cpp gl/dynlights/gl_glow.cpp gl/dynlights/gl_dynlight1.cpp diff --git a/src/gl/stereo3d/gl_sidebyside3d.cpp b/src/gl/stereo3d/gl_sidebyside3d.cpp new file mode 100644 index 0000000000..f526dce8b7 --- /dev/null +++ b/src/gl/stereo3d/gl_sidebyside3d.cpp @@ -0,0 +1,79 @@ +/* +** gl_sidebyside3d.cpp +** Color mask based stereoscopic 3D modes for GZDoom +** +**--------------------------------------------------------------------------- +** Copyright 2016 Christopher Bruns +** All rights reserved. +** +** Redistribution and use in source and binary forms, with or without +** modification, are permitted provided that the following conditions +** are met: +** +** 1. Redistributions of source code must retain the above copyright +** notice, this list of conditions and the following disclaimer. +** 2. Redistributions in binary form must reproduce the above copyright +** notice, this list of conditions and the following disclaimer in the +** documentation and/or other materials provided with the distribution. +** 3. The name of the author may not be used to endorse or promote products +** derived from this software without specific prior written permission. +** +** THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR +** IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES +** OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. +** IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, +** INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT +** NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +** DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +** THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +** (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF +** THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +**--------------------------------------------------------------------------- +** +** +*/ + +#include "gl_sidebyside3d.h" +#include "gl/renderer/gl_renderer.h" +#include "gl/renderer/gl_renderbuffers.h" + +namespace s3d { + + +/* static */ +const SideBySideSquished& SideBySideSquished::getInstance(float ipd) +{ + static SideBySideSquished instance(ipd); + return instance; +} + +SideBySideSquished::SideBySideSquished(double ipdMeters) + : leftEye(ipdMeters), rightEye(ipdMeters) +{ + eye_ptrs.Push(&leftEye); + eye_ptrs.Push(&rightEye); +} + +void SideBySideSquished::Present() const +{ + GLRenderer->mBuffers->BindOutputFB(); + GLRenderer->ClearBorders(); + + // Compute screen regions to use for left and right eye views + int leftWidth = GLRenderer->mOutputLetterbox.width/2; + int rightWidth = GLRenderer->mOutputLetterbox.width - leftWidth; + GL_IRECT leftHalfScreen = GLRenderer->mOutputLetterbox; + leftHalfScreen.width = leftWidth; + GL_IRECT rightHalfScreen = GLRenderer->mOutputLetterbox; + rightHalfScreen.width = rightWidth; + rightHalfScreen.left += leftWidth; + + GLRenderer->mBuffers->BindEyeTexture(0, 0); + GLRenderer->DrawPresentTexture(leftHalfScreen, true); + + GLRenderer->mBuffers->BindEyeTexture(1, 0); + GLRenderer->DrawPresentTexture(rightHalfScreen, true); +} + + +} /* namespace s3d */ diff --git a/src/gl/stereo3d/gl_sidebyside3d.h b/src/gl/stereo3d/gl_sidebyside3d.h new file mode 100644 index 0000000000..2f29464240 --- /dev/null +++ b/src/gl/stereo3d/gl_sidebyside3d.h @@ -0,0 +1,63 @@ +/* +** gl_sidebyside3d.h +** Color mask based stereoscopic 3D modes for GZDoom +** +**--------------------------------------------------------------------------- +** Copyright 2016 Christopher Bruns +** All rights reserved. +** +** Redistribution and use in source and binary forms, with or without +** modification, are permitted provided that the following conditions +** are met: +** +** 1. Redistributions of source code must retain the above copyright +** notice, this list of conditions and the following disclaimer. +** 2. Redistributions in binary form must reproduce the above copyright +** notice, this list of conditions and the following disclaimer in the +** documentation and/or other materials provided with the distribution. +** 3. The name of the author may not be used to endorse or promote products +** derived from this software without specific prior written permission. +** +** THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR +** IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES +** OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. +** IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, +** INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT +** NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +** DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +** THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +** (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF +** THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +**--------------------------------------------------------------------------- +** +** +*/ + +#ifndef GL_SIDEBYSIDE3D_H_ +#define GL_SIDEBYSIDE3D_H_ + +#include "gl_stereo3d.h" +#include "gl_stereo_leftright.h" +#include "gl/system/gl_system.h" +#include "gl/renderer/gl_renderstate.h" + + +namespace s3d { + +class SideBySideSquished : public Stereo3DMode +{ +public: + static const SideBySideSquished& getInstance(float ipd); + + SideBySideSquished(double ipdMeters); + void Present() const override; +private: + LeftEyePose leftEye; + RightEyePose rightEye; +}; + + +} /* namespace s3d */ + + +#endif /* GL_SIDEBYSIDE3D_H_ */ diff --git a/src/gl/stereo3d/gl_stereo_cvars.cpp b/src/gl/stereo3d/gl_stereo_cvars.cpp index f904c2a518..cd63360264 100644 --- a/src/gl/stereo3d/gl_stereo_cvars.cpp +++ b/src/gl/stereo3d/gl_stereo_cvars.cpp @@ -29,6 +29,7 @@ #include "gl/stereo3d/gl_stereo_leftright.h" #include "gl/stereo3d/gl_anaglyph.h" #include "gl/stereo3d/gl_quadstereo.h" +#include "gl/stereo3d/gl_sidebyside3d.h" #include "gl/system/gl_cvars.h" // Set up 3D-specific console variables: @@ -71,7 +72,10 @@ const Stereo3DMode& Stereo3DMode::getCurrentMode() case 2: setCurrentMode(RedCyan::getInstance(vr_ipd)); break; - // TODO: missing indices 3, 4 for not-yet-implemented side-by-side modes, to match values from GZ3Doom + // TODO: missing index 3 for not-yet-implemented side-by-side mode, to match values from GZ3Doom + case 4: + setCurrentMode(SideBySideSquished::getInstance(vr_ipd)); + break; case 5: setCurrentMode(LeftEyeView::getInstance(vr_ipd)); break; diff --git a/wadsrc/static/language.enu b/wadsrc/static/language.enu index e3fbb16ca0..4b4013cc78 100644 --- a/wadsrc/static/language.enu +++ b/wadsrc/static/language.enu @@ -2701,6 +2701,7 @@ OPTVAL_REDCYAN = "Red/Cyan"; OPTVAL_AMBERBLUE = "Amber/Blue"; OPTVAL_LEFTEYE = "Left Eye"; OPTVAL_RIGHTEYE = "Right Eye"; +OPTVAL_SBSNARROW = "Side-by-side Narrow"; OPTVAL_QUADBUFFERED = "Quad-buffered"; OPTVAL_UNCHARTED2 = "Uncharted 2"; OPTVAL_HEJLDAWSON = "Hejl Dawson"; diff --git a/wadsrc/static/menudef.z b/wadsrc/static/menudef.z index 980cdacc38..28c343c2af 100644 --- a/wadsrc/static/menudef.z +++ b/wadsrc/static/menudef.z @@ -167,6 +167,7 @@ OptionValue VRMode 1, "$OPTVAL_GREENMAGENTA" 2, "$OPTVAL_REDCYAN" 9, "$OPTVAL_AMBERBLUE" + 4, "$OPTVAL_SBSNARROW" 5, "$OPTVAL_LEFTEYE" 6, "$OPTVAL_RIGHTEYE" 7, "$OPTVAL_QUADBUFFERED" From 1f79e23d5be7d29d55f0b45977f582dfc3919593 Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Sun, 11 Sep 2016 13:42:41 -0400 Subject: [PATCH 17/27] Implement wide side-by-side mode, using adjusted aspect ratio in projection matrix. Use optimal framebuffer size for side-by-side modes. --- src/gl/renderer/gl_renderer.cpp | 3 ++ src/gl/scene/gl_scene.cpp | 1 - src/gl/stereo3d/gl_sidebyside3d.cpp | 58 ++++++++++++++++++++--------- src/gl/stereo3d/gl_sidebyside3d.h | 37 ++++++++++++++++-- src/gl/stereo3d/gl_stereo3d.h | 2 + src/gl/stereo3d/gl_stereo_cvars.cpp | 8 +++- wadsrc/static/language.enu | 1 + wadsrc/static/menudef.z | 1 + 8 files changed, 87 insertions(+), 24 deletions(-) diff --git a/src/gl/renderer/gl_renderer.cpp b/src/gl/renderer/gl_renderer.cpp index ab0e658e70..42b4a8e1b8 100644 --- a/src/gl/renderer/gl_renderer.cpp +++ b/src/gl/renderer/gl_renderer.cpp @@ -57,6 +57,7 @@ #include "gl/shaders/gl_colormapshader.h" #include "gl/shaders/gl_lensshader.h" #include "gl/shaders/gl_presentshader.h" +#include "gl/stereo3d/gl_stereo3d.h" #include "gl/textures/gl_texture.h" #include "gl/textures/gl_translate.h" #include "gl/textures/gl_material.h" @@ -273,6 +274,8 @@ void FGLRenderer::SetOutputViewport(GL_IRECT *bounds) mSceneViewport.top += mOutputLetterbox.top; } } + + s3d::Stereo3DMode::getCurrentMode().AdjustViewports(); } //=========================================================================== diff --git a/src/gl/scene/gl_scene.cpp b/src/gl/scene/gl_scene.cpp index 7c04ce77a8..6ddd12a1f6 100644 --- a/src/gl/scene/gl_scene.cpp +++ b/src/gl/scene/gl_scene.cpp @@ -801,7 +801,6 @@ sector_t * FGLRenderer::RenderViewpoint (AActor * camera, GL_IRECT * bounds, flo { const s3d::EyePose * eye = stereo3dMode.getEyePose(eye_ix); eye->SetUp(); - // TODO: stereo specific viewport - needed when implementing side-by-side modes etc. SetOutputViewport(bounds); Set3DViewport(mainview); mDrawingScene2D = true; diff --git a/src/gl/stereo3d/gl_sidebyside3d.cpp b/src/gl/stereo3d/gl_sidebyside3d.cpp index f526dce8b7..8a66fc91cb 100644 --- a/src/gl/stereo3d/gl_sidebyside3d.cpp +++ b/src/gl/stereo3d/gl_sidebyside3d.cpp @@ -39,6 +39,36 @@ namespace s3d { +void SideBySideBase::Present() const +{ + GLRenderer->mBuffers->BindOutputFB(); + GLRenderer->ClearBorders(); + + // Compute screen regions to use for left and right eye views + int leftWidth = GLRenderer->mOutputLetterbox.width / 2; + int rightWidth = GLRenderer->mOutputLetterbox.width - leftWidth; + GL_IRECT leftHalfScreen = GLRenderer->mOutputLetterbox; + leftHalfScreen.width = leftWidth; + GL_IRECT rightHalfScreen = GLRenderer->mOutputLetterbox; + rightHalfScreen.width = rightWidth; + rightHalfScreen.left += leftWidth; + + GLRenderer->mBuffers->BindEyeTexture(0, 0); + GLRenderer->DrawPresentTexture(leftHalfScreen, true); + + GLRenderer->mBuffers->BindEyeTexture(1, 0); + GLRenderer->DrawPresentTexture(rightHalfScreen, true); +} + +// AdjustViewports() is called from within FLGRenderer::SetOutputViewport(...) +void SideBySideBase::AdjustViewports() const +{ + // Change size of renderbuffer, and align to screen + GLRenderer->mSceneViewport.width /= 2; + GLRenderer->mSceneViewport.left /= 2; + GLRenderer->mScreenViewport.width /= 2; + GLRenderer->mScreenViewport.left /= 2; +} /* static */ const SideBySideSquished& SideBySideSquished::getInstance(float ipd) @@ -54,26 +84,18 @@ SideBySideSquished::SideBySideSquished(double ipdMeters) eye_ptrs.Push(&rightEye); } -void SideBySideSquished::Present() const +/* static */ +const SideBySideFull& SideBySideFull::getInstance(float ipd) { - GLRenderer->mBuffers->BindOutputFB(); - GLRenderer->ClearBorders(); - - // Compute screen regions to use for left and right eye views - int leftWidth = GLRenderer->mOutputLetterbox.width/2; - int rightWidth = GLRenderer->mOutputLetterbox.width - leftWidth; - GL_IRECT leftHalfScreen = GLRenderer->mOutputLetterbox; - leftHalfScreen.width = leftWidth; - GL_IRECT rightHalfScreen = GLRenderer->mOutputLetterbox; - rightHalfScreen.width = rightWidth; - rightHalfScreen.left += leftWidth; - - GLRenderer->mBuffers->BindEyeTexture(0, 0); - GLRenderer->DrawPresentTexture(leftHalfScreen, true); - - GLRenderer->mBuffers->BindEyeTexture(1, 0); - GLRenderer->DrawPresentTexture(rightHalfScreen, true); + static SideBySideFull instance(ipd); + return instance; } +SideBySideFull::SideBySideFull(double ipdMeters) + : leftEye(ipdMeters), rightEye(ipdMeters) +{ + eye_ptrs.Push(&leftEye); + eye_ptrs.Push(&rightEye); +} } /* namespace s3d */ diff --git a/src/gl/stereo3d/gl_sidebyside3d.h b/src/gl/stereo3d/gl_sidebyside3d.h index 2f29464240..c79c0c4b45 100644 --- a/src/gl/stereo3d/gl_sidebyside3d.h +++ b/src/gl/stereo3d/gl_sidebyside3d.h @@ -44,18 +44,49 @@ namespace s3d { -class SideBySideSquished : public Stereo3DMode +class SideBySideBase : public Stereo3DMode +{ +public: + void Present() const override; + virtual void AdjustViewports() const override; +}; + +class SideBySideSquished : public SideBySideBase { public: static const SideBySideSquished& getInstance(float ipd); - SideBySideSquished(double ipdMeters); - void Present() const override; private: LeftEyePose leftEye; RightEyePose rightEye; }; +class SBSFLeftEyePose : public LeftEyePose { +public: + SBSFLeftEyePose(double ipdMeters) : LeftEyePose(ipdMeters) {} + virtual VSMatrix GetProjection(float fov, float aspectRatio, float fovRatio) const override { + return LeftEyePose::GetProjection(fov, 0.5f * aspectRatio, fovRatio); + } +}; + +class SBSFRightEyePose : public RightEyePose { +public: + SBSFRightEyePose(double ipdMeters) : RightEyePose(ipdMeters) {} + virtual VSMatrix GetProjection(float fov, float aspectRatio, float fovRatio) const override { + return RightEyePose::GetProjection(fov, 0.5f * aspectRatio, fovRatio); + } +}; + +class SideBySideFull : public SideBySideBase +{ +public: + static const SideBySideFull& getInstance(float ipd); + SideBySideFull(double ipdMeters); +private: + SBSFLeftEyePose leftEye; + SBSFRightEyePose rightEye; +}; + } /* namespace s3d */ diff --git a/src/gl/stereo3d/gl_stereo3d.h b/src/gl/stereo3d/gl_stereo3d.h index e2a8a1ea69..747bcd0c0d 100644 --- a/src/gl/stereo3d/gl_stereo3d.h +++ b/src/gl/stereo3d/gl_stereo3d.h @@ -31,6 +31,7 @@ #include // needed for memcpy on linux, which is needed by VSMatrix copy ctor #include "tarray.h" #include "gl/data/gl_matrix.h" +#include "gl/renderer/gl_renderer.h" /* stereoscopic 3D API */ @@ -78,6 +79,7 @@ public: virtual void TearDown() const {}; virtual bool IsMono() const { return false; } + virtual void AdjustViewports() const {}; virtual void Present() const = 0; protected: diff --git a/src/gl/stereo3d/gl_stereo_cvars.cpp b/src/gl/stereo3d/gl_stereo_cvars.cpp index cd63360264..0927829fc3 100644 --- a/src/gl/stereo3d/gl_stereo_cvars.cpp +++ b/src/gl/stereo3d/gl_stereo_cvars.cpp @@ -72,7 +72,9 @@ const Stereo3DMode& Stereo3DMode::getCurrentMode() case 2: setCurrentMode(RedCyan::getInstance(vr_ipd)); break; - // TODO: missing index 3 for not-yet-implemented side-by-side mode, to match values from GZ3Doom + case 3: + setCurrentMode(SideBySideFull::getInstance(vr_ipd)); + break; case 4: setCurrentMode(SideBySideSquished::getInstance(vr_ipd)); break; @@ -93,7 +95,9 @@ const Stereo3DMode& Stereo3DMode::getCurrentMode() // TODO: 8: Oculus Rift case 9: setCurrentMode(AmberBlue::getInstance(vr_ipd)); - break; case 0: + break; + // TODO: 10: HTC Vive/OpenVR + case 0: default: setCurrentMode(MonoView::getInstance()); break; diff --git a/wadsrc/static/language.enu b/wadsrc/static/language.enu index 4b4013cc78..50526a75b5 100644 --- a/wadsrc/static/language.enu +++ b/wadsrc/static/language.enu @@ -2701,6 +2701,7 @@ OPTVAL_REDCYAN = "Red/Cyan"; OPTVAL_AMBERBLUE = "Amber/Blue"; OPTVAL_LEFTEYE = "Left Eye"; OPTVAL_RIGHTEYE = "Right Eye"; +OPTVAL_SBSFULL = "Side-by-side Full"; OPTVAL_SBSNARROW = "Side-by-side Narrow"; OPTVAL_QUADBUFFERED = "Quad-buffered"; OPTVAL_UNCHARTED2 = "Uncharted 2"; diff --git a/wadsrc/static/menudef.z b/wadsrc/static/menudef.z index 28c343c2af..1ab4f1a6d5 100644 --- a/wadsrc/static/menudef.z +++ b/wadsrc/static/menudef.z @@ -167,6 +167,7 @@ OptionValue VRMode 1, "$OPTVAL_GREENMAGENTA" 2, "$OPTVAL_REDCYAN" 9, "$OPTVAL_AMBERBLUE" + 3, "$OPTVAL_SBSFULL" 4, "$OPTVAL_SBSNARROW" 5, "$OPTVAL_LEFTEYE" 6, "$OPTVAL_RIGHTEYE" From d10a0309abb56b36eb3e6492ce832525ee8b1307 Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Sun, 11 Sep 2016 15:02:50 -0400 Subject: [PATCH 18/27] Update header comment in gl_sidebyside3d source files --- src/gl/stereo3d/gl_sidebyside3d.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gl/stereo3d/gl_sidebyside3d.cpp b/src/gl/stereo3d/gl_sidebyside3d.cpp index 8a66fc91cb..57fc8aac96 100644 --- a/src/gl/stereo3d/gl_sidebyside3d.cpp +++ b/src/gl/stereo3d/gl_sidebyside3d.cpp @@ -1,6 +1,6 @@ /* ** gl_sidebyside3d.cpp -** Color mask based stereoscopic 3D modes for GZDoom +** Mosaic image stereoscopic 3D modes for GZDoom ** **--------------------------------------------------------------------------- ** Copyright 2016 Christopher Bruns From 7b8847c6be41948079570f4ebf6df35082a3579f Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Sun, 11 Sep 2016 15:04:06 -0400 Subject: [PATCH 19/27] Update comment for other file. --- src/gl/stereo3d/gl_sidebyside3d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gl/stereo3d/gl_sidebyside3d.h b/src/gl/stereo3d/gl_sidebyside3d.h index c79c0c4b45..68ce88f6af 100644 --- a/src/gl/stereo3d/gl_sidebyside3d.h +++ b/src/gl/stereo3d/gl_sidebyside3d.h @@ -1,6 +1,6 @@ /* ** gl_sidebyside3d.h -** Color mask based stereoscopic 3D modes for GZDoom +** Mosaic image stereoscopic 3D modes for GZDoom ** **--------------------------------------------------------------------------- ** Copyright 2016 Christopher Bruns From a5c27af59bd902b53fb8d560b17738ecfe674ae1 Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Mon, 19 Sep 2016 20:06:52 -0400 Subject: [PATCH 20/27] Show weapon at full width in SideBySideFull 3D mode. (cherry picked from commit c42e98c0042937adc05c1f1569d909d58a5b8ffb) --- src/gl/scene/gl_scene.cpp | 5 ++++- src/gl/stereo3d/gl_sidebyside3d.cpp | 10 ++++++++++ src/gl/stereo3d/gl_sidebyside3d.h | 1 + src/gl/stereo3d/gl_stereo3d.h | 2 ++ 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gl/scene/gl_scene.cpp b/src/gl/scene/gl_scene.cpp index 6ddd12a1f6..425841333f 100644 --- a/src/gl/scene/gl_scene.cpp +++ b/src/gl/scene/gl_scene.cpp @@ -660,6 +660,9 @@ void FGLRenderer::EndDrawScene(sector_t * viewsector) framebuffer->Begin2D(false); Reset3DViewport(); + + s3d::Stereo3DMode::getCurrentMode().AdjustPlayerSprites(); + // [BB] Only draw the sprites if we didn't render a HUD model before. if ( renderHUDModel == false ) { @@ -820,7 +823,7 @@ sector_t * FGLRenderer::RenderViewpoint (AActor * camera, GL_IRECT * bounds, flo clipper.SafeAddClipRangeRealAngles(ViewAngle.BAMs() + a1, ViewAngle.BAMs() - a1); ProcessScene(toscreen); - if (mainview && toscreen) EndDrawScene(lviewsector); // do not call this for camera textures. + if (mainview && toscreen) EndDrawScene(lviewsector); // do not call this for camera textures. if (mainview && FGLRenderBuffers::IsEnabled()) { mBuffers->BlitSceneToTexture(); diff --git a/src/gl/stereo3d/gl_sidebyside3d.cpp b/src/gl/stereo3d/gl_sidebyside3d.cpp index 57fc8aac96..c6463d2c8b 100644 --- a/src/gl/stereo3d/gl_sidebyside3d.cpp +++ b/src/gl/stereo3d/gl_sidebyside3d.cpp @@ -98,4 +98,14 @@ SideBySideFull::SideBySideFull(double ipdMeters) eye_ptrs.Push(&rightEye); } +/* virtual */ +void SideBySideFull::AdjustPlayerSprites() const /* override */ +{ + // Show weapon at double width, so it would appear normal width after rescaling + int w = GLRenderer->mScreenViewport.width; + int h = GLRenderer->mScreenViewport.height; + gl_RenderState.mProjectionMatrix.ortho(w/2, w + w/2, h, 0, -1.0f, 1.0f); + gl_RenderState.ApplyMatrices(); +} + } /* namespace s3d */ diff --git a/src/gl/stereo3d/gl_sidebyside3d.h b/src/gl/stereo3d/gl_sidebyside3d.h index 68ce88f6af..374f255c59 100644 --- a/src/gl/stereo3d/gl_sidebyside3d.h +++ b/src/gl/stereo3d/gl_sidebyside3d.h @@ -82,6 +82,7 @@ class SideBySideFull : public SideBySideBase public: static const SideBySideFull& getInstance(float ipd); SideBySideFull(double ipdMeters); + virtual void AdjustPlayerSprites() const override; private: SBSFLeftEyePose leftEye; SBSFRightEyePose rightEye; diff --git a/src/gl/stereo3d/gl_stereo3d.h b/src/gl/stereo3d/gl_stereo3d.h index 747bcd0c0d..c55154e514 100644 --- a/src/gl/stereo3d/gl_stereo3d.h +++ b/src/gl/stereo3d/gl_stereo3d.h @@ -58,6 +58,7 @@ public: virtual void GetViewShift(float yaw, float outViewShift[3]) const; virtual void SetUp() const {}; virtual void TearDown() const {}; + // virtual void EndDrawScene(sector_t * viewsector) const {GLRenderer->EndDrawScene(viewsector);}; }; @@ -80,6 +81,7 @@ public: virtual bool IsMono() const { return false; } virtual void AdjustViewports() const {}; + virtual void AdjustPlayerSprites() const {}; virtual void Present() const = 0; protected: From a1cbd39f3f61964e03253514a80662dfdf7fcda3 Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Mon, 19 Sep 2016 21:21:20 -0400 Subject: [PATCH 21/27] Move call to Stereo3DMode.AdjustPlayerSprites into FGLRenderer.DrawPlayerSprites() (cherry picked from commit 5b5598d7d85c6bb8930e874d5d94cca835061bf0) --- src/gl/scene/gl_scene.cpp | 2 -- src/gl/scene/gl_weapon.cpp | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gl/scene/gl_scene.cpp b/src/gl/scene/gl_scene.cpp index 425841333f..246057ad26 100644 --- a/src/gl/scene/gl_scene.cpp +++ b/src/gl/scene/gl_scene.cpp @@ -661,8 +661,6 @@ void FGLRenderer::EndDrawScene(sector_t * viewsector) Reset3DViewport(); - s3d::Stereo3DMode::getCurrentMode().AdjustPlayerSprites(); - // [BB] Only draw the sprites if we didn't render a HUD model before. if ( renderHUDModel == false ) { diff --git a/src/gl/scene/gl_weapon.cpp b/src/gl/scene/gl_weapon.cpp index d8400aaf66..cfa5c05d71 100644 --- a/src/gl/scene/gl_weapon.cpp +++ b/src/gl/scene/gl_weapon.cpp @@ -46,6 +46,7 @@ #include "gl/shaders/gl_shader.h" #include "gl/textures/gl_material.h" #include "gl/renderer/gl_quaddrawer.h" +#include "gl/stereo3d/gl_stereo3d.h" EXTERN_CVAR (Bool, r_drawplayersprites) EXTERN_CVAR(Float, transsouls) @@ -198,6 +199,8 @@ void FGLRenderer::DrawPlayerSprites(sector_t * viewsector, bool hudModelStep) AActor * playermo=players[consoleplayer].camera; player_t * player=playermo->player; + s3d::Stereo3DMode::getCurrentMode().AdjustPlayerSprites(); + // this is the same as the software renderer if (!player || !r_drawplayersprites || From 2e8d2ed62681316389e226e71fd3c8b85d53fbd5 Mon Sep 17 00:00:00 2001 From: Christopher Bruns Date: Tue, 20 Sep 2016 18:14:14 -0400 Subject: [PATCH 22/27] Implement vr_swap_eyes CVAR, now that side-by-side mode is mostly working. --- src/gl/stereo3d/gl_stereo3d.h | 1 - src/gl/stereo3d/gl_stereo_cvars.cpp | 3 +++ src/gl/stereo3d/gl_stereo_leftright.cpp | 11 ++++++++--- src/gl/stereo3d/gl_stereo_leftright.h | 11 +++++++---- 4 files changed, 18 insertions(+), 8 deletions(-) diff --git a/src/gl/stereo3d/gl_stereo3d.h b/src/gl/stereo3d/gl_stereo3d.h index c55154e514..81a72874f8 100644 --- a/src/gl/stereo3d/gl_stereo3d.h +++ b/src/gl/stereo3d/gl_stereo3d.h @@ -58,7 +58,6 @@ public: virtual void GetViewShift(float yaw, float outViewShift[3]) const; virtual void SetUp() const {}; virtual void TearDown() const {}; - // virtual void EndDrawScene(sector_t * viewsector) const {GLRenderer->EndDrawScene(viewsector);}; }; diff --git a/src/gl/stereo3d/gl_stereo_cvars.cpp b/src/gl/stereo3d/gl_stereo_cvars.cpp index 0927829fc3..c09a7a9749 100644 --- a/src/gl/stereo3d/gl_stereo_cvars.cpp +++ b/src/gl/stereo3d/gl_stereo_cvars.cpp @@ -35,6 +35,9 @@ // Set up 3D-specific console variables: CVAR(Int, vr_mode, 0, CVAR_GLOBALCONFIG) +// switch left and right eye views +CVAR(Bool, vr_swap_eyes, false, CVAR_GLOBALCONFIG) + // For broadest GL compatibility, require user to explicitly enable quad-buffered stereo mode. // Setting vr_enable_quadbuffered_stereo does not automatically invoke quad-buffered stereo, // but makes it possible for subsequent "vr_mode 7" to invoke quad-buffered stereo diff --git a/src/gl/stereo3d/gl_stereo_leftright.cpp b/src/gl/stereo3d/gl_stereo_leftright.cpp index 1919e320f6..f2b1ba3fc4 100644 --- a/src/gl/stereo3d/gl_stereo_leftright.cpp +++ b/src/gl/stereo3d/gl_stereo_leftright.cpp @@ -37,6 +37,7 @@ EXTERN_CVAR(Float, vr_screendist) EXTERN_CVAR(Float, vr_hunits_per_meter) +EXTERN_CVAR(Bool, vr_swap_eyes) namespace s3d { @@ -50,7 +51,7 @@ VSMatrix ShiftedEyePose::GetProjection(float fov, float aspectRatio, float fovRa // For stereo 3D, use asymmetric frustum shift in projection matrix // Q: shouldn't shift vary with roll angle, at least for desktop display? // A: No. (lab) roll is not measured on desktop display (yet) - double frustumShift = zNear * shift / vr_screendist; // meters cancel, leaving doom units + double frustumShift = zNear * getShift() / vr_screendist; // meters cancel, leaving doom units // double frustumShift = 0; // Turning off shift for debugging double fH = zNear * tan(DEG2RAD(fov) / 2) / fovRatio; double fW = fH * aspectRatio; @@ -68,13 +69,17 @@ VSMatrix ShiftedEyePose::GetProjection(float fov, float aspectRatio, float fovRa /* virtual */ void ShiftedEyePose::GetViewShift(float yaw, float outViewShift[3]) const { - float dx = -cos(DEG2RAD(yaw)) * vr_hunits_per_meter * shift; - float dy = sin(DEG2RAD(yaw)) * vr_hunits_per_meter * shift; + float dx = -cos(DEG2RAD(yaw)) * vr_hunits_per_meter * getShift(); + float dy = sin(DEG2RAD(yaw)) * vr_hunits_per_meter * getShift(); outViewShift[0] = dx; outViewShift[1] = dy; outViewShift[2] = 0; } +float ShiftedEyePose::getShift() const +{ + return vr_swap_eyes ? -shift : shift; +} /* static */ const LeftEyeView& LeftEyeView::getInstance(float ipd) diff --git a/src/gl/stereo3d/gl_stereo_leftright.h b/src/gl/stereo3d/gl_stereo_leftright.h index 2070ff53a0..9fa7b40bcd 100644 --- a/src/gl/stereo3d/gl_stereo_leftright.h +++ b/src/gl/stereo3d/gl_stereo_leftright.h @@ -37,11 +37,14 @@ class ShiftedEyePose : public EyePose { public: ShiftedEyePose(float shift) : shift(shift) {}; - float getShift() const { return shift; } - void setShift(float shift) { this->shift = shift; } + float getShift() const; virtual VSMatrix GetProjection(float fov, float aspectRatio, float fovRatio) const; virtual void GetViewShift(float yaw, float outViewShift[3]) const; + protected: + void setShift(float shift) { this->shift = shift; } + +private: float shift; }; @@ -50,7 +53,7 @@ class LeftEyePose : public ShiftedEyePose { public: LeftEyePose(float ipd) : ShiftedEyePose( float(-0.5) * ipd) {} - float getIpd() const { return float(-2.0)*getShift(); } + float getIpd() const { return float(fabs(2.0f*getShift())); } void setIpd(float ipd) { setShift(float(-0.5)*ipd); } }; @@ -59,7 +62,7 @@ class RightEyePose : public ShiftedEyePose { public: RightEyePose(float ipd) : ShiftedEyePose(float(+0.5)*ipd) {} - float getIpd() const { return float(+2.0)*shift; } + float getIpd() const { return float(fabs(2.0f*getShift())); } void setIpd(float ipd) { setShift(float(+0.5)*ipd); } }; From 0a98fb0be7c9f0ee64b798cbe0a27b83de096703 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Thu, 22 Sep 2016 09:32:04 +0200 Subject: [PATCH 23/27] - integrated dynamic light definitions into regular DECORATE as another include. - renamed menudef.z zo menudef.zz. This was done because some tool out there stupidly assume that *.z is some sort of archive and refuse to operate on these files (shame on you, Beyond Compare!) --- wadsrc/static/{decorate.z => actors/shared/dynlights.txt} | 0 wadsrc/static/decorate.txt | 1 + wadsrc/static/{menudef.z => menudef.zz} | 0 3 files changed, 1 insertion(+) rename wadsrc/static/{decorate.z => actors/shared/dynlights.txt} (100%) rename wadsrc/static/{menudef.z => menudef.zz} (100%) diff --git a/wadsrc/static/decorate.z b/wadsrc/static/actors/shared/dynlights.txt similarity index 100% rename from wadsrc/static/decorate.z rename to wadsrc/static/actors/shared/dynlights.txt diff --git a/wadsrc/static/decorate.txt b/wadsrc/static/decorate.txt index c6a205d42a..71c7d549b5 100644 --- a/wadsrc/static/decorate.txt +++ b/wadsrc/static/decorate.txt @@ -30,6 +30,7 @@ #include "actors/shared/action.txt" #include "actors/shared/dog.txt" #include "actors/shared/damagetypes.txt" +#include "actors/shared/dynlights.txt" #include "actors/doom/doomplayer.txt" #include "actors/doom/possessed.txt" diff --git a/wadsrc/static/menudef.z b/wadsrc/static/menudef.zz similarity index 100% rename from wadsrc/static/menudef.z rename to wadsrc/static/menudef.zz From 52d4c3970e3241a60a61dc5c304f8f425d14d9e2 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Thu, 22 Sep 2016 10:00:40 +0200 Subject: [PATCH 24/27] - use glPOlygonOffset on non-translucent flat and wall sprites to avoid z-fighting. --- src/gl/scene/gl_sprite.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/gl/scene/gl_sprite.cpp b/src/gl/scene/gl_sprite.cpp index 720df3b2b5..123bf258cb 100644 --- a/src/gl/scene/gl_sprite.cpp +++ b/src/gl/scene/gl_sprite.cpp @@ -310,6 +310,11 @@ void GLSprite::Draw(int pass) additivefog = true; } } + else if (modelframe == nullptr) + { + glEnable(GL_POLYGON_OFFSET_FILL); + glPolygonOffset(-1.0f, -128.0f); + } if (RenderStyle.BlendOp!=STYLEOP_Shadow) { if (gl_lights && GLRenderer->mLightCount && !gl_fixedcolormap && !fullbright) @@ -440,6 +445,11 @@ void GLSprite::Draw(int pass) gl_RenderState.BlendEquation(GL_FUNC_ADD); gl_RenderState.SetTextureMode(TM_MODULATE); } + else if (modelframe == nullptr) + { + glPolygonOffset(0.0f, 0.0f); + glDisable(GL_POLYGON_OFFSET_FILL); + } gl_RenderState.SetObjectColor(0xffffffff); gl_RenderState.EnableTexture(true); From 960ed5130c5b48d4708296ef5b86194417c9b5f8 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Thu, 22 Sep 2016 10:20:36 +0200 Subject: [PATCH 25/27] - fixed: DTA_ColorOverlay was not properly handled by F2DDrawer. --- src/gl/renderer/gl_2ddrawer.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gl/renderer/gl_2ddrawer.cpp b/src/gl/renderer/gl_2ddrawer.cpp index 082e51ca4d..ba78634a3e 100644 --- a/src/gl/renderer/gl_2ddrawer.cpp +++ b/src/gl/renderer/gl_2ddrawer.cpp @@ -160,6 +160,7 @@ void F2DDrawer::AddTexture(FTexture *img, DrawParms &parms) ptr->Set(x, y + h, 0, u1, v2, color); ptr++; ptr->Set(x + w, y, 0, u2, v1, color); ptr++; ptr->Set(x + w, y + h, 0, u2, v2, color); ptr++; + dg.mVertCount = 8; } AddData(&dg); } From 1bddc277e6e56b18cd4512dbc1365abd6689fb24 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Thu, 22 Sep 2016 10:28:14 +0200 Subject: [PATCH 26/27] - fixed winding of voxel polygons. --- src/gl/models/gl_voxels.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gl/models/gl_voxels.cpp b/src/gl/models/gl_voxels.cpp index d37bdf8a0f..6213eb0068 100644 --- a/src/gl/models/gl_voxels.cpp +++ b/src/gl/models/gl_voxels.cpp @@ -275,8 +275,8 @@ void FVoxelModel::AddFace(int x1, int y1, int z1, int x2, int y2, int z2, int x3 mIndices.Push(indx[1]); mIndices.Push(indx[3]); mIndices.Push(indx[1]); - mIndices.Push(indx[3]); mIndices.Push(indx[2]); + mIndices.Push(indx[3]); } //=========================================================================== From 18ee6353fa605c830aba65c1db2f70885e9cd180 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Thu, 22 Sep 2016 10:54:16 +0200 Subject: [PATCH 27/27] - let's be safe and set the proper texture mode for the fullscreen blend rect. I've got spurious reports that on some occasions it was rendered opaque. --- src/gl/scene/gl_scene.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gl/scene/gl_scene.cpp b/src/gl/scene/gl_scene.cpp index 246057ad26..528925b7a2 100644 --- a/src/gl/scene/gl_scene.cpp +++ b/src/gl/scene/gl_scene.cpp @@ -622,6 +622,7 @@ void FGLRenderer::DrawBlend(sector_t * viewsector) V_AddBlend (player->BlendR, player->BlendG, player->BlendB, player->BlendA, blend); } + gl_RenderState.SetTextureMode(TM_MODULATE); gl_RenderState.BlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); if (blend[3]>0.0f) {