From 2855b1c4ae0ff1b593ecd820bd8fdd939465d733 Mon Sep 17 00:00:00 2001 From: Magnus Norddahl Date: Sun, 14 Feb 2021 19:10:59 +0100 Subject: [PATCH] Fix line portal clipping bug --- src/rendering/swrenderer/line/r_line.cpp | 2 -- .../swrenderer/segments/r_portalsegment.cpp | 12 ------------ 2 files changed, 14 deletions(-) diff --git a/src/rendering/swrenderer/line/r_line.cpp b/src/rendering/swrenderer/line/r_line.cpp index eaa2a80b04..e2e08b268d 100644 --- a/src/rendering/swrenderer/line/r_line.cpp +++ b/src/rendering/swrenderer/line/r_line.cpp @@ -314,8 +314,6 @@ namespace swrenderer if (markportal) { - draw_segment->drawsegclip.SetTopClip(Thread, start, stop, Thread->OpaquePass->ceilingclip); - draw_segment->drawsegclip.SetBottomClip(Thread, start, stop, Thread->OpaquePass->floorclip); draw_segment->drawsegclip.silhouette = SIL_BOTH; } else if (!mBackSector) diff --git a/src/rendering/swrenderer/segments/r_portalsegment.cpp b/src/rendering/swrenderer/segments/r_portalsegment.cpp index d8aff120a0..6f69c7869f 100644 --- a/src/rendering/swrenderer/segments/r_portalsegment.cpp +++ b/src/rendering/swrenderer/segments/r_portalsegment.cpp @@ -55,18 +55,6 @@ namespace swrenderer memcpy(ceilingclip, topclip + x1, len * sizeof(short)); memcpy(floorclip, bottomclip + x1, len * sizeof(short)); - for (int i = 0; i < x2 - x1; i++) - { - if (ceilingclip[i] < 0) - ceilingclip[i] = 0; - if (ceilingclip[i] >= viewheight) - ceilingclip[i] = viewheight - 1; - if (floorclip[i] < 0) - floorclip[i] = 0; - if (floorclip[i] >= viewheight) - floorclip[i] = viewheight - 1; - } - mirror = linedef->special == Line_Mirror; } }