From 75855dc64a133a61cdc559b5520ad127540bf037 Mon Sep 17 00:00:00 2001 From: MajorCooke Date: Wed, 25 Nov 2015 01:44:19 -0600 Subject: [PATCH 1/5] A_FaceVelocity(offset, flags, ptr) - Changes the caller's angle and pitch according to the direction of velocity they're travelling. - FVF_NOPITCH and FVF_NOANGLE disable changing of pitch/angle respectively and should be counted as mutually exclusive, or the function does nothing. - FVF_INTERPOLATE - Interpolate's the angle and pitch changes. - FVF_RESETPITCH will, if there's no z velocity, reset the pitch to 0. Otherwise, the pitch remains unchanged. --- src/thingdef/thingdef_codeptr.cpp | 51 ++++++++++++++++++++++++++++++ wadsrc/static/actors/actor.txt | 1 + wadsrc/static/actors/constants.txt | 9 ++++++ 3 files changed, 61 insertions(+) diff --git a/src/thingdef/thingdef_codeptr.cpp b/src/thingdef/thingdef_codeptr.cpp index 60a2318b4e..3e5a4dc10b 100644 --- a/src/thingdef/thingdef_codeptr.cpp +++ b/src/thingdef/thingdef_codeptr.cpp @@ -5930,4 +5930,55 @@ DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_CheckBlock) { ACTION_JUMP(block); } +} + +//=========================================================================== +// +// A_FaceVelocity(angle offset, bool pitch, ptr) +// +// Sets the actor('s pointer) to face the direction of travel. +//=========================================================================== +enum FVFlags +{ + FVF_NOPITCH = 1 << 0, + FVF_INTERPOLATE = 1 << 1, + FVF_NOANGLE = 1 << 2, + FVF_RESETPITCH = 1 << 3, +}; +DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) +{ + ACTION_PARAM_START(3); + ACTION_PARAM_FIXED(offset, 0) + ACTION_PARAM_INT(flags, 1); + ACTION_PARAM_INT(ptr, 2); + + AActor *mobj = COPY_AAPTR(self, ptr); + + //Need an actor. + if (!mobj || ((flags & FVF_NOPITCH) && (flags & FVF_NOANGLE))) + { + ACTION_SET_RESULT(false); + return; + } + + //Don't bother calculating this if we don't have any horizontal movement. + if (!(flags & FVF_NOANGLE) && (mobj->velx != 0 || mobj->vely != 0)) + { + fixed_t vx = mobj->x + mobj->velx, vy = mobj->y + mobj->vely; + angle_t angle = R_PointToAngle2(mobj->x, mobj->y, vx, vy) + offset; + mobj->SetAngle(angle, !!(flags & FVF_INTERPOLATE)); + } + + if (!(flags & FVF_NOPITCH)) + { + //Reset pitch to 0 if specified. + if (mobj->velz == 0 && (flags & FVF_RESETPITCH)) + mobj->pitch = 0; + else + { + FVector2 velocity(mobj->velx, mobj->vely); + fixed_t pitch = R_PointToAngle2(0, 0, (fixed_t)velocity.Length(), mobj->velz); + mobj->SetPitch(-pitch, !!(flags & FVF_INTERPOLATE)); + } + } } \ No newline at end of file diff --git a/wadsrc/static/actors/actor.txt b/wadsrc/static/actors/actor.txt index 7dc89f2015..22312fed8b 100644 --- a/wadsrc/static/actors/actor.txt +++ b/wadsrc/static/actors/actor.txt @@ -340,6 +340,7 @@ ACTOR Actor native //: Thinker action native A_CheckBlock(state block, int flags = 0, int ptr = AAPTR_DEFAULT); action native A_CheckSightOrRange(float distance, state label, bool two_dimension = false); action native A_CheckRange(float distance, state label, bool two_dimension = false); + action native A_FaceVelocity(float offset = 0, int flags = 0, int ptr = AAPTR_DEFAULT); action native A_RearrangePointers(int newtarget, int newmaster = AAPTR_DEFAULT, int newtracer = AAPTR_DEFAULT, int flags=0); action native A_TransferPointer(int ptr_source, int ptr_recepient, int sourcefield, int recepientfield=AAPTR_DEFAULT, int flags=0); diff --git a/wadsrc/static/actors/constants.txt b/wadsrc/static/actors/constants.txt index 7f8fbc09e2..9667db563b 100644 --- a/wadsrc/static/actors/constants.txt +++ b/wadsrc/static/actors/constants.txt @@ -495,6 +495,15 @@ enum CBF_SETONPTR = 1 << 4, //Sets the pointer change on the actor doing the checking instead of self. }; +//Flags for A_FaceVelocity +enum +{ + FVF_NOPITCH = 1 << 0, + FVF_INTERPOLATE = 1 << 1, + FVF_NOANGLE = 1 << 2, + FVF_RESETPITCH = 1 << 3, +}; + // This is only here to provide one global variable for testing. native int testglobalvar; From ab5b1f479a66912bcbe6e1fca262e6e8386b6f8a Mon Sep 17 00:00:00 2001 From: MajorCooke Date: Wed, 25 Nov 2015 21:49:25 -0600 Subject: [PATCH 2/5] Updated A_FaceVelocity. - Now includes anglelimit and pitchlimit. - Anglelimit and pitchlimit only allows the actor to turn this much, similar to A_FaceTarget's limit. FVF_RESETPITCH also respects the pitch limit. - (offset, anglelimit, pitchlimit, flags, ptr) --- src/thingdef/thingdef_codeptr.cpp | 90 ++++++++++++++++++++++++++----- wadsrc/static/actors/actor.txt | 2 +- 2 files changed, 78 insertions(+), 14 deletions(-) diff --git a/src/thingdef/thingdef_codeptr.cpp b/src/thingdef/thingdef_codeptr.cpp index 3e5a4dc10b..f244a81538 100644 --- a/src/thingdef/thingdef_codeptr.cpp +++ b/src/thingdef/thingdef_codeptr.cpp @@ -5947,10 +5947,12 @@ enum FVFlags }; DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) { - ACTION_PARAM_START(3); - ACTION_PARAM_FIXED(offset, 0) - ACTION_PARAM_INT(flags, 1); - ACTION_PARAM_INT(ptr, 2); + ACTION_PARAM_START(5); + ACTION_PARAM_ANGLE(offset, 0); + ACTION_PARAM_ANGLE(anglelimit, 1); + ACTION_PARAM_ANGLE(pitchlimit, 2); + ACTION_PARAM_INT(flags, 3); + ACTION_PARAM_INT(ptr, 4); AActor *mobj = COPY_AAPTR(self, ptr); @@ -5964,21 +5966,83 @@ DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) //Don't bother calculating this if we don't have any horizontal movement. if (!(flags & FVF_NOANGLE) && (mobj->velx != 0 || mobj->vely != 0)) { - fixed_t vx = mobj->x + mobj->velx, vy = mobj->y + mobj->vely; - angle_t angle = R_PointToAngle2(mobj->x, mobj->y, vx, vy) + offset; - mobj->SetAngle(angle, !!(flags & FVF_INTERPOLATE)); + const fixed_t vx = mobj->velx + mobj->x, vy = mobj->vely + mobj->y; + angle_t current = mobj->angle; + const angle_t angle = R_PointToAngle2(mobj->x, mobj->y, vx, vy); + //Done because using anglelimit directly causes a signed/unsigned mismatch. + const angle_t limit = anglelimit; + + //Code borrowed from A_Face*. + if (limit > 0 && (absangle(current - angle) > limit)) + { + if (current < angle) + { + // [MC] This may appear backwards, but I assure any who + // reads this, it works. + if (current - angle > ANGLE_180) + current += limit + offset; + else + current -= limit + offset; + mobj->SetAngle(current, !!(flags & FVF_INTERPOLATE)); + } + else if (current > angle) + { + if (angle - current > ANGLE_180) + current -= limit + offset; + else + current += limit + offset; + mobj->SetAngle(current, !!(flags & FVF_INTERPOLATE)); + } + else + mobj->SetAngle(angle + ANGLE_180 + offset, !!(flags & FVF_INTERPOLATE)); + + } + else + mobj->SetAngle(angle + offset, !!(flags & FVF_INTERPOLATE)); } if (!(flags & FVF_NOPITCH)) { - //Reset pitch to 0 if specified. - if (mobj->velz == 0 && (flags & FVF_RESETPITCH)) - mobj->pitch = 0; + fixed_t current = mobj->pitch; + const FVector2 velocity(mobj->velx, mobj->vely); + const fixed_t pitch = R_PointToAngle2(0, 0, (fixed_t)velocity.Length(), -mobj->velz); + if (pitchlimit > 0) + { + // [MC] angle_t for pitchlimit was required because otherwise + // we would wind up with less than desirable turn rates that didn't + // match that of A_SetPitch. We want consistency. Also, I didn't know + // of a better way to convert from angle_t to fixed_t properly so I + // used this instead. + fixed_t plimit = fixed_t(pitchlimit); + + if (abs(current - pitch) > plimit) + { + fixed_t max = 0; + + if (current > pitch) + { + max = MIN(plimit, (current - pitch)); + current -= max; + } + else //if (current > pitch) + { + max = MIN(plimit, (pitch - current)); + current += max; + } + if ((mobj->velz != 0) || (flags & FVF_RESETPITCH)) + mobj->SetPitch(current, !!(flags & FVF_INTERPOLATE)); + } + else + { + if ((mobj->velz != 0) || (flags & FVF_RESETPITCH)) + mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); + } + + } else { - FVector2 velocity(mobj->velx, mobj->vely); - fixed_t pitch = R_PointToAngle2(0, 0, (fixed_t)velocity.Length(), mobj->velz); - mobj->SetPitch(-pitch, !!(flags & FVF_INTERPOLATE)); + if ((mobj->velz != 0) || (flags & FVF_RESETPITCH)) + mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); } } } \ No newline at end of file diff --git a/wadsrc/static/actors/actor.txt b/wadsrc/static/actors/actor.txt index 22312fed8b..fc00698e72 100644 --- a/wadsrc/static/actors/actor.txt +++ b/wadsrc/static/actors/actor.txt @@ -340,7 +340,7 @@ ACTOR Actor native //: Thinker action native A_CheckBlock(state block, int flags = 0, int ptr = AAPTR_DEFAULT); action native A_CheckSightOrRange(float distance, state label, bool two_dimension = false); action native A_CheckRange(float distance, state label, bool two_dimension = false); - action native A_FaceVelocity(float offset = 0, int flags = 0, int ptr = AAPTR_DEFAULT); + action native A_FaceVelocity(float offset = 0, float anglelimit = 0, float pitchlimit = 0, int flags = 0, int ptr = AAPTR_DEFAULT); action native A_RearrangePointers(int newtarget, int newmaster = AAPTR_DEFAULT, int newtracer = AAPTR_DEFAULT, int flags=0); action native A_TransferPointer(int ptr_source, int ptr_recepient, int sourcefield, int recepientfield=AAPTR_DEFAULT, int flags=0); From a1e31128508c750036209762b51a56cf6a72545e Mon Sep 17 00:00:00 2001 From: MajorCooke Date: Wed, 25 Nov 2015 23:15:59 -0600 Subject: [PATCH 3/5] Removed FVF_RESETPITCH. --- src/thingdef/thingdef_codeptr.cpp | 13 ++++--------- wadsrc/static/actors/constants.txt | 1 - 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/thingdef/thingdef_codeptr.cpp b/src/thingdef/thingdef_codeptr.cpp index f244a81538..4ac3787508 100644 --- a/src/thingdef/thingdef_codeptr.cpp +++ b/src/thingdef/thingdef_codeptr.cpp @@ -5943,7 +5943,6 @@ enum FVFlags FVF_NOPITCH = 1 << 0, FVF_INTERPOLATE = 1 << 1, FVF_NOANGLE = 1 << 2, - FVF_RESETPITCH = 1 << 3, }; DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) { @@ -5966,9 +5965,8 @@ DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) //Don't bother calculating this if we don't have any horizontal movement. if (!(flags & FVF_NOANGLE) && (mobj->velx != 0 || mobj->vely != 0)) { - const fixed_t vx = mobj->velx + mobj->x, vy = mobj->vely + mobj->y; angle_t current = mobj->angle; - const angle_t angle = R_PointToAngle2(mobj->x, mobj->y, vx, vy); + const angle_t angle = R_PointToAngle2(0, 0, mobj->velx, mobj->vely); //Done because using anglelimit directly causes a signed/unsigned mismatch. const angle_t limit = anglelimit; @@ -6029,20 +6027,17 @@ DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) max = MIN(plimit, (pitch - current)); current += max; } - if ((mobj->velz != 0) || (flags & FVF_RESETPITCH)) - mobj->SetPitch(current, !!(flags & FVF_INTERPOLATE)); + mobj->SetPitch(current, !!(flags & FVF_INTERPOLATE)); } else { - if ((mobj->velz != 0) || (flags & FVF_RESETPITCH)) - mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); + mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); } } else { - if ((mobj->velz != 0) || (flags & FVF_RESETPITCH)) - mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); + mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); } } } \ No newline at end of file diff --git a/wadsrc/static/actors/constants.txt b/wadsrc/static/actors/constants.txt index 9667db563b..23e9a71167 100644 --- a/wadsrc/static/actors/constants.txt +++ b/wadsrc/static/actors/constants.txt @@ -501,7 +501,6 @@ enum FVF_NOPITCH = 1 << 0, FVF_INTERPOLATE = 1 << 1, FVF_NOANGLE = 1 << 2, - FVF_RESETPITCH = 1 << 3, }; // This is only here to provide one global variable for testing. From 7725e9d6410c94bb4ef515cff2996c55b0fc7a6b Mon Sep 17 00:00:00 2001 From: MajorCooke Date: Wed, 25 Nov 2015 23:17:13 -0600 Subject: [PATCH 4/5] New line. --- src/thingdef/thingdef_codeptr.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/thingdef/thingdef_codeptr.cpp b/src/thingdef/thingdef_codeptr.cpp index 4ac3787508..182dc47434 100644 --- a/src/thingdef/thingdef_codeptr.cpp +++ b/src/thingdef/thingdef_codeptr.cpp @@ -6040,4 +6040,4 @@ DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) mobj->SetPitch(pitch, !!(flags & FVF_INTERPOLATE)); } } -} \ No newline at end of file +} From 116e1574473fac7e75b4a0aa74da6a3601164d06 Mon Sep 17 00:00:00 2001 From: MajorCooke Date: Wed, 20 Jan 2016 15:52:56 -0600 Subject: [PATCH 5/5] Nevermind this. --- src/thingdef/thingdef_codeptr.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/thingdef/thingdef_codeptr.cpp b/src/thingdef/thingdef_codeptr.cpp index 5c6198d460..36f9b6c399 100644 --- a/src/thingdef/thingdef_codeptr.cpp +++ b/src/thingdef/thingdef_codeptr.cpp @@ -6125,7 +6125,6 @@ DEFINE_ACTION_FUNCTION_PARAMS(AActor, A_FaceVelocity) fixed_t current = mobj->pitch; const FVector2 velocity(mobj->velx, mobj->vely); const fixed_t pitch = R_PointToAngle2(0, 0, (fixed_t)velocity.Length(), -mobj->velz); - fixedvec2 test; if (pitchlimit > 0) { // [MC] angle_t for pitchlimit was required because otherwise