- Added coordinate range checking to DCanvas::ParseDrawTextureTags() to avoid

potential crashes in the situation that con_scaletext is 2 and somebody
  uses a hud message as if a hud size was specified, but forgot to actually
  set the hud size.


SVN r1010 (trunk)
This commit is contained in:
Randy Heit 2008-06-01 04:09:49 +00:00
parent 4850a98c13
commit ff43b7e913
2 changed files with 10 additions and 0 deletions

View file

@ -1,4 +1,8 @@
May 31, 2008
- Added coordinate range checking to DCanvas::ParseDrawTextureTags() to avoid
potential crashes in the situation that con_scaletext is 2 and somebody
uses a hud message as if a hud size was specified, but forgot to actually
set the hud size.
- Consolidated the mug shot code shared by DSBarInfo and DDoomStatusBar
into a single place.
- Fixed: Setting an invalid mug shot state crashed the game.

View file

@ -298,6 +298,12 @@ bool DCanvas::ParseDrawTextureTags (FTexture *img, int x, int y, DWORD tag, va_l
return false;
}
// Do some sanity checks on the coordinates.
if (x < -16383 || x > 16383 || y < -16383 || y > 16383)
{
return false;
}
virtBottom = false;
parms->texwidth = img->GetScaledWidth();