From f76d137d33b32208cc7809221c0879889f2ab596 Mon Sep 17 00:00:00 2001
From: Randy Heit <rheit@users.noreply.github.com>
Date: Fri, 26 Dec 2014 18:58:59 -0600
Subject: [PATCH] Be less ugly when hiding warnings for using the %B formatter

- Take advantage of the new _Pragma operator to hide the printf warning
  suppression inside of macros instead of needing to litter the code
  around Printfs with a bunch of junk.
---
 src/p_3dfloors.cpp |  2 ++
 src/p_acs.cpp      | 17 ++---------------
 src/zstring.h      | 18 ++++++++++++++++++
 3 files changed, 22 insertions(+), 15 deletions(-)

diff --git a/src/p_3dfloors.cpp b/src/p_3dfloors.cpp
index d13e46204..fc35409dc 100644
--- a/src/p_3dfloors.cpp
+++ b/src/p_3dfloors.cpp
@@ -968,10 +968,12 @@ CCMD (dump3df)
 			fixed_t height=ffloors[i]->top.plane->ZatPoint(CenterSpot(sector));
 			fixed_t bheight=ffloors[i]->bottom.plane->ZatPoint(CenterSpot(sector));
 
+			IGNORE_FORMAT_PRE
 			Printf("FFloor %d @ top = %f (model = %d), bottom = %f (model = %d), flags = %B, alpha = %d %s %s\n", 
 				i, height / 65536., ffloors[i]->top.model->sectornum, 
 				bheight / 65536., ffloors[i]->bottom.model->sectornum,
 				ffloors[i]->flags, ffloors[i]->alpha, (ffloors[i]->flags&FF_EXISTS)? "Exists":"", (ffloors[i]->flags&FF_DYNAMIC)? "Dynamic":"");
+			IGNORE_FORMAT_POST
 		}
 	}
 }
diff --git a/src/p_acs.cpp b/src/p_acs.cpp
index 2929eb32a..2ea64f26e 100644
--- a/src/p_acs.cpp
+++ b/src/p_acs.cpp
@@ -7496,22 +7496,9 @@ scriptwait:
 			break;
 
 		case PCD_PRINTBINARY:
-#if (defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && (__GNUC_MINOR__ >= 6)))) || defined(__clang__)
-#define HAS_DIAGNOSTIC_PRAGMA
-#endif
-#ifdef HAS_DIAGNOSTIC_PRAGMA
-#pragma GCC diagnostic push
-#ifdef __clang__
-#pragma GCC diagnostic ignored "-Wformat-invalid-specifier"
-#else
-#pragma GCC diagnostic ignored "-Wformat="
-#endif
-#pragma GCC diagnostic ignored "-Wformat-extra-args"
-#endif
+			IGNORE_FORMAT_PRE
 			work.AppendFormat ("%B", STACK(1));
-#ifdef HAS_DIAGNOSTIC_PRAGMA
-#pragma GCC diagnostic pop
-#endif
+			IGNORE_FORMAT_POST
 			--sp;
 			break;
 
diff --git a/src/zstring.h b/src/zstring.h
index 1736f3421..fe7ee72cf 100644
--- a/src/zstring.h
+++ b/src/zstring.h
@@ -47,6 +47,24 @@
 #define PRINTFISH(x)
 #endif
 
+#ifdef __clang__
+#define IGNORE_FORMAT_PRE \
+	_Pragma("GCC diagnostic push" \
+	_Pragma("GCC diagnostic ignored \"-Wformat-invalid-specifier\"") \
+	_Pragma("GCC diagnostic ignored \"-Wformat-extra-args\"")
+#define IGNORE_FORMAT_POST _Pragma("GCC diagnostic pop")
+#elif defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && (__GNUC_MINOR__ >= 6)))
+#define IGNORE_FORMAT_PRE \
+	_Pragma("GCC diagnostic push" \
+	_Pragma("GCC diagnostic ignored \"-Wformat=\"") \
+	_Pragma("GCC diagnostic ignored \"-Wformat-extra-args\"")
+#define IGNORE_FORMAT_POST _Pragma("GCC diagnostic pop")
+#else
+#define IGNORE_FORMAT_PRE
+#define IGNORE_FORMAT_POST
+#endif
+
+
 struct FStringData
 {
 	unsigned int Len;		// Length of string, excluding terminating null