From e2a2d38a25c04b5a5584ba7f410bf763f8d055a9 Mon Sep 17 00:00:00 2001
From: "alexey.lysiuk" <alexey.lysiuk@gmail.com>
Date: Sat, 30 Jul 2016 10:25:42 +0300
Subject: [PATCH] Removed redundant comparison in compatibility renderer

Clang no longer reports "warning: comparison of array 'this->tcs' not equal to a null pointer is always true"
---
 src/gl/compatibility/gl_20.cpp | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/src/gl/compatibility/gl_20.cpp b/src/gl/compatibility/gl_20.cpp
index 27f08a344..fb4064d3b 100644
--- a/src/gl/compatibility/gl_20.cpp
+++ b/src/gl/compatibility/gl_20.cpp
@@ -705,28 +705,25 @@ bool GLWall::PrepareLight(ADynamicLight * light, int pass)
 		return false;
 	}
 
-	if (tcs != NULL)
+	Vector t1;
+	int outcnt[4] = { 0,0,0,0 };
+
+	for (int i = 0; i<4; i++)
 	{
-		Vector t1;
-		int outcnt[4] = { 0,0,0,0 };
+		t1.Set(&vtx[i * 3]);
+		Vector nearToVert = t1 - nearPt;
+		tcs[i].u = (nearToVert.Dot(right) * scale) + 0.5f;
+		tcs[i].v = (nearToVert.Dot(up) * scale) + 0.5f;
 
-		for (int i = 0; i<4; i++)
-		{
-			t1.Set(&vtx[i * 3]);
-			Vector nearToVert = t1 - nearPt;
-			tcs[i].u = (nearToVert.Dot(right) * scale) + 0.5f;
-			tcs[i].v = (nearToVert.Dot(up) * scale) + 0.5f;
+		// quick check whether the light touches this polygon
+		if (tcs[i].u<0) outcnt[0]++;
+		if (tcs[i].u>1) outcnt[1]++;
+		if (tcs[i].v<0) outcnt[2]++;
+		if (tcs[i].v>1) outcnt[3]++;
 
-			// quick check whether the light touches this polygon
-			if (tcs[i].u<0) outcnt[0]++;
-			if (tcs[i].u>1) outcnt[1]++;
-			if (tcs[i].v<0) outcnt[2]++;
-			if (tcs[i].v>1) outcnt[3]++;
-
-		}
-		// The light doesn't touch this polygon
-		if (outcnt[0] == 4 || outcnt[1] == 4 || outcnt[2] == 4 || outcnt[3] == 4) return false;
 	}
+	// The light doesn't touch this polygon
+	if (outcnt[0] == 4 || outcnt[1] == 4 || outcnt[2] == 4 || outcnt[3] == 4) return false;
 
 	draw_dlight++;
 	return true;