- made GetClassName an intrinsic and expanded it to also work on class types.

src/dobject.cpp

@@ -612,12 +612,6 @@ void DObject::CheckIfSerialized () const
 }
 
 
-DEFINE_ACTION_FUNCTION(DObject, GetClassName)
-{
-	PARAM_SELF_PROLOGUE(DObject);
-	ACTION_RETURN_INT(self->GetClass()->TypeName);
-}
-
 DEFINE_ACTION_FUNCTION(DObject, MSTime)
 {
 	ACTION_RETURN_INT(I_MSTime());

src/namedef.h

@@ -335,6 +335,7 @@ xx(RandomPick)
 xx(FRandomPick)
 xx(GetClass)
 xx(GetParentClass)
+xx(GetClassName)
 xx(GetDefaultByType)
 xx(Exp)
 xx(Log10)

src/scripting/backend/codegen.cpp

@@ -7775,6 +7775,13 @@ FxExpression *FxFunctionCall::Resolve(FCompileContext& ctx)
 		}
 		break;
 
+	case NAME_GetClassName:
+		if (CheckArgSize(NAME_GetClassName, ArgList, 0, 0, ScriptPosition))
+		{
+			func = new FxGetClassName(new FxSelf(ScriptPosition));
+		}
+		break;
+
 	case NAME_GetDefaultByType:
 		if (CheckArgSize(NAME_GetDefaultByType, ArgList, 1, 1, ScriptPosition))
 		{
@@ -8215,15 +8222,21 @@ FxExpression *FxMemberFunctionCall::Resolve(FCompileContext& ctx)
 	if (MethodName == NAME_GetParentClass &&
 		(Self->IsObject() || Self->ValueType->isClassPointer()))
 	{
-		if (ArgList.Size() > 0)
+		if (CheckArgSize(NAME_GetParentClass, ArgList, 0, 0, ScriptPosition))
 		{
-			ScriptPosition.Message(MSG_ERROR, "too many parameters in call to %s", MethodName.GetChars());
-			delete this;
-			return nullptr;
-		}
 			auto x = new FxGetParentClass(Self);
 			return x->Resolve(ctx);
 		}
+	}
+	if (MethodName == NAME_GetClassName &&
+		(Self->IsObject() || Self->ValueType->isClassPointer()))
+	{
+		if (CheckArgSize(NAME_GetClassName, ArgList, 0, 0, ScriptPosition))
+		{
+			auto x = new FxGetClassName(Self);
+			return x->Resolve(ctx);
+		}
+	}
 
 	if (Self->ValueType->isRealPointer())
 	{
@@ -9336,11 +9349,11 @@ FxExpression *FxGetParentClass::Resolve(FCompileContext &ctx)
 
 	if (!Self->ValueType->isClassPointer() && !Self->IsObject())
 	{
-		ScriptPosition.Message(MSG_ERROR, "GetClass() requires an object");
+		ScriptPosition.Message(MSG_ERROR, "GetParentClass() requires an object");
 		delete this;
 		return nullptr;
 	}
-	ValueType = NewClassPointer(RUNTIME_CLASS(DObject)); // 
+	ValueType = NewClassPointer(RUNTIME_CLASS(DObject));
 	return this;
 }
 
@@ -9365,6 +9378,52 @@ ExpEmit FxGetParentClass::Emit(VMFunctionBuilder *build)
 //
 //==========================================================================
 
+FxGetClassName::FxGetClassName(FxExpression *self)
+	:FxExpression(EFX_GetClassName, self->ScriptPosition)
+{
+	Self = self;
+}
+
+FxGetClassName::~FxGetClassName()
+{
+	SAFE_DELETE(Self);
+}
+
+FxExpression *FxGetClassName::Resolve(FCompileContext &ctx)
+{
+	SAFE_RESOLVE(Self, ctx);
+
+	if (!Self->ValueType->isClassPointer() && !Self->IsObject())
+	{
+		ScriptPosition.Message(MSG_ERROR, "GetClassName() requires an object");
+		delete this;
+		return nullptr;
+	}
+	ValueType = TypeName;
+	return this;
+}
+
+ExpEmit FxGetClassName::Emit(VMFunctionBuilder *build)
+{
+	ExpEmit op = Self->Emit(build);
+	op.Free(build);
+	if (Self->IsObject())
+	{
+		ExpEmit to(build, REGT_POINTER);
+		build->Emit(OP_CLSS, to.RegNum, op.RegNum);
+		op = to;
+		op.Free(build);
+	}
+	ExpEmit to(build, REGT_INT);
+	build->Emit(OP_LW, to.RegNum, op.RegNum, build->GetConstantInt(myoffsetof(PClass, TypeName)));
+	return to;
+}
+
+//==========================================================================
+//
+//
+//==========================================================================
+
 FxGetDefaultByType::FxGetDefaultByType(FxExpression *self)
 	:FxExpression(EFX_GetDefaultByType, self->ScriptPosition)
 {

src/scripting/backend/codegen.h

@@ -296,6 +296,7 @@ enum EFxType
 	EFX_NamedNode,
 	EFX_GetClass,
 	EFX_GetParentClass,
+	EFX_GetClassName,
 	EFX_StrLen,
 	EFX_ColorLiteral,
 	EFX_GetDefaultByType,
@@ -1660,6 +1661,24 @@ public:
 	ExpEmit Emit(VMFunctionBuilder *build);
 };
 
+//==========================================================================
+//
+//	FxGetClass
+//
+//==========================================================================
+
+class FxGetClassName : public FxExpression
+{
+	FxExpression *Self;
+
+public:
+
+	FxGetClassName(FxExpression *self);
+	~FxGetClassName();
+	FxExpression *Resolve(FCompileContext&);
+	ExpEmit Emit(VMFunctionBuilder *build);
+};
+
 //==========================================================================
 //
 //	FxGetDefaultByType

wadsrc/static/zscript/base.txt

@@ -342,7 +342,6 @@ class Object native
 	native static uint MSTime();
 	native vararg static void ThrowAbortException(String fmt, ...);
 
-	native Name GetClassName();
 	native virtualscope void Destroy();
 
 	// This does not call into the native method of the same name to avoid problems with objects that get garbage collected late on shutdown.